[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

2019-10-16 Thread GitBox
jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API URL: https://github.com/apache/tinkerpop/pull/1209#issuecomment-542704884 Good catch about `gremlin-io-test`! I've fixed it and declared parameters `final` in the public API.

[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

2019-10-14 Thread GitBox
jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API URL: https://github.com/apache/tinkerpop/pull/1209#issuecomment-541607101 In most cases, writing to and reading from `Buffer` using built in methods will be enough. In cases where providers need to read and write

[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

2019-10-11 Thread GitBox
jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API URL: https://github.com/apache/tinkerpop/pull/1209#issuecomment-541016783 I'll add a couple of utility methods to access the underlying memory of `Buffer` for providers to use if needed.