[GitHub] jorgebay commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
jorgebay commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463122813 It's looking good, I have a doubt: would addition of `ByteIO` and others represent a breaking change for Python

[GitHub] jorgebay commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
jorgebay commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256306608 ## File path:

[GitHub] spmallette commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
spmallette commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256380289 ## File path:

[GitHub] spmallette commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
spmallette commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463189263 The server won't reject `g:Int32` if it's a byte size value but it won't interpret it as a java `Byte`. This

[GitHub] robertdale commented on issue #1059: Improve download page

2019-02-13 Thread GitBox
robertdale commented on issue #1059: Improve download page URL: https://github.com/apache/tinkerpop/pull/1059#issuecomment-463153417 I pushed a fix. Looks like there is no 'bootstrap-select' class. I changed it to use the standard bootstrap form/select -

[tinkerpop] branch download-page updated: use bootstrap form

2019-02-13 Thread rdale
This is an automated email from the ASF dual-hosted git repository. rdale pushed a commit to branch download-page in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/download-page by this push: new 07ea8fe use bootstrap form

[GitHub] aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463179895 It is. But not sure if we can do otherwise if we want to add this serializer. Stephen, is the server really

[GitHub] aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463220534 oh, right.. at the moment the user will get back a non-deserialized `{''@type': 'gx:Byte', '@value': 42}`. I

[GitHub] aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

2019-02-13 Thread GitBox
aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256417177 ## File path:

[tinkerpop] branch master updated: Use clean plugin to kill .NET directories generated during builds

2019-02-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new bb67885 Use clean plugin to kill .NET

[tinkerpop] branch tp33 updated (095cfb6 -> bb67885)

2019-02-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 095cfb6 Removed unecessary build steps in dotnet and js CTR add bb67885 Use clean plugin to kill .NET

[tinkerpop] branch master updated: Added retry to some tests that were timer based

2019-02-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 29a9a7b Added retry to some tests that

[tinkerpop] branch tp33 updated (bb67885 -> 29a9a7b)

2019-02-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from bb67885 Use clean plugin to kill .NET directories generated during builds add 29a9a7b Added retry to