[GitHub] [tinkerpop] spmallette commented on a change in pull request #1289: TINKERPOP-2374 fix missing authorization with SaslAndHttpBasicAuthenticationHandler

spmallette commented on a change in pull request #1289: URL: https://github.com/apache/tinkerpop/pull/1289#discussion_r432432931 ## File path: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/SaslAndHttpBasicAuthenticationHandler.java ## @@ -47,9

[GitHub] [tinkerpop] spmallette edited a comment on pull request #1289: TINKERPOP-2374 fix missing authorization with SaslAndHttpBasicAuthenticationHandler

spmallette edited a comment on pull request #1289: URL: https://github.com/apache/tinkerpop/pull/1289#issuecomment-634579215 Interesting. Thanks for the fix. We are currently in code freeze on 3.4-dev in preparation for release of 3.4.7. We can get this merged when that release is done.

[tinkerpop] branch master updated: Added a test for valueMap() with id/tokens CTR

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new a8e656b Added a test for valueMap()

[tinkerpop] branch 3.4-dev updated (e11bfed -> a8e656b)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.4-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from e11bfed Add docker build for pre-flight check dev docs CTR add a8e656b Added a test for valueMap()

[tinkerpop] branch master updated (cba6b80 -> dd51992)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from cba6b80 Bumped to Jackson 2.11.x CTR add e11bfed Add docker build for pre-flight check dev docs CTR

[tinkerpop] 01/01: Merge branch '3.4-dev'

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit dd519928b563ecc574056c7c1206afa54b9c27be Merge: cba6b80 e11bfed Author: Stephen Mallette AuthorDate: Fri May 29

[tinkerpop] branch 3.4-dev updated (656fabd -> e11bfed)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.4-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 656fabd Merge branch '3.3-dev' into 3.4-dev add e11bfed Add docker build for pre-flight check dev

[GitHub] [tinkerpop] javeme commented on pull request #1289: TINKERPOP-2374 fix missing authorization with SaslAndHttpBasicAuthenticationHandler

javeme commented on pull request #1289: URL: https://github.com/apache/tinkerpop/pull/1289#issuecomment-636199113 @spmallette @divijvaidya Thanks for your review. I don’t think this is a workaround, I'm sure there is no race condition here, let me explain the steps to reproduce this

[GitHub] [tinkerpop] divijvaidya commented on pull request #1289: TINKERPOP-2374 fix missing authorization with SaslAndHttpBasicAuthenticationHandler

divijvaidya commented on pull request #1289: URL: https://github.com/apache/tinkerpop/pull/1289#issuecomment-636244153 Really appreciate the detailed explanation @javeme. We are on the same page here. While writing my explanation, I missed that step#7 is not adding the http-authenticator