[GitHub] spmallette commented on issue #1029: Updates the API within the core project.
spmallette commented on issue #1029: Updates the API within the core project. URL: https://github.com/apache/tinkerpop/pull/1029#issuecomment-455150094 I hate to be a bother but our git workflow goes from `tp33 --> master`. we typically don't make it a habit of cherrypicking commits backwards in the flow as it makes the git history messy. i'd much prefer a rebase on tp33 with a squash of all these commits into one. we can then merge forward to master. if you need to apply additional changes on master as they only apply there then that can come as a separate PR. In general, it's best to always target tp33 with your PRs unless there is explicit reason not to. If you ever have doubts on what branch to target, feel free to ask ahead of time. sorry for the hassle and thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] otaviojava commented on issue #1029: Updates the API within the core project.
otaviojava commented on issue #1029: Updates the API within the core project. URL: https://github.com/apache/tinkerpop/pull/1029#issuecomment-455143079 Nice, as soon it is merged we can work in a cherry-pick :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated (2ff1958 -> 5b4f371)
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 2ff1958 Merge branch 'tp33' add 346d984 TINKERPOP-2130 Fix default parameter assignment in Connection ctor add e23cf5e Merge pull request #1038 from nivsherf/TINKERPOP-2130 new 5b4f371 Merge branch 'tp33' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/javascript/gremlin-javascript/lib/driver/connection.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[tinkerpop] 01/01: Merge branch 'tp33'
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 5b4f37140d6e60986891132dd44f2bed92974000 Merge: 2ff1958 e23cf5e Author: Jorge Bay Gondra AuthorDate: Thu Jan 17 10:17:06 2019 +0100 Merge branch 'tp33' .../src/main/javascript/gremlin-javascript/lib/driver/connection.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[tinkerpop] branch tp33 updated: TINKERPOP-2130 Fix default parameter assignment in Connection ctor
This is an automated email from the ASF dual-hosted git repository.
jorgebg pushed a commit to branch tp33
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/tp33 by this push:
new 346d984 TINKERPOP-2130 Fix default parameter assignment in Connection
ctor
new e23cf5e Merge pull request #1038 from nivsherf/TINKERPOP-2130
346d984 is described below
commit 346d984b0026206c198ad38ffbfcc3e261e8f830
Author: Niv Sherf
AuthorDate: Thu Jan 10 15:38:07 2019 +0200
TINKERPOP-2130 Fix default parameter assignment in Connection ctor
---
.../src/main/javascript/gremlin-javascript/lib/driver/connection.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
index 76d3cf0..0ae340c 100644
---
a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
+++
b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
@@ -70,7 +70,7 @@ class Connection extends EventEmitter {
super();
this.url = url;
-this.options = options || {};
+this.options = options = options || {};
// A map containing the request id and the handler
this._responseHandlers = {};
[GitHub] jorgebay merged pull request #1038: TINKERPOP-2130 Fix default parameter assignment in Connection ctor
jorgebay merged pull request #1038: TINKERPOP-2130 Fix default parameter assignment in Connection ctor URL: https://github.com/apache/tinkerpop/pull/1038 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
