[tinkerpop] branch TINKERPOP-2182 updated (c756b1d -> 1cbe307)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2182 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard c756b1d TINKERPOP-2182 Removed gperfutils dependencies in Console new 1cbe307 TINKERPOP-2182 Removed gperfutils dependencies in Console This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c756b1d) \ N -- N -- N refs/heads/TINKERPOP-2182 (1cbe307) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14077 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/src/reference/gremlin-applications.asciidoc | 34 +++- 1 file changed, 9 insertions(+), 25 deletions(-)
[tinkerpop] branch TINKERPOP-2182 updated: TINKERPOP-2182 Removed gperfutils dependencies in Console
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-2182
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/TINKERPOP-2182 by this push:
new c756b1d TINKERPOP-2182 Removed gperfutils dependencies in Console
c756b1d is described below
commit c756b1d34c500cac879956033530b3382ffcb4fa
Author: Stephen Mallette
AuthorDate: Tue Apr 2 18:49:39 2019 -0400
TINKERPOP-2182 Removed gperfutils dependencies in Console
---
CHANGELOG.asciidoc | 2 +-
docs/src/upgrade/release-3.3.x.asciidoc| 33
gremlin-console/pom.xml| 10 -
.../console/jsr223/UtilitiesGremlinPlugin.java | 46 +-
4 files changed, 35 insertions(+), 56 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 88df8ad..8f17a02 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -23,9 +23,9 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
[[release-3-3-7]]
=== TinkerPop 3.3.7 (Release Date: NOT OFFICIALLY RELEASED YET)
+* Removed `gperfutils` dependencies from Gremlin Console.
* Ensure `gremlin.sh` works when directories contain spaces
-
[[release-3-3-6]]
=== TinkerPop 3.3.6 (Release Date: March 18, 2019)
diff --git a/docs/src/upgrade/release-3.3.x.asciidoc
b/docs/src/upgrade/release-3.3.x.asciidoc
index c1911d3..2b5db1a 100644
--- a/docs/src/upgrade/release-3.3.x.asciidoc
+++ b/docs/src/upgrade/release-3.3.x.asciidoc
@@ -27,6 +27,39 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.7/CHANGELOG.asciidoc#release-3-3-7[changelog]
for a complete list of all the modifications that are part of this release.
+=== Upgrading for Users
+
+ Removed gperfutils Dependency
+
+Gremlin Console included references to:
+
+[source,xml]
+
+
+org.gperfutils
+gbench
+
+
+org.gperfutils
+gprof
+ :install org.gperfutils gbench
+gremlin> :install org.gperfutils gprof
+
+
+and then import the appropriate classes and methods to use.
+
+See: link:https://issues.apache.org/jira/browse/TINKERPOP-2182[TINKERPOP-2182]
+
== TinkerPop 3.3.6
*Release Date: March 18, 2019*
diff --git a/gremlin-console/pom.xml b/gremlin-console/pom.xml
index 52d1346..a3376a0 100644
--- a/gremlin-console/pom.xml
+++ b/gremlin-console/pom.xml
@@ -56,16 +56,6 @@ limitations under the License.
${project.version}
-org.gperfutils
-gbench
-0.4.3-groovy-2.4
-
-
-org.gperfutils
-gprof
-0.3.1-groovy-2.4
-
-
org.slf4j
slf4j-log4j12
true
diff --git
a/gremlin-console/src/main/java/org/apache/tinkerpop/gremlin/console/jsr223/UtilitiesGremlinPlugin.java
b/gremlin-console/src/main/java/org/apache/tinkerpop/gremlin/console/jsr223/UtilitiesGremlinPlugin.java
index 6b8f9d3..faa6227 100644
---
a/gremlin-console/src/main/java/org/apache/tinkerpop/gremlin/console/jsr223/UtilitiesGremlinPlugin.java
+++
b/gremlin-console/src/main/java/org/apache/tinkerpop/gremlin/console/jsr223/UtilitiesGremlinPlugin.java
@@ -18,11 +18,8 @@
*/
package org.apache.tinkerpop.gremlin.console.jsr223;
-import groovyx.gprof.ProfileStaticExtension;
import org.apache.tinkerpop.gremlin.jsr223.AbstractGremlinPlugin;
-import org.apache.tinkerpop.gremlin.jsr223.DefaultImportCustomizer;
import org.apache.tinkerpop.gremlin.jsr223.DefaultScriptCustomizer;
-import org.apache.tinkerpop.gremlin.jsr223.ImportCustomizer;
import org.apache.tinkerpop.gremlin.jsr223.ScriptCustomizer;
import java.io.BufferedReader;
@@ -30,8 +27,6 @@ import java.io.InputStreamReader;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
-import java.util.Map;
-import java.util.concurrent.Callable;
/**
* @author Stephen Mallette (http://stephen.genoprime.com)
@@ -40,49 +35,10 @@ public class UtilitiesGremlinPlugin extends
AbstractGremlinPlugin {
private static final String NAME = "tinkerpop.utilities";
-private static final ImportCustomizer imports;
-
private static final ScriptCustomizer scripts;
static {
try {
-imports = DefaultImportCustomizer.build()
-.addClassImports(groovyx.gbench.Benchmark.class,
-groovyx.gbench.BenchmarkBuilder.class,
-groovyx.gbench.BenchmarkConstants.class,
-groovyx.gbench.BenchmarkContext.class,
-groovyx.gbench.Benchmarker.class,
-groovyx.gbench.BenchmarkList.class,
-groovyx.gbench.BenchmarkLogger.class,
-
[tinkerpop] branch TINKERPOP-2182 created (now 70c8f7e)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2182 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at 70c8f7e Bump GMavenPlus to 1.6.3 CTR No new revisions were added by this update.
[tinkerpop] branch TINKERPOP-2076 updated (5559e8c -> b2900f5)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2076 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 5559e8c TINKERPOP-2076 Fixed Gremlin Server integration tests after Java 11 discard 79c8a93 TINKERPOP-2076 Fixed failing GraphComputer test after Java 11 upgrade discard 0410d31 TINKERPOP-2076 Made expectations around mock more explicit discard e7307c7 TINKERPOP-2076 Bumped Hadoop to 2.7.7 discard 7807a0c TINKERPOP-2076 Backport 759d1a724eef3f76b48508ba8c49dcb992eff28f from Groovy 2.5.3 upgrade discard 0e015f7 TINKERPOP-2076 Initial effort to get TinkerPop building on Java 11 new 484b826 Minor instructional update in release docs CTR new c5d5018 Minor instructional change in dev doc to be more efficient CTR new 3284f2e Move assert of logs out after the Cluster is closed new 918591a Update changelog/upgrade docs for 3.3.6 release CTR new 3732a8a TinkerPop 3.3.6 release new 5321dfe Removed some fancy bits that were added to try to speed up build new 232dc99 fixed links - CTR new 81577d5 fixed links - CTR new 2dc3091 Bump to 3.3.7-SNAPSHOT CTR new 45710b1 Bound twine to 1.12.1 as latest version doesn't do auth right for some reason new 4a78c6b minor edit - ` won't render if end markup doesn't have trailing space - CTR new 993a443 more minor ` edits - CTR new b6ec19f minor asciidoc fix - CTR new cff5267 escape __ with + CTR new 4125f94 render code blocks at EOF - CTR new a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces new 70c8f7e Bump GMavenPlus to 1.6.3 CTR new b56e555 TINKERPOP-2076 Initial effort to get TinkerPop building on Java 11 new 0a82d61 TINKERPOP-2076 Backport 759d1a724eef3f76b48508ba8c49dcb992eff28f from Groovy 2.5.3 upgrade new 2089091 TINKERPOP-2076 Bumped Hadoop to 2.7.7 new e1f07b3 TINKERPOP-2076 Made expectations around mock more explicit new c00d311 TINKERPOP-2076 Fixed failing GraphComputer test after Java 11 upgrade new b2900f5 TINKERPOP-2076 Fixed Gremlin Server integration tests after Java 11 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5559e8c) \ N -- N -- N refs/heads/TINKERPOP-2076 (b2900f5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14082 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 60 +++--- docs/preprocessor/awk/tabify.awk | 7 +++ docs/src/dev/developer/for-committers.asciidoc | 8 +-- docs/src/dev/developer/release.asciidoc| 4 +- docs/src/dev/provider/index.asciidoc | 4 +- .../src/recipes/traversal-component-reuse.asciidoc | 2 +- docs/src/reference/gremlin-applications.asciidoc | 2 +- docs/src/reference/gremlin-variants.asciidoc | 12 ++--- docs/src/reference/implementations-giraph.asciidoc | 2 +- docs/src/reference/implementations-neo4j.asciidoc | 2 +- docs/src/reference/implementations-spark.asciidoc | 2 +- docs/src/reference/the-traversal.asciidoc | 4 +- docs/src/tutorials/getting-started/index.asciidoc | 14 ++--- .../gremlin-language-variants/index.asciidoc | 6 +-- .../tutorials/the-gremlin-console/index.asciidoc | 4 +- docs/src/upgrade/release-3.3.x.asciidoc| 19 ++- giraph-gremlin/pom.xml | 2 +- gremlin-archetype/gremlin-archetype-dsl/pom.xml| 2 +- gremlin-archetype/gremlin-archetype-server/pom.xml | 2 +- .../gremlin-archetype-tinkergraph/pom.xml | 2 +- gremlin-archetype/pom.xml | 2 +- gremlin-console/bin/gremlin.sh | 2 +- gremlin-console/pom.xml| 2 +- gremlin-console/src/main/bin/gremlin.sh| 18 +++ gremlin-core/pom.xml | 2 +- gremlin-dotnet/pom.xml | 2 +- .../Gremlin.Net.Template.csproj| 2 +- .../Gremlin.Net.Template.nuspec| 2 +- gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 4 +- gremlin-dotnet/src/pom.xml
[GitHub] [tinkerpop] spmallette opened a new pull request #1088: TINKERPOP-2181 Allow ctrl+c to break a command in Gremlin Console
spmallette opened a new pull request #1088: TINKERPOP-2181 Allow ctrl+c to
break a command in Gremlin Console
URL: https://github.com/apache/tinkerpop/pull/1088
https://issues.apache.org/jira/browse/TINKERPOP-2181
Pretty self-explanatory:
```text
gremlin> java.util.stream.IntStream.range(0, 1).iterator()
==>0
==>1
==>2
==>3
==>4
...
==>348
==>349
==>350
==>351
==>352
Execution interrupted by ctrl+c
==>353
gremlin> Thread.sleep(5000)
Execution interrupted by ctrl+c
sleep interrupted
Type ':help' or ':h' for help.
Display stack trace? [yN]n
gremlin> g = TinkerGraph.open().traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g.addV().as('a').addE('link').to('a')
==>e[1][0-link->0]
gremlin> g.V().repeat(out('link'))
Execution interrupted by ctrl+c
org.apache.tinkerpop.gremlin.process.traversal.util.TraversalInterruptedException
Type ':help' or ':h' for help.
Display stack trace? [yN]n
gremlin> :remote connect tinkerpop.server conf/remote.yaml
==>Configured localhost/127.0.0.1:8182
gremlin> :> g.addV().as('a').addE('link').to('a')
==>e[1][0-link->0]
gremlin> :> g.V().repeat(out('link'))
Execution interrupted by ctrl+c
org.apache.tinkerpop.gremlin.jsr223.console.RemoteException
Type ':help' or ':h' for help.
Display stack trace? [yN]n
gremlin> :remote console
==>All scripts will now be sent to Gremlin Server -
[localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
gremlin> g.V().repeat(out('link'))
Execution interrupted by ctrl+c
org.apache.tinkerpop.gremlin.jsr223.console.RemoteException
Type ':help' or ':h' for help.
Display stack trace? [yN]n
```
Right now it will only interrupt things that respect an actual interruption
so while all of the above works nicely, something like `while(true){}` will
not. This issue appears fixable on 3.4.x but not 3.3.x given some changes to
groovysh in the 2.5.x line which is not available for 3.3.x and still on 2.4.x.
Backporting those changes and/or working around not having those changes is
pretty ugly unfortunately. Still considering what to do, but I thought I'd
issue the PR so folks could play with it if they like.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[tinkerpop] branch TINKERPOP-2181 updated (9914226 -> ecced7b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2181 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 9914226 TINKERPOP-2181 Allow ctrl+c to break a command in Gremlin Console new 4a78c6b minor edit - ` won't render if end markup doesn't have trailing space - CTR new 993a443 more minor ` edits - CTR new b6ec19f minor asciidoc fix - CTR new cff5267 escape __ with + CTR new 4125f94 render code blocks at EOF - CTR new a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces new 70c8f7e Bump GMavenPlus to 1.6.3 CTR new ecced7b TINKERPOP-2181 Allow ctrl+c to break a command in Gremlin Console This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9914226) \ N -- N -- N refs/heads/TINKERPOP-2181 (ecced7b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14077 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 13 +++-- docs/preprocessor/awk/tabify.awk | 7 +++ docs/src/recipes/traversal-component-reuse.asciidoc| 2 +- docs/src/reference/gremlin-variants.asciidoc | 12 ++-- docs/src/reference/the-traversal.asciidoc | 4 ++-- .../tutorials/gremlin-language-variants/index.asciidoc | 6 +++--- docs/src/tutorials/the-gremlin-console/index.asciidoc | 2 +- gremlin-console/src/main/bin/gremlin.sh| 18 +- pom.xml| 2 +- 9 files changed, 37 insertions(+), 29 deletions(-)
[tinkerpop] branch master updated: Bump GMavenPlus to 1.6.3 CTR
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 70c8f7e Bump GMavenPlus to 1.6.3 CTR new 216e9fe Merge branch 'tp33' 70c8f7e is described below commit 70c8f7e12c188b99dc6f695954099447e7e82f15 Author: Stephen Mallette AuthorDate: Tue Apr 2 15:26:45 2019 -0400 Bump GMavenPlus to 1.6.3 CTR --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b397d1d..1a1bf26 100644 --- a/pom.xml +++ b/pom.xml @@ -570,7 +570,7 @@ limitations under the License. org.codehaus.gmavenplus gmavenplus-plugin -1.6 +1.6.3 1.8 true
[tinkerpop] branch tp33 updated (a162109 -> 70c8f7e)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces add 70c8f7e Bump GMavenPlus to 1.6.3 CTR No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [tinkerpop] newkek commented on issue #1083: TINKERPOP-2179: Have SerializationException extend IOException
newkek commented on issue #1083: TINKERPOP-2179: Have SerializationException extend IOException URL: https://github.com/apache/tinkerpop/pull/1083#issuecomment-479159474 @spmallette both this PR and the `master` PR have been rebased on the latest base branches. The master PR does not seem to have the extra commits anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1
spmallette commented on issue #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 URL: https://github.com/apache/tinkerpop/pull/1086#issuecomment-479142140 not sure - this is going to gremlin-core so having a non-standard repo might mess with things like grape/plugins maybe. i wasn't 100% sure we'd use the RedHat thing...i figured it would take a bit of thought/discussion. of course, without something like the RedHat artifact, the version stays stuck with the security problem along 3.3.x and 3.4.x unless we choose to accept a major breaking change in either of those lines. i still don't know when we want to allow for such things (i.e. take a major breaking change to fix a security problem). i guess it's done on a case-by-case basis perhaps - so, is the seriousness of this commons-configuration issue enough to force us to bump 3.3.x and 3.4.x or can it wait for 3.5.x? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] robertdale commented on issue #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1
robertdale commented on issue #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 URL: https://github.com/apache/tinkerpop/pull/1086#issuecomment-479137235 We would have to add the RH repo to the pom - https://mvnrepository.com/repos/redhat-ga Haven't gotten around to that yet. I'm assuming it's public at this point. But is that something we want to do anyway? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] dkuppitz opened a new pull request #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy
dkuppitz opened a new pull request #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy URL: https://github.com/apache/tinkerpop/pull/1087 https://issues.apache.org/jira/browse/TINKERPOP-2191 Implemented `EdgeLabelVerificationStrategy` to allow providers to encourage (or enforce) users to always specify edge labels. VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] 01/01: Implemented EdgeLabelVerificationStrategy
This is an automated email from the ASF dual-hosted git repository.
dkuppitz pushed a commit to branch TINKERPOP-2191
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit ce7c5ea4503c651210cc7e4dfb444eadb0df9099
Author: Daniel Kuppitz
AuthorDate: Thu Mar 14 15:05:09 2019 -0700
Implemented EdgeLabelVerificationStrategy
---
CHANGELOG.asciidoc | 2 +-
docs/src/upgrade/release-3.3.x.asciidoc| 38 +
.../tinkerpop/gremlin/jsr223/CoreImports.java | 2 +
.../EdgeLabelVerificationStrategy.java | 130 ++
.../structure/io/graphson/GraphSONModule.java | 5 +
.../gremlin/structure/io/gryo/GryoVersion.java | 7 +-
.../EdgeLabelVerificationStrategyTest.java | 188 +
7 files changed, 369 insertions(+), 3 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 88df8ad..106761a 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -24,7 +24,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
=== TinkerPop 3.3.7 (Release Date: NOT OFFICIALLY RELEASED YET)
* Ensure `gremlin.sh` works when directories contain spaces
-
+* Implemented `EdgeLabelVerificationStrategy`
[[release-3-3-6]]
=== TinkerPop 3.3.6 (Release Date: March 18, 2019)
diff --git a/docs/src/upgrade/release-3.3.x.asciidoc
b/docs/src/upgrade/release-3.3.x.asciidoc
index c1911d3..a5ece72 100644
--- a/docs/src/upgrade/release-3.3.x.asciidoc
+++ b/docs/src/upgrade/release-3.3.x.asciidoc
@@ -27,6 +27,44 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.7/CHANGELOG.asciidoc#release-3-3-7[changelog]
for a complete list of all the modifications that are part of this release.
+=== Upgrading for Providers
+
+ Detection of Anti-Patterns
+
+This release adds a strategy named `EdgeLabelVerificationStrategy`. The
strategy will not be added by default to the traversal source, however,
providers can add it explicitly to encourage (or enforce)
+users to always specify at least one edge label.
`EdgeLabelVerificationStrategy` can be configured to either throw an exception
if no edge label was specified, log a warning or do both.
+
+[source,text]
+
+gremlin> // throw an exception if edge label was not specified
+gremlin> g =
TinkerFactory.createModern().traversal().withStrategies(EdgeLabelVerificationStrategy.build().throwException().create())
+==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
+gremlin> g.V(1).out('knows')
+==>v[2]
+==>v[4]
+gremlin> g.V(1).out()
+The provided traversal contains a vertex step without any specified edge
label: VertexStep(OUT,vertex)
+Type ':help' or ':h' for help.
+Display stack trace? [yN]
+
+
+[source,text]
+
+gremlin> // log a warning if edge label was not specified (Log4j has to be
configured properly)
+gremlin> g =
TinkerFactory.createModern().traversal().withStrategies(EdgeLabelVerificationStrategy.build().logWarning().create())
+==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
+gremlin> g.V(1).out('knows')
+==>v[2]
+==>v[4]
+gremlin> g.V(1).out()
+WARN
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.EdgeLabelVerificationStrategy
- The provided traversal contains a vertex step without any specified edge
label: VertexStep(OUT,vertex)
+==>v[3]
+==>v[2]
+==>v[4]
+
+
+See: link:https://issues.apache.org/jira/browse/TINKERPOP-2191[TINKERPOP-2191]
+
== TinkerPop 3.3.6
*Release Date: March 18, 2019*
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
index 576d0de..e298951 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
@@ -86,6 +86,7 @@ import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.Orde
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.PathProcessorStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.CountStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ComputerVerificationStrategy;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.EdgeLabelVerificationStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.LambdaRestrictionStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ReadOnlyStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy;
@@ -241,6 +242,7 @@ public final class CoreImports {
CLASS_IMPORTS.add(LambdaRestrictionStrategy.class);
CLASS_IMPORTS.add(ReadOnlyStrategy.class);
[tinkerpop] branch TINKERPOP-2191 updated (ee7433c -> ce7c5ea)
This is an automated email from the ASF dual-hosted git repository. dkuppitz pushed a change to branch TINKERPOP-2191 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard ee7433c Implemented EdgeLabelVerificationStrategy new ce7c5ea Implemented EdgeLabelVerificationStrategy This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ee7433c) \ N -- N -- N refs/heads/TINKERPOP-2191 (ce7c5ea) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 2 +- docs/src/upgrade/release-3.3.x.asciidoc | 38 + 2 files changed, 39 insertions(+), 1 deletion(-)
[tinkerpop] 01/01: Implemented EdgeLabelVerificationStrategy
This is an automated email from the ASF dual-hosted git repository.
dkuppitz pushed a commit to branch TINKERPOP-2191
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit ee7433c076a7cc0d36fa3566d622bbe96a3d308f
Author: Daniel Kuppitz
AuthorDate: Thu Mar 14 15:05:09 2019 -0700
Implemented EdgeLabelVerificationStrategy
---
.../tinkerpop/gremlin/jsr223/CoreImports.java | 2 +
.../EdgeLabelVerificationStrategy.java | 130 ++
.../structure/io/graphson/GraphSONModule.java | 5 +
.../gremlin/structure/io/gryo/GryoVersion.java | 7 +-
.../EdgeLabelVerificationStrategyTest.java | 188 +
5 files changed, 330 insertions(+), 2 deletions(-)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
index 576d0de..e298951 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
@@ -86,6 +86,7 @@ import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.Orde
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.PathProcessorStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.CountStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ComputerVerificationStrategy;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.EdgeLabelVerificationStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.LambdaRestrictionStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ReadOnlyStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy;
@@ -241,6 +242,7 @@ public final class CoreImports {
CLASS_IMPORTS.add(LambdaRestrictionStrategy.class);
CLASS_IMPORTS.add(ReadOnlyStrategy.class);
CLASS_IMPORTS.add(StandardVerificationStrategy.class);
+CLASS_IMPORTS.add(EdgeLabelVerificationStrategy.class);
// graph traversal
CLASS_IMPORTS.add(AnonymousTraversalSource.class);
CLASS_IMPORTS.add(__.class);
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
new file mode 100644
index 000..a4fd804
--- /dev/null
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.process.traversal.strategy.verification;
+
+import org.apache.commons.configuration.Configuration;
+import org.apache.commons.configuration.MapConfiguration;
+import org.apache.tinkerpop.gremlin.process.traversal.Step;
+import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
+import org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStep;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.AbstractTraversalStrategy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * {@code EdgeLabelVerificationStrategy} does not allow edge traversal steps
to have no label specified.
+ * Providing one or more labels is considered to be a best practice, however,
TinkerPop will not force the specification
+ * of edge labels; instead, providers or users will have to enable this
strategy explicitly.
+ *
+ *
+ * @author Daniel Kuppitz (http://gremlin.guru)
+ * @example
+ * __.outE() // throws an IllegalStateException
+ * __.out()// throws an IllegalStateException
+ * __.bothE() // throws an IllegalStateException
+ * __.to(OUT) // throws an IllegalStateException
+ *
[tinkerpop] branch TINKERPOP-2191 updated (21bfb55 -> ee7433c)
This is an automated email from the ASF dual-hosted git repository. dkuppitz pushed a change to branch TINKERPOP-2191 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 21bfb55 Implemented EdgeLabelVerificationStrategy new ee7433c Implemented EdgeLabelVerificationStrategy This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (21bfb55) \ N -- N -- N refs/heads/TINKERPOP-2191 (ee7433c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../traversal/strategy/verification/EdgeLabelVerificationStrategy.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[tinkerpop] branch TINKERPOP-2191 created (now 21bfb55)
This is an automated email from the ASF dual-hosted git repository. dkuppitz pushed a change to branch TINKERPOP-2191 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at 21bfb55 Implemented EdgeLabelVerificationStrategy This branch includes the following new commits: new 21bfb55 Implemented EdgeLabelVerificationStrategy The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[tinkerpop] 01/01: Implemented EdgeLabelVerificationStrategy
This is an automated email from the ASF dual-hosted git repository.
dkuppitz pushed a commit to branch TINKERPOP-2191
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 21bfb55e12ffd86dad9de39bbaf155ae6bac39fc
Author: Daniel Kuppitz
AuthorDate: Thu Mar 14 15:05:09 2019 -0700
Implemented EdgeLabelVerificationStrategy
---
.../tinkerpop/gremlin/jsr223/CoreImports.java | 2 +
.../EdgeLabelVerificationStrategy.java | 130 ++
.../structure/io/graphson/GraphSONModule.java | 5 +
.../gremlin/structure/io/gryo/GryoVersion.java | 7 +-
.../EdgeLabelVerificationStrategyTest.java | 188 +
5 files changed, 330 insertions(+), 2 deletions(-)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
index 576d0de..e298951 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
@@ -86,6 +86,7 @@ import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.Orde
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.PathProcessorStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.CountStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ComputerVerificationStrategy;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.EdgeLabelVerificationStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.LambdaRestrictionStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ReadOnlyStrategy;
import
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy;
@@ -241,6 +242,7 @@ public final class CoreImports {
CLASS_IMPORTS.add(LambdaRestrictionStrategy.class);
CLASS_IMPORTS.add(ReadOnlyStrategy.class);
CLASS_IMPORTS.add(StandardVerificationStrategy.class);
+CLASS_IMPORTS.add(EdgeLabelVerificationStrategy.class);
// graph traversal
CLASS_IMPORTS.add(AnonymousTraversalSource.class);
CLASS_IMPORTS.add(__.class);
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
new file mode 100644
index 000..1b8876a
--- /dev/null
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/verification/EdgeLabelVerificationStrategy.java
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.process.traversal.strategy.verification;
+
+import org.apache.commons.configuration.Configuration;
+import org.apache.commons.configuration.MapConfiguration;
+import org.apache.tinkerpop.gremlin.process.traversal.Step;
+import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
+import org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStep;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.AbstractTraversalStrategy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * {@code EdgeLabelVerificationStrategy} does not allow edge traversal steps
to have no label specified.
+ * Providing one or more labels is considered to be a best practice, however,
TinkerPop will not force the specification
+ * of edge labels; instead, providers or users will have to enable this
strategy explicitly.
+ *
+ *
+ * @author Daniel Kujppitz (http://gremlin.guru)
+ * @example
+ * __.outE() // throws an IllegalStateException
+ * __.out()// throws an IllegalStateException
+ * __.bothE() // throws an IllegalStateException
+ * __.to(OUT) // throws an IllegalStateException
+ *
[GitHub] [tinkerpop] robertdale opened a new pull request #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1
robertdale opened a new pull request #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 URL: https://github.com/apache/tinkerpop/pull/1086 https://issues.apache.org/jira/browse/TINKERPOP-2185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch TINKERPOP-2185 created (now c8353ff)
This is an automated email from the ASF dual-hosted git repository. rdale pushed a change to branch TINKERPOP-2185 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at c8353ff TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 This branch includes the following new commits: new c8353ff TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[tinkerpop] 01/01: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1
This is an automated email from the ASF dual-hosted git repository. rdale pushed a commit to branch TINKERPOP-2185 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit c8353ffa76d0a4823d05bf4511e46d50a0767d44 Author: Robert Dale AuthorDate: Tue Apr 2 13:20:04 2019 -0400 TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1 --- CHANGELOG.asciidoc | 1 + pom.xml| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index 88df8ad..d8bc285 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -24,6 +24,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima === TinkerPop 3.3.7 (Release Date: NOT OFFICIALLY RELEASED YET) * Ensure `gremlin.sh` works when directories contain spaces +* Bump `commons-configuration` to 1.10.0.redhat-1 [[release-3-3-6]] diff --git a/pom.xml b/pom.xml index b397d1d..2e6db60 100644 --- a/pom.xml +++ b/pom.xml @@ -137,7 +137,7 @@ limitations under the License. https://github.com/apache/tinkerpop -1.10 + 1.10.0.redhat-1 2.6 3.8.1 2.4.16
[tinkerpop] branch TINKERPOP-2112 updated (78f0f04 -> ec9cb1f)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2112 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 78f0f04 TINKERPOP-2112 Fold property() so that T values can work in any order new a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces new ec9cb1f TINKERPOP-2112 Fold property() so that T values can work in any order This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (78f0f04) \ N -- N -- N refs/heads/TINKERPOP-2112 (ec9cb1f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14076 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-console/src/main/bin/gremlin.sh | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-)
[tinkerpop] branch tp33 updated (4125f94 -> a162109)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 4125f94 render code blocks at EOF - CTR add a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 2 ++ gremlin-console/src/main/bin/gremlin.sh | 18 +- 2 files changed, 11 insertions(+), 9 deletions(-)
[GitHub] [tinkerpop] spmallette merged pull request #1085: TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces
spmallette merged pull request #1085: TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces URL: https://github.com/apache/tinkerpop/pull/1085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated: TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new a162109 TINKERPOP-2180: Ensure gremlin.sh works when directories
contain spaces
new 91732e3 Merge branch 'tp33'
a162109 is described below
commit a16210903a4d9185de05e471870ae2f99f60fcf7
Author: Eduard Tudenhoefner
AuthorDate: Wed Mar 20 11:16:15 2019 +0100
TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces
---
CHANGELOG.asciidoc | 2 ++
gremlin-console/src/main/bin/gremlin.sh | 18 +-
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index cbd55b9..88df8ad 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -23,6 +23,8 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
[[release-3-3-7]]
=== TinkerPop 3.3.7 (Release Date: NOT OFFICIALLY RELEASED YET)
+* Ensure `gremlin.sh` works when directories contain spaces
+
[[release-3-3-6]]
=== TinkerPop 3.3.6 (Release Date: March 18, 2019)
diff --git a/gremlin-console/src/main/bin/gremlin.sh
b/gremlin-console/src/main/bin/gremlin.sh
index d8c94db..6253ee1 100755
--- a/gremlin-console/src/main/bin/gremlin.sh
+++ b/gremlin-console/src/main/bin/gremlin.sh
@@ -22,20 +22,20 @@
set -e
set -u
-USER_DIR=`pwd`
+USER_DIR=$(pwd)
-cd $(dirname $0)
-DIR=`pwd`
+cd "$(dirname "$0")"
+DIR=$(pwd)
-SCRIPT_NAME=`basename $0`
+SCRIPT_NAME="$(basename "$0")"
while [ -h "${SCRIPT_NAME}" ]; do
SOURCE="$(readlink "${SCRIPT_NAME}")"
DIR="$( cd -P "$( dirname "${SOURCE}" )" && pwd )"
- cd ${DIR}
+ cd "${DIR}"
done
cd ..
-SYSTEM_EXT_DIR="`pwd`/ext"
+SYSTEM_EXT_DIR="$(pwd)/ext"
JAVA_OPTIONS=${JAVA_OPTIONS:-}
@@ -43,11 +43,11 @@ if [ ! -z "${JAVA_OPTIONS}" ]; then
USER_EXT_DIR=$(grep -o '\-Dtinkerpop.ext=\(\([^"][^ ]*\)\|\("[^"]*"\)\)' <<<
"${JAVA_OPTIONS}" | cut -f2 -d '=' | xargs -0 echo)
if [ ! -z "${USER_EXT_DIR}" -a ! -d "${USER_EXT_DIR}" ]; then
mkdir -p "${USER_EXT_DIR}"
-cp -R ${SYSTEM_EXT_DIR}/* ${USER_EXT_DIR}/
+cp -R "${SYSTEM_EXT_DIR}/*" "${USER_EXT_DIR}/"
fi
fi
-case `uname` in
+case $(uname) in
CYGWIN*)
CP="${CP:-}";$( echo lib/*.jar . | sed 's/ /;/g')
;;
@@ -103,4 +103,4 @@ if [ -n "$SCRIPT_DEBUG" ]; then
fi
# Start the JVM, execute the application, and return its exit code
-exec $JAVA $JAVA_OPTIONS org.apache.tinkerpop.gremlin.console.Console "$@"
+exec $JAVA "$JAVA_OPTIONS" org.apache.tinkerpop.gremlin.console.Console "$@"
[GitHub] [tinkerpop] newkek commented on issue #1084: TINKERPOP-2179: Have SerializationException extend IOException [master]
newkek commented on issue #1084: TINKERPOP-2179: Have SerializationException extend IOException [master] URL: https://github.com/apache/tinkerpop/pull/1084#issuecomment-479022571 Yes I'll rebase, no worries. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] nastra commented on issue #1085: TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces
nastra commented on issue #1085: TINKERPOP-2180: Ensure gremlin.sh works when directories contain spaces URL: https://github.com/apache/tinkerpop/pull/1085#issuecomment-478877366 @spmallette rebased onto latest `tp33` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
