[GitHub] [tinkerpop] divijvaidya commented on issue #1102: TINKERPOP-2204 Do not consume the exception while generating metadata
divijvaidya commented on issue #1102: TINKERPOP-2204 Do not consume the exception while generating metadata URL: https://github.com/apache/tinkerpop/pull/1102#issuecomment-488089904 Thank you for your review. Yes, as you identified, this bug exists in TP33 as well. Please go ahead and add the change log entry during merge for this one, I will make sure to add one in the future PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1102: TINKERPOP-2204 Do not consume the exception while generating metadata
spmallette commented on issue #1102: TINKERPOP-2204 Do not consume the exception while generating metadata URL: https://github.com/apache/tinkerpop/pull/1102#issuecomment-488081475 Interesting. Nice find. The travis failure is known and should be resolved now if you were to rebase. Note that I think this problem also exists on `tp33`: https://github.com/apache/tinkerpop/blob/tp33/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L544 do you agree? if so, i guess I can merge this PR as it is, then backport the change (since it's slightly different). It would be nice if you included a CHANGELOG entry but i can handle that on merge if you'd like. VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated
spmallette commented on issue #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated URL: https://github.com/apache/tinkerpop/pull/1096#issuecomment-488078149 sorry I somehow never found my way back to this PR to merge it. all done now. regarding this from @FlorianHockmann > I'm not quite sure about the process of publishing prerelease / release candidate versions: Is it OK to just publish such a version for one GLV or should we always do a full release across all packages? I'm mostly wondering what will happen if we publish 3.4.2-rc1 for Gremlin.Net and then want to publish another release candidate later as that would have to use 3.4.2-rc2 then to avoid using the same version number twice. I'm still hesitant around "prereleases" given discussions i've seen on various Apache lists. I think I'd like to try to avoid them for the time being, especially since we're looking to do faster releases. I'm thinking we should setup to do 3.3.7/3.4.2 in May, but need to bring that up on the dev list. @bpeav thanks again for this PR - looks like a big fix for folks. hope to see more contributions from you in the future! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated: Added changelog entry CTR
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new fbf1ce7 Added changelog entry CTR fbf1ce7 is described below commit fbf1ce7a5eb8b56dff5067a46767260fab372aee Author: Stephen Mallette AuthorDate: Tue Apr 30 15:06:49 2019 -0400 Added changelog entry CTR --- CHANGELOG.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index 405976e..0783518 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -26,6 +26,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima This release also includes changes from <>. * Allow a `Traversal` to know what `TraversalSource` it spawned from. +* Fixed problem with connection pool sizing and retry. [[release-3-4-1]] === TinkerPop 3.4.1 (Release Date: March 18, 2019)
[GitHub] [tinkerpop] spmallette merged pull request #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated
spmallette merged pull request #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated URL: https://github.com/apache/tinkerpop/pull/1096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated: flipped comparison sign that prevented re-population of connection pool by always early exiting
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new ad7c5ae flipped comparison sign that prevented re-population of
connection pool by always early exiting
new 0f46845 Merge pull request #1096 from bpeav/TINKERPOP-2090
ad7c5ae is described below
commit ad7c5ae74b05caa4979c1f73539434e282734e05
Author: Brett Peavler
AuthorDate: Thu Apr 11 15:53:14 2019 -0500
flipped comparison sign that prevented re-population of connection pool by
always early exiting
---
gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs
b/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs
index 09e20a1..cd35653 100644
--- a/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs
+++ b/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs
@@ -62,7 +62,7 @@ namespace Gremlin.Net.Driver
private async Task EnsurePoolIsPopulatedAsync()
{
// The pool could have been (partially) empty because of
connection problems. So, we need to populate it again.
-if (_poolSize >= NrConnections) return;
+if (_poolSize <= NrConnections) return;
var poolState = Interlocked.CompareExchange(ref _poolState,
PoolPopulationInProgress, PoolIdle);
if (poolState == PoolPopulationInProgress) return;
try
[GitHub] [tinkerpop] jseekamp removed a comment on issue #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated
jseekamp removed a comment on issue #1096: TINKERPOP-2090: Fix Sign for Checking if Connection Pool Needs to be Repopulated URL: https://github.com/apache/tinkerpop/pull/1096#issuecomment-487165375 I went ahead and created a forked version and can confirm that this pull request fixes all the issues I was seeing. I'd be happy to provide more feedback on a pre-release version as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1098: Allow to configure processor in Gremlin-JavaScript
spmallette commented on issue #1098: Allow to configure processor in Gremlin-JavaScript URL: https://github.com/apache/tinkerpop/pull/1098#issuecomment-488075270 Sorry for taking so long with this - I missed notification of the other VOTEs that came in. That travis failure is known - I've just pushed a fix for it. This is merged now. Thanks for contributing - hope to see you around here again! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette merged pull request #1098: Allow to configure processor in Gremlin-JavaScript
spmallette merged pull request #1098: Allow to configure processor in Gremlin-JavaScript URL: https://github.com/apache/tinkerpop/pull/1098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp33 updated (aa10c22 -> 47ba61f)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from aa10c22 Switch docker build to openjdk add cad1b4b Allow to configure processor in Gremlin-JavaScript add 0e391a8 Add the CHANGELOG entry add 2183ced Merge branch 'pr-1098' into tp33 add 47ba61f Minor update to changelog CTR No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + .../gremlin-javascript/lib/driver/client.js| 3 +- .../gremlin-javascript/test/unit/client-test.js| 58 ++ 3 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/client-test.js
[tinkerpop] branch master updated (72ab4ba -> 64e58ea)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 72ab4ba Merge branch 'tp33' new cad1b4b Allow to configure processor in Gremlin-JavaScript new 0e391a8 Add the CHANGELOG entry new 2183ced Merge branch 'pr-1098' into tp33 new 47ba61f Minor update to changelog CTR new 64e58ea Merge branch 'tp33' The 15120 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + .../gremlin-javascript/lib/driver/client.js| 3 +- .../gremlin-javascript/test/unit/client-test.js| 58 ++ 3 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/client-test.js
[tinkerpop] branch TINKERPOP-2196 updated (b0f9957 -> 36b8c36)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2196 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard b0f9957 TINKERPOP-2196 Fixed PartitionStrategy when setting vertex label new 82254f1 Added a test around calling steps with varargs that use arrays CTR new 5e60558 TINKERPOP-2183 Interpreter mode not handling class definitions new 98c40aa Limited logging for a host marked unavailable new 3fdc254 Hardened fold() glv test CTR new aa10c22 Switch docker build to openjdk new 36b8c36 TINKERPOP-2196 Fixed PartitionStrategy when setting vertex label This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b0f9957) \ N -- N -- N refs/heads/TINKERPOP-2196 (36b8c36) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14094 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 3 +++ docker/Dockerfile | 29 +++--- gremlin-console/conf/log4j-console.properties | 1 + .../gremlin/process/traversal/BytecodeTest.java| 20 ++- .../org/apache/tinkerpop/gremlin/driver/Host.java | 6 +++-- .../ast/InterpreterModeASTTransformation.groovy| 9 +-- .../jsr223/GremlinGroovyScriptEngineTest.java | 2 ++ gremlin-test/features/map/Fold.feature | 9 +-- 8 files changed, 52 insertions(+), 27 deletions(-)
[tinkerpop] branch TINKERPOP-2203 updated (7590009 -> b59e3eb)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2203 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 7590009 TINKERPOP-2203 Added console remote timeout to each request new 98c40aa Limited logging for a host marked unavailable new 8819075 Merge branch 'tp33' new 3fdc254 Hardened fold() glv test CTR new aeb393e Merge branch 'tp33' new aa10c22 Switch docker build to openjdk new 72ab4ba Merge branch 'tp33' new b59e3eb TINKERPOP-2203 Added console remote timeout to each request This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7590009) \ N -- N -- N refs/heads/TINKERPOP-2203 (b59e3eb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 15116 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 3 ++- docker/Dockerfile | 29 +++--- gremlin-console/conf/log4j-console.properties | 1 + .../org/apache/tinkerpop/gremlin/driver/Host.java | 6 +++-- gremlin-test/features/map/Fold.feature | 9 +-- 5 files changed, 28 insertions(+), 20 deletions(-)
[GitHub] [tinkerpop] spmallette closed pull request #1104: Switch docker build to openjdk
spmallette closed pull request #1104: Switch docker build to openjdk URL: https://github.com/apache/tinkerpop/pull/1104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp33 updated (3fdc254 -> aa10c22)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 3fdc254 Hardened fold() glv test CTR add aa10c22 Switch docker build to openjdk No new revisions were added by this update. Summary of changes: docker/Dockerfile | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-)
[tinkerpop] branch master updated: Switch docker build to openjdk
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new aa10c22 Switch docker build to openjdk
new 72ab4ba Merge branch 'tp33'
aa10c22 is described below
commit aa10c227dff861b836224ea40626bc8abb5ddcdf
Author: Stephen Mallette
AuthorDate: Tue Apr 30 14:00:09 2019 -0400
Switch docker build to openjdk
Oracle jdk ppa has been discontinued in recent weeks leading to failed
docker builds. CTR
---
docker/Dockerfile | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/docker/Dockerfile b/docker/Dockerfile
index 8de8705..69c8db7 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -19,27 +19,26 @@ FROM ubuntu:trusty
LABEL maintainer="Daniel Kuppitz "
-RUN apt-get update \
-&& apt-get -y install software-properties-common
python-software-properties apt-transport-https curl dpkg \
-&& echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select
true | debconf-set-selections \
-&& add-apt-repository -y ppa:webupd8team/java \
-&& sh -c 'curl -s
https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
-o packages-microsoft-prod.deb' \
-&& sh -c 'dpkg -i packages-microsoft-prod.deb' \
-&& sh -c 'echo "deb https://download.mono-project.com/repo/ubuntu
stable-trusty main" | sudo tee
/etc/apt/sources.list.d/mono-official-stable.list' \
-&& apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys
3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF \
-&& apt-get update \
-&& apt-get install -y oracle-java8-installer gawk git maven openssh-server
subversion zip \
-&& apt-get install -y --force-yes dotnet-sdk-2.2 python python-dev
python3-dev python-pip build-essential mono-devel \
-&& pip install virtualenv virtualenvwrapper \
-&& pip install --upgrade pip \
-&& rm -rf /var/lib/apt/lists/* /var/cache/oracle-jdk8-installer
+RUN apt-get update
+RUN apt-get -y install software-properties-common python-software-properties
apt-transport-https curl dpkg
+RUN add-apt-repository ppa:openjdk-r/ppa
+RUN sh -c 'curl -s
https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
-o packages-microsoft-prod.deb'
+RUN sh -c 'dpkg -i packages-microsoft-prod.deb'
+RUN sh -c 'echo "deb https://download.mono-project.com/repo/ubuntu
stable-trusty main" | sudo tee
/etc/apt/sources.list.d/mono-official-stable.list'
+RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys
3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF
+RUN apt-get update
+RUN apt-get install -y openjdk-8-jdk gawk git maven openssh-server subversion
zip
+RUN apt-get install -y --force-yes dotnet-sdk-2.2 python python-dev
python3-dev python-pip build-essential mono-devel
+RUN pip install virtualenv virtualenvwrapper
+RUN pip install --upgrade pip
+RUN rm -rf /var/lib/apt/lists/* /var/cache/openjdk-8-jdk
RUN sed -i 's@PermitRootLogin without-password@PermitRootLogin yes@'
/etc/ssh/sshd_config
RUN sed -i 's@session\s*required\s*pam_loginuid.so@session optional
pam_loginuuid.so@g' /etc/pam.d/sshd
RUN ssh-keygen -t rsa -f ~/.ssh/id_rsa -N '' \
&& cat ~/.ssh/id_rsa.pub > ~/.ssh/authorized_keys
-ENV JAVA_HOME /usr/lib/jvm/java-8-oracle
+ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
RUN sed -i 's/.*"$PS1".*/# \0/' ~/.bashrc
RUN echo "export JAVA_HOME=${JAVA_HOME}" >> ~/.bashrc
[tinkerpop] branch travis-fix updated (18f838c -> 1f726ce)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch travis-fix in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 18f838c Switch travis build to openjdk new 1f726ce Switch docker build to openjdk This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (18f838c) \ N -- N -- N refs/heads/travis-fix (1f726ce) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 14093 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
[GitHub] [tinkerpop] spmallette opened a new pull request #1104: Switch travis build to openjdk
spmallette opened a new pull request #1104: Switch travis build to openjdk URL: https://github.com/apache/tinkerpop/pull/1104 Oracle jdk ppa has been discontinued in recent weeks leading to failed docker builds. This is basically a CTR fix, but creating a PR to trigger the Travis PR builder to make sure this change works. If testing this locally yourself, I guess you'll need to kill your local docker images. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] 01/01: Switch travis build to openjdk
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 18f838c29aa3933d96e62958ee8338269a787e4b
Author: Stephen Mallette
AuthorDate: Tue Apr 30 14:00:09 2019 -0400
Switch travis build to openjdk
Oracle jdk ppa has been discontinued in recent weeks leading to failed
docker builds. CTR
---
docker/Dockerfile | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/docker/Dockerfile b/docker/Dockerfile
index 8de8705..69c8db7 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -19,27 +19,26 @@ FROM ubuntu:trusty
LABEL maintainer="Daniel Kuppitz "
-RUN apt-get update \
-&& apt-get -y install software-properties-common
python-software-properties apt-transport-https curl dpkg \
-&& echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select
true | debconf-set-selections \
-&& add-apt-repository -y ppa:webupd8team/java \
-&& sh -c 'curl -s
https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
-o packages-microsoft-prod.deb' \
-&& sh -c 'dpkg -i packages-microsoft-prod.deb' \
-&& sh -c 'echo "deb https://download.mono-project.com/repo/ubuntu
stable-trusty main" | sudo tee
/etc/apt/sources.list.d/mono-official-stable.list' \
-&& apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys
3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF \
-&& apt-get update \
-&& apt-get install -y oracle-java8-installer gawk git maven openssh-server
subversion zip \
-&& apt-get install -y --force-yes dotnet-sdk-2.2 python python-dev
python3-dev python-pip build-essential mono-devel \
-&& pip install virtualenv virtualenvwrapper \
-&& pip install --upgrade pip \
-&& rm -rf /var/lib/apt/lists/* /var/cache/oracle-jdk8-installer
+RUN apt-get update
+RUN apt-get -y install software-properties-common python-software-properties
apt-transport-https curl dpkg
+RUN add-apt-repository ppa:openjdk-r/ppa
+RUN sh -c 'curl -s
https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
-o packages-microsoft-prod.deb'
+RUN sh -c 'dpkg -i packages-microsoft-prod.deb'
+RUN sh -c 'echo "deb https://download.mono-project.com/repo/ubuntu
stable-trusty main" | sudo tee
/etc/apt/sources.list.d/mono-official-stable.list'
+RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys
3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF
+RUN apt-get update
+RUN apt-get install -y openjdk-8-jdk gawk git maven openssh-server subversion
zip
+RUN apt-get install -y --force-yes dotnet-sdk-2.2 python python-dev
python3-dev python-pip build-essential mono-devel
+RUN pip install virtualenv virtualenvwrapper
+RUN pip install --upgrade pip
+RUN rm -rf /var/lib/apt/lists/* /var/cache/openjdk-8-jdk
RUN sed -i 's@PermitRootLogin without-password@PermitRootLogin yes@'
/etc/ssh/sshd_config
RUN sed -i 's@session\s*required\s*pam_loginuid.so@session optional
pam_loginuuid.so@g' /etc/pam.d/sshd
RUN ssh-keygen -t rsa -f ~/.ssh/id_rsa -N '' \
&& cat ~/.ssh/id_rsa.pub > ~/.ssh/authorized_keys
-ENV JAVA_HOME /usr/lib/jvm/java-8-oracle
+ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
RUN sed -i 's/.*"$PS1".*/# \0/' ~/.bashrc
RUN echo "export JAVA_HOME=${JAVA_HOME}" >> ~/.bashrc
[tinkerpop] branch travis-fix created (now 18f838c)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch travis-fix in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at 18f838c Switch travis build to openjdk This branch includes the following new commits: new 18f838c Switch travis build to openjdk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [tinkerpop] dkuppitz commented on issue #1100: TINKERPOP-2201: Change the typing of from() and to() to accept wildcard instead of Vertex
dkuppitz commented on issue #1100: TINKERPOP-2201: Change the typing of from() and to() to accept wildcard instead of Vertex URL: https://github.com/apache/tinkerpop/pull/1100#issuecomment-488049099 VOTE: +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp33 updated (98c40aa -> 3fdc254)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 98c40aa Limited logging for a host marked unavailable add 3fdc254 Hardened fold() glv test CTR No new revisions were added by this update. Summary of changes: gremlin-test/features/map/Fold.feature | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)
[tinkerpop] branch master updated: Hardened fold() glv test CTR
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 3fdc254 Hardened fold() glv test CTR new aeb393e Merge branch 'tp33' 3fdc254 is described below commit 3fdc2548e50412500f324b7f3b4b6bea2c93cd0e Author: Stephen Mallette AuthorDate: Tue Apr 30 09:10:48 2019 -0400 Hardened fold() glv test CTR --- gremlin-test/features/map/Fold.feature | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gremlin-test/features/map/Fold.feature b/gremlin-test/features/map/Fold.feature index c711e1d..c4c0f80 100644 --- a/gremlin-test/features/map/Fold.feature +++ b/gremlin-test/features/map/Fold.feature @@ -23,10 +23,15 @@ Feature: Step - fold() """ g.V().fold() """ -When iterated to list +When iterated next Then the result should be unordered | result | - | l[v[marko],v[vadas],v[lop],v[josh],v[ripple],v[peter]] | + | v[marko] | + | v[vadas] | + | v[lop] | + | v[josh] | + | v[ripple] | + | v[peter] | Scenario: g_V_fold_unfold Given the modern graph
[GitHub] [tinkerpop] spmallette commented on issue #1103: Create uber jar for gremlin-console
spmallette commented on issue #1103: Create uber jar for gremlin-console URL: https://github.com/apache/tinkerpop/pull/1103#issuecomment-487940512 I inspected the uberjar that is being generated. I have some concerns about the `META-INF/` in the jar itself with respect to licensing. I'm not sure what we need to include in there to be compliant with Apache licensing, but right now there's a bit of everything. I also think LICENSE files are copying over each other with the shading plugin. I assume that as this is a binary distribution artifact that the packaging should be similar to our zip distribution and follow that pattern, but I'll research a bit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp4 updated: lots of cleanup and reorg. Path now implements TSequence (smart, duplicate keys allowed). Thought through and tweaked all the methods of the core structure API/. TTuple
This is an automated email from the ASF dual-hosted git repository.
okram pushed a commit to branch tp4
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/tp4 by this push:
new bd79bcc lots of cleanup and reorg. Path now implements TSequence
(smart, duplicate keys allowed). Thought through and tweaked all the methods of
the core structure API/. TTuple and TSequence are making lots of sense --
basically, map and list respectively.
bd79bcc is described below
commit bd79bcc4c1d5db3f1bcf3e40e7f1d27892c928e4
Author: Marko A. Rodriguez
AuthorDate: Tue Apr 30 04:05:56 2019 -0600
lots of cleanup and reorg. Path now implements TSequence (smart, duplicate
keys allowed). Thought through and tweaked all the methods of the core
structure API/. TTuple and TSequence are making lots of sense -- basically, map
and list respectively.
---
.../language/gremlin/AbstractTraversal.java| 2 +-
.../tinkerpop/language/gremlin/Traversal.java | 4 +-
.../language/gremlin/TraversalSource.java | 6 +--
.../language/gremlin/core/CoreTraversal.java | 4 +-
.../tinkerpop/machine/bytecode/Bytecode.java | 11 +++--
.../tinkerpop/machine/bytecode/Instruction.java| 6 +--
.../machine/function/filter/HasKeyFilter.java | 8 +---
.../machine/function/flatmap/DbFlatMap.java| 17 ---
.../machine/function/flatmap/EntriesFlatMap.java | 19
.../machine/function/reduce/GroupCountReduce.java | 4 +-
.../strategy/decoration/ExplainStrategy.java | 1 +
.../structure/{util/J2Tuple.java => TPair.java}| 52 ++
.../apache/tinkerpop/machine/structure/TTuple.java | 13 +++---
.../tinkerpop/machine/structure/graph/TEdge.java | 6 ++-
.../tinkerpop/machine/structure/graph/TVertex.java | 16 +++
.../{JSequence.java => CompositeSequence.java} | 22 +
.../structure/util/{T2Tuple.java => JPair.java}| 27 +--
.../machine/structure/util/JSequence.java | 5 +++
.../tinkerpop/machine/structure/util/JTuple.java | 21 ++---
.../machine/traverser/path/BasicPath.java | 28 +++-
.../machine/traverser/path/EmptyPath.java | 10 ++---
.../tinkerpop/machine/traverser/path/Path.java | 21 ++---
.../tinkerpop/machine/bytecode/BytecodeTest.java | 4 +-
.../machine/bytecode/InstructionTest.java | 10 ++---
.../machine/bytecode/compiler/CompilationTest.java | 6 +--
.../blueprints/data/BlueprintsVertex.java | 18 +++-
.../provider/BlueprintsVerticesStrategy.java | 2 +-
.../machine/structure/jdbc/JDBCDatabase.java | 17 +++
.../tinkerpop/machine/structure/jdbc/JDBCRow.java | 27 +++
.../jdbc/bytecode/compiler/JDBCCompiler.java | 15 +++
.../jdbc/function/flatmap/SqlFlatMap.java | 5 +++
.../structure/jdbc/strategy/JDBCQueryStrategy.java | 2 +-
.../structure/jdbc/strategy/JDBCStrategy.java | 2 +-
33 files changed, 191 insertions(+), 220 deletions(-)
diff --git
a/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/AbstractTraversal.java
b/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/AbstractTraversal.java
index 51f7e08..793a469 100644
---
a/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/AbstractTraversal.java
+++
b/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/AbstractTraversal.java
@@ -54,7 +54,7 @@ public abstract class AbstractTraversal implements
Traversal {
protected final Traversal addInstruction(final String op,
final Object... args) {
if (this.executed)
throw new IllegalStateException("The traversal has already been
submitted and can no longer be mutated");
-this.bytecode.addInstruction(this.currentCoefficient, op, args);
+this.bytecode.addInstruction(this.currentCoefficient, null, op, args);
this.currentCoefficient.unity();
return (Traversal) this;
}
diff --git
a/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/Traversal.java
b/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/Traversal.java
index 5015a9e..b974502 100644
---
a/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/Traversal.java
+++
b/java/language/gremlin/src/main/java/org/apache/tinkerpop/language/gremlin/Traversal.java
@@ -21,7 +21,7 @@ package org.apache.tinkerpop.language.gremlin;
import org.apache.tinkerpop.machine.bytecode.compiler.Order;
import org.apache.tinkerpop.machine.structure.TTuple;
import org.apache.tinkerpop.machine.structure.rdbms.TDatabase;
-import org.apache.tinkerpop.machine.structure.util.T2Tuple;
+import org.apache.tinkerpop.machine.structure.TPair;
import org.apache.tinkerpop.machine.traverser.Traverser;
import org.apache.tinkerpop.machine.traverser.path.Path;
@@ -61,7 +61,7 @@
