Minor code change for the ever so nitpicky @okram.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/0ff40539 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/0ff40539 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/0ff40539 Branch: refs/heads/TINKERPOP-1753 Commit: 0ff40539ff3b15c9d059669bebb1975457d59e6a Parents: 96f1745 Author: Daniel Kuppitz <daniel_kupp...@hotmail.com> Authored: Fri Aug 18 13:48:45 2017 -0700 Committer: Daniel Kuppitz <daniel_kupp...@hotmail.com> Committed: Tue Aug 22 09:12:59 2017 -0700 ---------------------------------------------------------------------- .../tinkerpop/gremlin/process/traversal/Order.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/0ff40539/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Order.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Order.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Order.java index 3a3ae2b..7c3475a 100644 --- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Order.java +++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Order.java @@ -30,10 +30,9 @@ public enum Order implements Comparator<Object> { incr { @Override public int compare(final Object first, final Object second) { - if (first instanceof Number && second instanceof Number) { - return NumberHelper.compare((Number) first, (Number) second); - } - return Comparator.<Comparable>naturalOrder().compare((Comparable) first, (Comparable) second); + return first instanceof Number && second instanceof Number + ? NumberHelper.compare((Number) first, (Number) second) + : Comparator.<Comparable>naturalOrder().compare((Comparable) first, (Comparable) second); } @Override @@ -43,10 +42,9 @@ public enum Order implements Comparator<Object> { }, decr { @Override public int compare(final Object first, final Object second) { - if (first instanceof Number && second instanceof Number) { - return NumberHelper.compare((Number) second, (Number) first); - } - return Comparator.<Comparable>reverseOrder().compare((Comparable) first, (Comparable) second); + return first instanceof Number && second instanceof Number + ? NumberHelper.compare((Number) second, (Number) first) + : Comparator.<Comparable>reverseOrder().compare((Comparable) first, (Comparable) second); } @Override
