TINKERPOP-1892 Fix ignoring of test scenarios in Gremlin.Net CTR Without this fix, all following scenarios after one ignored scenario in the same feature weren't parsed at all. This also revealed another failing scenario that needed to be ignored for now.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/b25b9767 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/b25b9767 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/b25b9767 Branch: refs/heads/TRAVIS-TEST Commit: b25b9767547b2956f224cbe6fb55c756d5df612e Parents: d3be13b Author: Florian Hockmann <f...@florian-hockmann.de> Authored: Mon Mar 12 20:08:21 2018 +0100 Committer: Florian Hockmann <f...@florian-hockmann.de> Committed: Mon Mar 12 20:08:21 2018 +0100 ---------------------------------------------------------------------- .../Gherkin/GherkinTestRunner.cs | 6 +++++- .../Gherkin/IgnoreException.cs | 10 +++++----- 2 files changed, 10 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/b25b9767/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs ---------------------------------------------------------------------- diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs index 9d0f15d..d906357 100644 --- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs +++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs @@ -57,6 +57,10 @@ namespace Gremlin.Net.IntegrationTest.Gherkin { "g_V_asXaX_outEXcreatedX_asXbX_inV_asXcX_inXcreatedX_asXdX_whereXa_ltXbX_orXgtXcXX_andXneqXdXXX_byXageX_byXweightX_byXinXcreatedX_valuesXageX_minX_selectXa_c_dX", IgnoreReason.PNotCreatedCorrectlyByGherkinRunner + }, + { + "g_V_asXaX_out_asXbX_whereXandXasXaX_outXknowsX_asXbX__orXasXbX_outXcreatedX_hasXname_rippleX__asXbX_inXknowsX_count_isXnotXeqX0XXXXX_selectXa_bX", + IgnoreReason.PNotDeserializationProblem } }; @@ -107,7 +111,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin if (IgnoredScenarios.TryGetValue(scenario.Name, out var reason)) { failedSteps.Add(scenario.Steps.First(), new IgnoreException(reason)); - break; + continue; } StepBlock? currentStep = null; StepDefinition stepDefinition = null; http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/b25b9767/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs ---------------------------------------------------------------------- diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs index c8cb29a..dae2ced 100644 --- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs +++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs @@ -47,12 +47,12 @@ namespace Gremlin.Net.IntegrationTest.Gherkin reasonSuffix = " because the Gherkin runner can't call methods in TraversalPredicate class (TINKERPOP-1919)"; break; - case IgnoreReason.NumericalValuesHaveWrongTypes: - reasonSuffix = " because the asserts currently fail due to type mismatches (TINKERPOP-1918)"; - break; case IgnoreReason.PWithinWrapsArgumentsInArray: reasonSuffix = " because P.Within() arguments are incorrectly wrapped in an array (TINKERPOP-1920)"; break; + case IgnoreReason.PNotDeserializationProblem: + reasonSuffix = " because P.Not() cannot be deserialized by Gremlin Server (TINKERPOP-1922)"; + break; } return $"Scenario ignored" + reasonSuffix; } @@ -62,7 +62,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin { LambdaNotSupported, PNotCreatedCorrectlyByGherkinRunner, - NumericalValuesHaveWrongTypes, - PWithinWrapsArgumentsInArray + PWithinWrapsArgumentsInArray, + PNotDeserializationProblem } } \ No newline at end of file
