buildbot failure in on tomee-trunk-deploy
The Buildbot has detected a new failure on builder tomee-trunk-deploy while building . Full details are available at: https://ci.apache.org/builders/tomee-trunk-deploy/builds/617 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_1604_test_ubuntu Build Reason: The Nightly scheduler named 'tomee-trunk-deploy' triggered this build Build Source Stamp: [branch master] HEAD Blamelist: BUILD FAILED: failed Sincerely, -The Buildbot
[jira] [Created] (TOMEE-2028) add openejb.taglib.scan property to bypass openejb tld scanning
Romain Manni-Bucau created TOMEE-2028: - Summary: add openejb.taglib.scan property to bypass openejb tld scanning Key: TOMEE-2028 URL: https://issues.apache.org/jira/browse/TOMEE-2028 Project: TomEE Issue Type: Improvement Reporter: Romain Manni-Bucau Assignee: Romain Manni-Bucau Fix For: 7.0.4 tomcat scans tld and openejb layer rarely needs it but for rare cases it can slow down the boot, openejb.taglib.scan=false will bypass this logic. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (TOMEE-2028) add openejb.taglib.scan property to bypass openejb tld scanning
[ https://issues.apache.org/jira/browse/TOMEE-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved TOMEE-2028. --- Resolution: Fixed > add openejb.taglib.scan property to bypass openejb tld scanning > --- > > Key: TOMEE-2028 > URL: https://issues.apache.org/jira/browse/TOMEE-2028 > Project: TomEE > Issue Type: Improvement >Reporter: Romain Manni-Bucau >Assignee: Romain Manni-Bucau > Fix For: 7.0.4 > > > tomcat scans tld and openejb layer rarely needs it but for rare cases it can > slow down the boot, openejb.taglib.scan=false will bypass this logic. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
tomee git commit: TOMEE-2028 openejb.taglib.scan flag
Repository: tomee
Updated Branches:
refs/heads/master e416ea933 -> f0d07432d
TOMEE-2028 openejb.taglib.scan flag
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/f0d07432
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/f0d07432
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/f0d07432
Branch: refs/heads/master
Commit: f0d07432d3062450033d398fa46dc475fb214d51
Parents: e416ea9
Author: rmannibucau
Authored: Fri Mar 17 22:20:11 2017 +0100
Committer: rmannibucau
Committed: Fri Mar 17 22:20:11 2017 +0100
--
.../main/java/org/apache/openejb/config/TldScanner.java | 12
1 file changed, 12 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/tomee/blob/f0d07432/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
--
diff --git
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
index e8849f3..31652ad 100644
---
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
+++
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
@@ -18,6 +18,7 @@
package org.apache.openejb.config;
import org.apache.openejb.OpenEJBException;
+import org.apache.openejb.loader.SystemInstance;
import org.apache.openejb.util.DaemonThreadFactory;
import org.apache.openejb.util.URLs;
import org.apache.xbean.finder.UrlSet;
@@ -72,6 +73,10 @@ public class TldScanner {
private static final Map> cacheByhashCode = new
WeakHashMap>();
public static Set scan(final ClassLoader classLoader) throws
OpenEJBException {
+if (skip()) {
+return Collections.emptySet();
+}
+
if (classLoader == null) {
return Collections.emptySet();
}
@@ -87,7 +92,14 @@ public class TldScanner {
return result;
}
+private static boolean skip() {
+return
!"true".equalsIgnoreCase(SystemInstance.get().getProperty("openejb.taglib.scan",
"true"));
+}
+
public static Set scanClassLoaderForTagLibs(final ClassLoader
classLoader) throws OpenEJBException {
+if (skip()) {
+return Collections.emptySet();
+}
final Set tldUrls = new HashSet();
tomee git commit: TOMEE-1066 upgrade jstl - fixing scanning includes
Repository: tomee
Updated Branches:
refs/heads/master 06e48946c -> e416ea933
TOMEE-1066 upgrade jstl - fixing scanning includes
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/e416ea93
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/e416ea93
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/e416ea93
Branch: refs/heads/master
Commit: e416ea933450ea34a99bf829cde362480b56f59e
Parents: 06e4894
Author: rmannibucau
Authored: Fri Mar 17 22:15:10 2017 +0100
Committer: rmannibucau
Committed: Fri Mar 17 22:15:10 2017 +0100
--
.../src/main/java/org/apache/openejb/config/TldScanner.java| 2 +-
.../src/main/java/org/apache/tomee/jasper/TomEETldScanner.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tomee/blob/e416ea93/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
--
diff --git
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
index 0666810..e8849f3 100644
---
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
+++
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
@@ -324,7 +324,7 @@ public class TldScanner {
urlSet = URLs.cullSystemJars(urlSet);
urlSet = applyBuiltinExcludes(
urlSet,
-Filters.tokens("taglibs-standard-jstlel",
"javax.faces-2.", "spring-security-taglibs", "spring-webmvc"),
+Filters.tokens("taglibs-standard-impl",
"taglibs-standard-jstlel", "javax.faces-2.", "spring-security-taglibs",
"spring-webmvc"),
Filters.prefixes("commons-jcs-", "myfaces-",
"tomcat-websocket.jar")); // myfaces is hardcoded in tomee
} catch (final IOException e) {
DeploymentLoader.logger.warning("Error scanning class loader for
JSP tag libraries", e);
http://git-wip-us.apache.org/repos/asf/tomee/blob/e416ea93/tomee/tomee-catalina/src/main/java/org/apache/tomee/jasper/TomEETldScanner.java
--
diff --git
a/tomee/tomee-catalina/src/main/java/org/apache/tomee/jasper/TomEETldScanner.java
b/tomee/tomee-catalina/src/main/java/org/apache/tomee/jasper/TomEETldScanner.java
index 61a96a4..5d6773b 100644
---
a/tomee/tomee-catalina/src/main/java/org/apache/tomee/jasper/TomEETldScanner.java
+++
b/tomee/tomee-catalina/src/main/java/org/apache/tomee/jasper/TomEETldScanner.java
@@ -39,7 +39,7 @@ import static
org.apache.openejb.loader.JarLocation.jarLocation;
public class TomEETldScanner extends TldScanner {
private static final Paths PATHS = new Paths(null);
private static final URL MYFACES_URL = findJar("myfaces-impl",
"org.apache.myfaces.webapp.AbstractFacesInitializer");
-private static final URL JSTL_URL = findJar("taglibs-standard-jstlel",
"javax.servlet.jsp.jstl.core.ConditionalTagSupport");
+private static final URL JSTL_URL = findJar("taglibs-standard-impl",
"javax.servlet.jsp.jstl.core.ConditionalTagSupport");
private static final Map URI_TLD_RESOURCE = new
HashMap<>();
private static final Map TLD_RESOURCE_TAG_LIB
= new HashMap<>();
tomee git commit: no need of these deps
Repository: tomee
Updated Branches:
refs/heads/master 938168f59 -> 06e48946c
no need of these deps
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/06e48946
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/06e48946
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/06e48946
Branch: refs/heads/master
Commit: 06e48946cb5e76c893f1ca35f6b6f14b2dd172f4
Parents: 938168f
Author: rmannibucau
Authored: Fri Mar 17 22:08:22 2017 +0100
Committer: rmannibucau
Committed: Fri Mar 17 22:08:22 2017 +0100
--
.../moviefun/MoviesArquillianHtmlUnitTest.java| 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tomee/blob/06e48946/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
--
diff --git
a/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
b/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
index 32b31d5..06947ab 100644
---
a/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
+++
b/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
@@ -27,17 +27,13 @@ import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.asset.ClassLoaderAsset;
import org.jboss.shrinkwrap.api.importer.ExplodedImporter;
import org.jboss.shrinkwrap.api.spec.WebArchive;
-import org.jboss.shrinkwrap.resolver.api.maven.Maven;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import javax.ejb.EJB;
-import java.io.File;
import java.net.URL;
-import java.util.Arrays;
-import java.util.Collection;
import static org.junit.Assert.assertTrue;
@@ -48,17 +44,9 @@ public class MoviesArquillianHtmlUnitTest {
@Deployment
public static WebArchive createDeployment() {
-
-Collection dependencies = Arrays.asList("taglibs:standard",
"commons-lang:commons-lang");
-
-File[] libs = Maven.resolver()
-
.loadPomFromFile(Basedir.basedir("pom.xml")).resolve(dependencies)
-.withTransitivity().asFile();
-
WebArchive war = ShrinkWrap.create(WebArchive.class, "test.war")
.addClasses(Movie.class, MoviesBean.class,
MoviesArquillianHtmlUnitTest.class, ActionServlet.class)
-.addAsResource(new
ClassLoaderAsset("META-INF/persistence.xml"), "META-INF/persistence.xml")
-.addAsLibraries(libs);
+.addAsResource(new
ClassLoaderAsset("META-INF/persistence.xml"), "META-INF/persistence.xml");
war.merge(ShrinkWrap.create(GenericArchive.class).as(ExplodedImporter.class)
.importDirectory(Basedir.basedir(WEBAPP_SRC)).as(GenericArchive.class),
[jira] [Resolved] (TOMEE-1066) included version of JSTL contains extremely slow
[ https://issues.apache.org/jira/browse/TOMEE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved TOMEE-1066. --- Resolution: Fixed Assignee: Romain Manni-Bucau Fix Version/s: 7.0.4 > included version of JSTL contains extremely slow > > > Key: TOMEE-1066 > URL: https://issues.apache.org/jira/browse/TOMEE-1066 > Project: TomEE > Issue Type: Bug >Affects Versions: 1.5.1 >Reporter: Stephen More >Assignee: Romain Manni-Bucau > Fix For: 7.0.4 > > > The original bug can be found here: > https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 > using the current version of JSTL resulted in 2.2 requests/sec > changing to: > > org.apache.taglibs > taglibs-standard-spec > 1.2-SNAPSHOT > > > org.apache.taglibs > taglibs-standard-impl > 1.2-SNAPSHOT > > I was able to get 44 requests/sec -- This message was sent by Atlassian JIRA (v6.3.15#6346)
tomee git commit: TOMEE-1066 upgrade jstl
Repository: tomee
Updated Branches:
refs/heads/master 0b37309e9 -> 938168f59
TOMEE-1066 upgrade jstl
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/938168f5
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/938168f5
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/938168f5
Branch: refs/heads/master
Commit: 938168f59c5b929f14d923e47ed29a9d209444c5
Parents: 0b37309
Author: rmannibucau
Authored: Fri Mar 17 22:03:55 2017 +0100
Committer: rmannibucau
Committed: Fri Mar 17 22:03:55 2017 +0100
--
.../src/main/java/org/apache/openejb/config/TldScanner.java| 2 +-
container/openejb-core/src/main/resources/default.exclusions | 2 +-
.../org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java| 6 +-
tck/cdi-embedded/pom.xml | 6 +++---
.../src/main/java/org/apache/tomee/jasper/TomEETldScanner.java | 4 ++--
tomee/tomee-embedded/pom.xml | 6 +++---
tomee/tomee-webapp/pom.xml | 6 +++---
7 files changed, 14 insertions(+), 18 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tomee/blob/938168f5/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
--
diff --git
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
index 2d9a895..0666810 100644
---
a/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
+++
b/container/openejb-core/src/main/java/org/apache/openejb/config/TldScanner.java
@@ -324,7 +324,7 @@ public class TldScanner {
urlSet = URLs.cullSystemJars(urlSet);
urlSet = applyBuiltinExcludes(
urlSet,
-Filters.tokens("openejb-jstl-1.2", "javax.faces-2.",
"spring-security-taglibs", "spring-webmvc"),
+Filters.tokens("taglibs-standard-jstlel",
"javax.faces-2.", "spring-security-taglibs", "spring-webmvc"),
Filters.prefixes("commons-jcs-", "myfaces-",
"tomcat-websocket.jar")); // myfaces is hardcoded in tomee
} catch (final IOException e) {
DeploymentLoader.logger.warning("Error scanning class loader for
JSP tag libraries", e);
http://git-wip-us.apache.org/repos/asf/tomee/blob/938168f5/container/openejb-core/src/main/resources/default.exclusions
--
diff --git a/container/openejb-core/src/main/resources/default.exclusions
b/container/openejb-core/src/main/resources/default.exclusions
index 08090c0..311eb97 100644
--- a/container/openejb-core/src/main/resources/default.exclusions
+++ b/container/openejb-core/src/main/resources/default.exclusions
@@ -172,7 +172,6 @@ openejb-javaagent
openejb-jee
openejb-jpa-integration
openejb-jsf
-openejb-jstl
openejb-loader
openejb-openwebbeans
openejb-provisionning
@@ -223,6 +222,7 @@ sunec.jar
surefire-
swizzle-
sxc-
+taglibs-standard-
testng-
tomcat-annotations
tomcat-api
http://git-wip-us.apache.org/repos/asf/tomee/blob/938168f5/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
--
diff --git
a/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
b/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
index 6ae1dd0..32b31d5 100644
---
a/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
+++
b/examples/moviefun/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java
@@ -49,11 +49,7 @@ public class MoviesArquillianHtmlUnitTest {
@Deployment
public static WebArchive createDeployment() {
-Collection dependencies = Arrays.asList(new String[]{
-"javax.servlet:jstl",
-"taglibs:standard",
-"commons-lang:commons-lang"
-});
+Collection dependencies = Arrays.asList("taglibs:standard",
"commons-lang:commons-lang");
File[] libs = Maven.resolver()
.loadPomFromFile(Basedir.basedir("pom.xml")).resolve(dependencies)
http://git-wip-us.apache.org/repos/asf/tomee/blob/938168f5/tck/cdi-embedded/pom.xml
--
diff --git a/tck/cdi-embedded/pom.xml b/tck/cdi-embedded/pom.xml
index 00dc5b6..322c11d 100644
--- a/tck/cdi-embedded/pom.xml
+++ b/tck/cdi-embedded/pom.xml
@@ -64,9 +64,9 @@
test
- org.apache.openejb.patch
- openejb-jstl
- 1.2
+ org.apache.taglibs
+ taglibs-sta
buildbot success in on tomee-1.7.x-ubuntu
The Buildbot has detected a restored build on builder tomee-1.7.x-ubuntu while building . Full details are available at: https://ci.apache.org/builders/tomee-1.7.x-ubuntu/builds/174 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_qnode5_ubuntu Build Reason: forced: by IRC user on channel #openejb: None Build Source Stamp: HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
