This is an automated email from the ASF dual-hosted git repository.
mitchell852 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-trafficcontrol.git
The following commit(s) were added to refs/heads/master by this push:
new 1c6f3a5 Add information to errors when cdns/routing cannot contact TR.
1c6f3a5 is described below
commit 1c6f3a543ac14ab7cf7fc18b6635ae0a367c9027
Author: Chris Lemmons <alfic...@gmail.com>
AuthorDate: Thu Mar 29 11:56:08 2018 -0600
Add information to errors when cdns/routing cannot contact TR.
When a TR cannot be contacted, the cdns/routing endpoint returns a 500.
However, without information about why the 500 is being thrown, it can
be tricky to track down precisely what is going wrong. This adds the
name of the uncontactable host to the text of the error return as well
as adding a separate log entry, at ERROR level, to indicate the issue.
---
traffic_ops/app/lib/API/Cdn.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/traffic_ops/app/lib/API/Cdn.pm b/traffic_ops/app/lib/API/Cdn.pm
index 0326474..8b463a2 100644
--- a/traffic_ops/app/lib/API/Cdn.pm
+++ b/traffic_ops/app/lib/API/Cdn.pm
@@ -524,7 +524,8 @@ sub routing {
my $c = $self->get_traffic_router_connection( {
hostname => $ccr_host } );
my $s = $c->get_crs_stats();
if ( !defined($s) ) {
- return $self->internal_server_error( {
"Internal Server" => "Error" } );
+ $self->app->log->error("Unable to contact
$ccr_host for $cdn_name.");
+ return $self->internal_server_error( {
"Internal Server" => "Error: Unable to contact $ccr_host" } );
}
else {
--
To stop receiving notification emails like this one, please contact
mitchell...@apache.org.
