(trafficserver) branch master updated: Coverity 1497291: Use of 32-bit time_t (#10789)

[bcall]

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 187dcba2b3 Coverity 1497291: Use of 32-bit time_t (#10789)
187dcba2b3 is described below

commit 187dcba2b3ed24bf99361bf9133326c39c73a8a9
Author: Bryan Call <bc...@apache.org>
AuthorDate: Thu Nov 16 09:49:27 2023 -0800

    Coverity 1497291: Use of 32-bit time_t (#10789)
---
 include/proxy/hdrs/MIME.h |  4 ++--
 src/proxy/hdrs/MIME.cc    | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/proxy/hdrs/MIME.h b/include/proxy/hdrs/MIME.h
index 674905f60e..bf0e0ef80d 100644
--- a/include/proxy/hdrs/MIME.h
+++ b/include/proxy/hdrs/MIME.h
@@ -919,8 +919,8 @@ int mime_format_uint(char *buf, uint32_t val, size_t 
buf_len);
 int mime_format_int64(char *buf, int64_t val, size_t buf_len);
 int mime_format_uint64(char *buf, uint64_t val, size_t buf_len);
 
-void mime_days_since_epoch_to_mdy_slowcase(unsigned int days_since_jan_1_1970, 
int *m_return, int *d_return, int *y_return);
-void mime_days_since_epoch_to_mdy(unsigned int days_since_jan_1_1970, int 
*m_return, int *d_return, int *y_return);
+void mime_days_since_epoch_to_mdy_slowcase(time_t days_since_jan_1_1970, int 
*m_return, int *d_return, int *y_return);
+void mime_days_since_epoch_to_mdy(time_t days_since_jan_1_1970, int *m_return, 
int *d_return, int *y_return);
 int mime_format_date(char *buffer, time_t value);
 
 int32_t mime_parse_int(const char *buf, const char *end = nullptr);
diff --git a/src/proxy/hdrs/MIME.cc b/src/proxy/hdrs/MIME.cc
index 7778955d67..86101d314c 100644
--- a/src/proxy/hdrs/MIME.cc
+++ b/src/proxy/hdrs/MIME.cc
@@ -69,8 +69,8 @@ struct MDY {
 };
 
 static MDY *_days_to_mdy_fast_lookup_table = nullptr;
-static unsigned int _days_to_mdy_fast_lookup_table_first_day;
-static unsigned int _days_to_mdy_fast_lookup_table_last_day;
+static time_t _days_to_mdy_fast_lookup_table_first_day;
+static time_t _days_to_mdy_fast_lookup_table_last_day;
 
 /***********************************************************************
  *                                                                     *
@@ -985,11 +985,11 @@ mime_init_date_format_table()
   ////////////////////////////////////////////////////////////////
 
   time_t now_secs;
-  int i, now_days, first_days, last_days, num_days;
+  time_t i, now_days, first_days, last_days, num_days;
   int m = 0, d = 0, y = 0;
 
   time(&now_secs);
-  now_days   = static_cast<int>(now_secs / (60 * 60 * 24));
+  now_days   = static_cast<time_t>(now_secs / (60 * 60 * 24));
   first_days = now_days - 366;
   last_days  = now_days + 366;
   num_days   = last_days - first_days + 1;
@@ -2924,7 +2924,7 @@ mime_format_int64(char *buf, int64_t val, size_t buf_len)
 }
 
 void
-mime_days_since_epoch_to_mdy_slowcase(unsigned int days_since_jan_1_1970, int 
*m_return, int *d_return, int *y_return)
+mime_days_since_epoch_to_mdy_slowcase(time_t days_since_jan_1_1970, int 
*m_return, int *d_return, int *y_return)
 {
   static const int DAYS_OFFSET = 25508;
 
@@ -2944,7 +2944,7 @@ mime_days_since_epoch_to_mdy_slowcase(unsigned int 
days_since_jan_1_1970, int *m
 
   static const int days[12] = {305, 336, -1, 30, 60, 91, 121, 152, 183, 213, 
244, 274};
 
-  int mday, year, month, d, dp;
+  time_t mday, year, month, d, dp;
 
   mday = days_since_jan_1_1970;
 
@@ -2978,7 +2978,7 @@ mime_days_since_epoch_to_mdy_slowcase(unsigned int 
days_since_jan_1_1970, int *m
 }
 
 void
-mime_days_since_epoch_to_mdy(unsigned int days_since_jan_1_1970, int 
*m_return, int *d_return, int *y_return)
+mime_days_since_epoch_to_mdy(time_t days_since_jan_1_1970, int *m_return, int 
*d_return, int *y_return)
 {
   ink_assert(_days_to_mdy_fast_lookup_table != nullptr);
 
@@ -2994,7 +2994,7 @@ mime_days_since_epoch_to_mdy(unsigned int 
days_since_jan_1_1970, int *m_return,
     // of dates that are +/- one year from today.                 //
     ////////////////////////////////////////////////////////////////
 
-    int i     = days_since_jan_1_1970 - 
_days_to_mdy_fast_lookup_table_first_day;
+    time_t i  = days_since_jan_1_1970 - 
_days_to_mdy_fast_lookup_table_first_day;
     *m_return = _days_to_mdy_fast_lookup_table[i].m;
     *d_return = _days_to_mdy_fast_lookup_table[i].d;
     *y_return = _days_to_mdy_fast_lookup_table[i].y;