This is an automated email from the ASF dual-hosted git repository. masaori pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push: new 09dadf5 LGTM: Remove superfluous const qualifier in return type (#7412) 09dadf5 is described below commit 09dadf50a70681dcc2fd1b599d6ba2bb91e8c36f Author: Masaori Koshiba <masa...@apache.org> AuthorDate: Tue Jan 12 08:01:55 2021 +0900 LGTM: Remove superfluous const qualifier in return type (#7412) --- include/tscore/AtomicBit.h | 2 +- include/tscore/Extendible.h | 4 ++-- iocore/net/quic/QUICTypes.cc | 2 +- iocore/net/quic/QUICTypes.h | 2 +- plugins/experimental/ssl_session_reuse/src/connection.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/tscore/AtomicBit.h b/include/tscore/AtomicBit.h index 72581d3..5744d77 100644 --- a/include/tscore/AtomicBit.h +++ b/include/tscore/AtomicBit.h @@ -64,7 +64,7 @@ public: } // allow cast to bool - explicit operator const bool() const { return (*_byte_ptr) & _mask; } + explicit operator bool() const { return (*_byte_ptr) & _mask; } // allows compare with bool bool diff --git a/include/tscore/Extendible.h b/include/tscore/Extendible.h index 2ac826f..ea94a74 100644 --- a/include/tscore/Extendible.h +++ b/include/tscore/Extendible.h @@ -359,7 +359,7 @@ namespace details /// Bool specializations template <typename Derived_t> - const bool + bool fieldGet(const void *fld_ptr, FieldId<Derived_t, bool> const &field) { return bool((*static_cast<const uint8_t *>(fld_ptr)) & field.desc->mask); @@ -395,7 +395,7 @@ namespace details /// std::atomic<bool> specializations (same as bool) template <typename Derived_t> - inline const bool + inline bool fieldGet(void const *fld_ptr, FieldId<Derived_t, std::atomic<bool>> const &field) { return bool(fld_ptr & field.mask); diff --git a/iocore/net/quic/QUICTypes.cc b/iocore/net/quic/QUICTypes.cc index 305abc2..3b7d586 100644 --- a/iocore/net/quic/QUICTypes.cc +++ b/iocore/net/quic/QUICTypes.cc @@ -355,7 +355,7 @@ QUICResumptionToken::cid() const return QUICTypeUtil::read_QUICConnectionId(this->_token + (1 + 20 + 4), this->_token_len - (1 + 20 + 4)); } -const ink_hrtime +ink_hrtime QUICResumptionToken::expire_time() const { return QUICIntUtil::read_nbytes_as_uint(this->_token + (1 + 20), 4); diff --git a/iocore/net/quic/QUICTypes.h b/iocore/net/quic/QUICTypes.h index 021ccea..50e8752 100644 --- a/iocore/net/quic/QUICTypes.h +++ b/iocore/net/quic/QUICTypes.h @@ -373,7 +373,7 @@ public: bool is_valid(const IpEndpoint &src) const; const QUICConnectionId cid() const; - const ink_hrtime expire_time() const; + ink_hrtime expire_time() const; }; class QUICRetryToken : public QUICAddressValidationToken diff --git a/plugins/experimental/ssl_session_reuse/src/connection.h b/plugins/experimental/ssl_session_reuse/src/connection.h index eb99c50..597f496 100644 --- a/plugins/experimental/ssl_session_reuse/src/connection.h +++ b/plugins/experimental/ssl_session_reuse/src/connection.h @@ -55,7 +55,7 @@ public: * management. * @return */ - inline redisContext *const + inline redisContext * c_ptr() const { return c;