[tryton-commits] changeset in trytond:5.0 Use MagicMock for message when testing ...

[Cédric Krier]

changeset f0f198b463a0 in trytond:5.0
details: https://hg.tryton.org/trytond?cmd=changeset;node=f0f198b463a0
description:
        Use MagicMock for message when testing sendmail

        Since issue8596, sendmail test message contains Date header so message 
must
        implement the magic method.
        (grafted from 464864aedc0460dd6717d6197eb736bfa2433169)
diffstat:

 trytond/tests/test_sendmail.py |  13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diffs (51 lines):

diff -r f0835831dae6 -r f0f198b463a0 trytond/tests/test_sendmail.py
--- a/trytond/tests/test_sendmail.py    Fri Aug 30 09:08:32 2019 +0200
+++ b/trytond/tests/test_sendmail.py    Fri Aug 30 11:32:32 2019 +0200
@@ -3,7 +3,7 @@
 import smtplib
 import unittest
 from email.message import Message
-from unittest.mock import Mock, patch, call
+from unittest.mock import Mock, MagicMock, patch, call
 
 from trytond.sendmail import (
     sendmail_transactional, sendmail, SMTPDataManager, get_smtp_server)
@@ -21,7 +21,7 @@
     @with_transaction()
     def test_sendmail_transactional(self):
         'Test sendmail_transactional'
-        message = Mock()
+        message = MagicMock()
         datamanager = Mock()
         sendmail_transactional(
             'try...@example.com', 'f...@example.com', message,
@@ -32,7 +32,7 @@
 
     def test_sendmail(self):
         'Test sendmail'
-        message = Mock()
+        message = MagicMock()
         server = Mock()
         sendmail(
             'try...@example.com', 'f...@example.com', message, server=server)
@@ -89,8 +89,8 @@
         # multiple join must return the same
         self.assertEqual(transaction.join(SMTPDataManager()), datamanager)
 
-        msg1 = Mock(Message)
-        msg2 = Mock(Message)
+        msg1 = MagicMock(Message)
+        msg2 = MagicMock(Message)
         datamanager.put('f...@example.com', 'b...@example.com', msg1)
         datamanager.put('b...@example.com', 'f...@example.com', msg2)
 
@@ -105,7 +105,8 @@
 
         server.reset_mock()
 
-        datamanager.put('f...@example.com', 'b...@example.com', Mock(Message))
+        datamanager.put(
+            'f...@example.com', 'b...@example.com', MagicMock(Message))
         transaction.rollback()
 
         server.sendmail.assert_not_called()