junrushao1994 opened a new pull request #5740:
URL: https://github.com/apache/incubator-tvm/pull/5740
TODO: finish this draft.
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
srk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from de54754 Fix the values for test_fmod since it fails way too often
otherwise (#5723)
add 2ec7caa fix
srkreddy1238 merged pull request #5695:
URL: https://github.com/apache/incubator-tvm/pull/5695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrushao1994 commented on a change in pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#discussion_r436232785
##
File path: include/tvm/tir/op.h
##
@@ -762,6 +778,15 @@ inline PrimExpr make_zero(DataType t) {
}
return make_const(t, 0);
}
+
tqchen commented on a change in pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#discussion_r436231973
##
File path: include/tvm/tir/op.h
##
@@ -762,6 +778,15 @@ inline PrimExpr make_zero(DataType t) {
}
return make_const(t, 0);
}
+
+template
junrushao1994 commented on a change in pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#discussion_r436230123
##
File path: include/tvm/tir/op.h
##
@@ -762,6 +778,15 @@ inline PrimExpr make_zero(DataType t) {
}
return make_const(t, 0);
}
+
srkreddy1238 commented on issue #2518:
URL: https://github.com/apache/incubator-tvm/issues/2518#issuecomment-639921759
One option would be mapping them to Identity in frontend.
This is an automated message from the Apache
comaniac opened a new pull request #5739:
URL: https://github.com/apache/incubator-tvm/pull/5739
Sorry for the similar PR as #5732, as I found that some other places, such
as MXNet frontend, are also using `reshape` with new shape type `Tuple[IntImm,
IntImm, int]`. This PR fixes the
tqchen commented on pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#issuecomment-639891530
@junrushao1994 yes also also remove the legacy templates
This is an automated message from the Apache Git
alex96295 commented on issue #2518:
URL: https://github.com/apache/incubator-tvm/issues/2518#issuecomment-639853544
@yongwww @zhiics sorry how do you 'map ops to _undef'? I have the very same
issue
This is an automated
tqchen edited a comment on pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#issuecomment-639849385
cc @junrushao1994 @jroesch @ZihengJiang @yzhliu
This is an automated message from the Apache Git
anijain2305 commented on pull request #4805:
URL: https://github.com/apache/incubator-tvm/pull/4805#issuecomment-639835635
@inadob Can you please fix the CI error?
This is an automated message from the Apache Git Service.
To
tqchen merged pull request #5723:
URL: https://github.com/apache/incubator-tvm/pull/5723
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 592711e [TEST] Fix flaky
topi/tests/python/test_topi_pooling.py:test_adaptive_pool (#5736)
add de54754
tqchen commented on issue #5709:
URL: https://github.com/apache/incubator-tvm/issues/5709#issuecomment-639821849
Please open a new thread on https://discuss.tvm.ai/ to followup
This is an automated message from the Apache
aGiant commented on issue #5709:
URL: https://github.com/apache/incubator-tvm/issues/5709#issuecomment-639798666
@tqchen
it worked on Intel CPU Ubuntu 18.04 LTS
Now, we tried for arm cpu under armbian got error:
compiled with tvm.target.arm_cpu('pynq') in build_model.py
tqchen commented on pull request #5716:
URL: https://github.com/apache/incubator-tvm/pull/5716#issuecomment-639776043
@abergeron please
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly
kevinthesun commented on a change in pull request #5699:
URL: https://github.com/apache/incubator-tvm/pull/5699#discussion_r436123241
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -3194,6 +3191,55 @@ def _convert_operator(self, op_name, inputs, attrs,
abergeron edited a comment on pull request #5723:
URL: https://github.com/apache/incubator-tvm/pull/5723#issuecomment-639732620
I did something to fix the values so that the relative difference will never
be too big.
I also have some code to replace the fmod expression on Metal, but
abergeron commented on pull request #5723:
URL: https://github.com/apache/incubator-tvm/pull/5723#issuecomment-639732620
I've did something to fix the values so that the relative difference will
never be too big.
I also have some code to replace the fmod expression on Metal, but
tqchen merged pull request #5736:
URL: https://github.com/apache/incubator-tvm/pull/5736
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 24597f0 Fix reshape usage in ARM Winograd (#5732)
add 592711e [TEST] Fix flaky
abergeron commented on pull request #5723:
URL: https://github.com/apache/incubator-tvm/pull/5723#issuecomment-639716825
Well that is not the problem since it only makes a difference if x or y is
negative and we don't test that case.
abergeron commented on pull request #5723:
URL: https://github.com/apache/incubator-tvm/pull/5723#issuecomment-639695379
I dicovered that the problem is not that the values are too close it's that
fmod() on metal doesn't have the same behaviour.
`fmod(x, y)` expands to `x – y *
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from fee5d54 Change 'delete's in Relay VM Instruction dtor to 'delete[]'s
(#5735)
add 24597f0 Fix reshape
tqchen merged pull request #5732:
URL: https://github.com/apache/incubator-tvm/pull/5732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
junrushao1994 commented on pull request #5736:
URL: https://github.com/apache/incubator-tvm/pull/5736#issuecomment-639645065
@tqchen would be interesting to use pytest’s repeat to detect all potential
flaky tests
This is an
siju-samuel opened a new pull request #5737:
URL: https://github.com/apache/incubator-tvm/pull/5737
Conv3d_transpose implementation.
This is an automated message from the Apache Git Service.
To respond to the message,
zhiics closed issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
zhic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from e1b1171 ROCm: Add warp shuffles and enable reductions (#5727)
add fee5d54 Change 'delete's in Relay VM
tqchen commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639568074
@junrushao1994 we can also send a PR to add the comment about the consistency
This is an automated message
tqchen commented on pull request #5736:
URL: https://github.com/apache/incubator-tvm/pull/5736#issuecomment-639566907
cc @kevinthesun @yzhliu @ZihengJiang @tmoreau89
This is an automated message from the Apache Git Service.
junrushao1994 commented on pull request #5730:
URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639564805
I seelooks like this might affect downstream projects too because kDLInt
are not encouraged any more
tqchen edited a comment on pull request #5214:
URL: https://github.com/apache/incubator-tvm/pull/5214#issuecomment-639560910
https://github.com/apache/incubator-tvm/pull/5600 for improving softmax with
warp shuffle.
This is
tqchen edited a comment on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-639560545
cc @icemelon9 it might be useful to revisit the softmax strategy, given that
the perf has been improved
tqchen commented on pull request #5214:
URL: https://github.com/apache/incubator-tvm/pull/5214#issuecomment-639560910
https://github.com/apache/incubator-tvm/pull/5600
This is an automated message from the Apache Git
tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-639560545
cc @icemelon9 it might be useful to revisit the softmax strategy.
This is an automated message from the
tqchen commented on pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733#issuecomment-639559062
I think it is useful to have some struct available to other usecases.
However, as per layered design of TVM runtime, the current Tensor structure is
not really C ABI
inadob commented on pull request #4805:
URL: https://github.com/apache/incubator-tvm/pull/4805#issuecomment-639512065
> It seems you still have old `3rdparty/dmlc-core'. You can check that by
clicking on "Files changed" tab.
It's fixed now.
akosik-anyvision edited a comment on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639488053
> ah, I see. We should have used delete[]. You are welcome to send a PR.
Thanks.
Thanks for confirming. I would've done that directly, but I was waiting
akosik-anyvision commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639488053
> ah, I see. We should have used delete[]. You are welcome to send a PR.
Thanks.
Thanks for confirming. I would've done that directly, but I was waiting on
akosik-anyvision opened a new pull request #5735:
URL: https://github.com/apache/incubator-tvm/pull/5735
Fixes #5728.
The Instruction dtor in the Relay VM currently uses `delete` to free memory
that was allocated with `new[]`. This PR changes each occurrence of `delete` to
aarongreig opened a new issue #5734:
URL: https://github.com/apache/incubator-tvm/issues/5734
Hello
I tried to build TVM linking against LLVM 10.0 and I got the following error:
```
FAILED: CMakeFiles/tvm.dir/src/codegen/llvm/codegen_x86_64.cc.o
/usr/bin/c++
masahi commented on pull request #5727:
URL: https://github.com/apache/incubator-tvm/pull/5727#issuecomment-639376728
Thanks @t-vi @wpan11nv @tqchen
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from fbc2b87 [ONNX]MaxRoiPool, Mod & Xor op support added (#5729)
add e1b1171 ROCm: Add warp shuffles and
kevinthesun commented on a change in pull request #5699:
URL: https://github.com/apache/incubator-tvm/pull/5699#discussion_r435748804
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -3194,6 +3191,55 @@ def _convert_operator(self, op_name, inputs, attrs,
kevinthesun commented on a change in pull request #5699:
URL: https://github.com/apache/incubator-tvm/pull/5699#discussion_r435748804
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -3194,6 +3191,55 @@ def _convert_operator(self, op_name, inputs, attrs,
kevinthesun commented on a change in pull request #5699:
URL: https://github.com/apache/incubator-tvm/pull/5699#discussion_r435748804
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -3194,6 +3191,55 @@ def _convert_operator(self, op_name, inputs, attrs,
kevinthesun commented on a change in pull request #5699:
URL: https://github.com/apache/incubator-tvm/pull/5699#discussion_r435748804
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -3194,6 +3191,55 @@ def _convert_operator(self, op_name, inputs, attrs,
49 matches
Mail list logo
