windclarion commented on pull request #5988:
URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654601466
@junrushao1994 What I have said maybe not very clear, I mean I can't
catch a exception in python code, because C++ CHECK just abort, the abort
function didn't
xqdan commented on pull request #5772:
URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-654589703
> @xqdan sorry for the delayed reply. I take a closer look, and
unfortunately the new rules may not be correct.
>
> ```
> TVM_TRY_REWRITE_IF(
>
yidawang commented on pull request #5914:
URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-654578679
@tqchen Sorry to drop the ball as I was out the entire last week. The
current implementation looks good to me.
tqchen commented on pull request #5772:
URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-654576484
@xqdan sorry for the delayed reply. I take a closer look, and unfortunately
the new rules may not be correct.
```
TVM_TRY_REWRITE_IF(
truncdiv(x +
tqchen commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450436581
##
File path: src/ansor/loop_state.h
##
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
tqchen commented on pull request #5914:
URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-654560411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrushao1994 commented on pull request #5988:
URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654556337
@windclarion use pytest.raises:
https://stackoverflow.com/questions/23337471/how-to-properly-assert-that-an-exception-gets-raised-in-pytest
jwfromm commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450368131
##
File path: python/tvm/ansor/auto_schedule.py
##
@@ -0,0 +1,206 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
windclarion commented on pull request #5988:
URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654541003
@ZihengJiang I try to add test, but if I feed the option with a string which
contains two '=', target_id.cc FindUniqueSubstr CHECK will abort, so I
don't know how
windclarion commented on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-654535464
The failed test is unexpected, I guess it's not caused by this modification,
but I don't understand the build fail message
jiangzoi commented on a change in pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#discussion_r450549419
##
File path: include/tvm/runtime/object.h
##
@@ -1,877 +0,0 @@
-/*
Review comment:
It is deleted by mistake. I will update the PR soon.
ymwangg commented on a change in pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#discussion_r450545848
##
File path: include/tvm/runtime/object.h
##
@@ -1,877 +0,0 @@
-/*
Review comment:
Why this file is deleted?
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-654525930
@ANSHUMAN87 here is some initial details
https://discuss.tvm.ai/t/rfc-meta-rfc-3-pronged-plan-for-improving-error-messages-in-tvm/7214
weberlo commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450533559
##
File path: python/tvm/ansor/utils.py
##
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-654518640
@ANSHUMAN87 I have been super busy and will post one soon.
This is an automated message from the Apache
austinmw commented on issue #4839:
URL: https://github.com/apache/incubator-tvm/issues/4839#issuecomment-654518611
Hey, looks like the docker hub images are using CUDA 8.0, is there any plan
to upgrade?
This is an automated
mbrookhart commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450528796
##
File path: src/ansor/compute_dag.h
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450524033
##
File path: src/relay/op/dyn/tensor/transform.cc
##
@@ -128,6 +130,71 @@ RELAY_REGISTER_OP("dyn.reshape")
.set_attr("FTVMCompute",
jiangzoi opened a new pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999
@zhiics
Hi Zhi,
Please review my pull request when you have time. It is related to typo fix
in code comments and tutorial.
Thank you so much!
Zheng
alexwong commented on a change in pull request #5052:
URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r450511432
##
File path: python/tvm/contrib/target/onnx.py
##
@@ -0,0 +1,899 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
alexwong commented on a change in pull request #5052:
URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r450511432
##
File path: python/tvm/contrib/target/onnx.py
##
@@ -0,0 +1,899 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
yongwww commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450505449
##
File path: src/relay/op/dyn/tensor/transform.cc
##
@@ -128,6 +130,71 @@ RELAY_REGISTER_OP("dyn.reshape")
.set_attr("FTVMCompute",
austinmw opened a new issue #5998:
URL: https://github.com/apache/incubator-tvm/issues/5998
I've pulled the docker image `tvmai/demo-gpu` and am trying the tutorial
[Compile ONNX
Models](https://tvm.apache.org/docs/tutorials/frontend/from_onnx.html?highlight=onnx)
using the python3
zhiics commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450485913
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450483728
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
electriclilies commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450435940
##
File path: python/tvm/ansor/measure.py
##
@@ -0,0 +1,386 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
electriclilies commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450434208
##
File path: python/tvm/ansor/compute_dag.py
##
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
junrushao1994 commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450413013
##
File path: python/tvm/ansor/loop_state.py
##
@@ -0,0 +1,223 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
junrushao1994 commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450399570
##
File path: python/tvm/ansor/workload_registry.py
##
@@ -0,0 +1,170 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450403571
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450403162
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450402665
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
zhiics commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450395718
##
File path: python/tvm/relay/op/dyn/_transform.py
##
@@ -81,3 +84,23 @@ def _reshape_shape_func_input_data(data, newshape, ndim):
samskalicky commented on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-654382750
Thanks for the quick reply @tqchen!
Agreed, the proposed fix is adhoc. I wanted to show a working solution to
the problem as a starting point.
I can try
comaniac commented on a change in pull request #5997:
URL: https://github.com/apache/incubator-tvm/pull/5997#discussion_r450365939
##
File path: python/tvm/relay/analysis/analysis.py
##
@@ -351,3 +353,42 @@ def search_fc_transpose(expr):
"""
ret =
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450374695
##
File path: src/relay/transforms/dynamic_to_static.cc
##
@@ -46,6 +47,14 @@ class DynamicToStaticMutator : public MixedModeMutator {
zhiics commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450371610
##
File path: src/relay/transforms/dynamic_to_static.cc
##
@@ -46,6 +47,14 @@ class DynamicToStaticMutator : public MixedModeMutator {
MarisaKirisame commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450361838
##
File path: python/tvm/ansor/measure.py
##
@@ -0,0 +1,470 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
tqchen merged pull request #5618:
URL: https://github.com/apache/incubator-tvm/pull/5618
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
MarisaKirisame commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449903239
##
File path: python/tvm/ansor/auto_schedule.py
##
@@ -0,0 +1,206 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
MarisaKirisame commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-tvm/pull/5991#discussion_r449781641
##
File path: include/tvm/ir/op.h
##
@@ -146,6 +146,7 @@ class OpNode : public RelayExprNode {
// Internal function to compute if it is
zhiics commented on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-654353126
Yeah, this is needed temporarily. I will change the way we initialize graph
runtime so that no extra params should be fed
tqchen commented on pull request #5958:
URL: https://github.com/apache/incubator-tvm/pull/5958#issuecomment-654350423
I think the separation makes sense if we agreed on the categorization. The
common one should go to the memory dialect and the vm specific ones should goes
into vm.
mbrookhart commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450353012
##
File path: src/relay/transforms/dynamic_to_static.cc
##
@@ -46,6 +47,14 @@ class DynamicToStaticMutator : public MixedModeMutator {
tqchen edited a comment on pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#issuecomment-654347387
Thanks @FrozenGene I made some initial comments. Would like to followup on
the general design directions. The PR as it is implements the features we want.
tqchen edited a comment on pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#issuecomment-654347387
Thanks @FrozenGene I made some initial comments. Would like to followup on
the general design directions. The PR as it is implements the features we want.
tqchen commented on pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#issuecomment-654347387
Thanks @FrozenGene I made some initial comments. Would like to followup on
the general design directions. The PR as it is implements the features we want.
However, it is
zhiics commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-tvm/pull/5983#discussion_r450343053
##
File path: src/relay/transforms/dynamic_to_static.cc
##
@@ -46,6 +47,14 @@ class DynamicToStaticMutator : public MixedModeMutator {
zhiics commented on a change in pull request #5989:
URL: https://github.com/apache/incubator-tvm/pull/5989#discussion_r449651385
##
File path: src/runtime/contrib/coreml/coreml_runtime.mm
##
@@ -199,29 +183,25 @@
}
}
-Module CoreMLRuntimeCreate(const std::string&
tqchen commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450315280
##
File path: python/tvm/contrib/graph_runtime.py
##
@@ -63,6 +63,15 @@ def create(graph_json_str, libmod, ctx):
return
tqchen commented on issue #5996:
URL: https://github.com/apache/incubator-tvm/issues/5996#issuecomment-654302669
Thanks for asking the question. Please open a new discussion thread on
https://discuss.tvm.ai/
This is an
tqchen closed issue #5996:
URL: https://github.com/apache/incubator-tvm/issues/5996
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tqchen commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-tvm/pull/5991#discussion_r450295937
##
File path: include/tvm/ir/op.h
##
@@ -146,6 +146,7 @@ class OpNode : public RelayExprNode {
// Internal function to compute if it is primitive
ANSHUMAN87 commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450274829
##
File path: python/tvm/runtime/graph_runtime_factory.py
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
inadob closed pull request #4704:
URL: https://github.com/apache/incubator-tvm/pull/4704
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450061590
##
File path: python/tvm/runtime/graph_runtime_factory.py
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450061059
##
File path: src/runtime/graph/graph_runtime_factory.h
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450054124
##
File path: src/runtime/graph/graph_runtime_factory.cc
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450054461
##
File path: src/runtime/graph/graph_runtime_factory.cc
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450053253
##
File path: src/runtime/graph/graph_runtime_factory.cc
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450052731
##
File path: src/runtime/graph/graph_runtime.h
##
@@ -94,6 +98,7 @@ class TVM_DLL GraphRuntime : public ModuleNode {
* processor.
*
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450052552
##
File path: src/runtime/graph/graph_runtime.h
##
@@ -64,7 +68,7 @@ struct TVMOpParam {
* This runtime can be acccesibly in various language
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450051881
##
File path: python/tvm/runtime/module.py
##
@@ -282,7 +292,19 @@ def export_library(self,
self.save(file_name)
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450051691
##
File path: python/tvm/runtime/module.py
##
@@ -282,7 +292,19 @@ def export_library(self,
self.save(file_name)
FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r450051536
##
File path: python/tvm/runtime/module.py
##
@@ -222,29 +223,31 @@ def evaluator(*args):
except NameError:
raise
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449990904
##
File path: python/tvm/ansor/compute_dag.py
##
@@ -0,0 +1,153 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449990904
##
File path: python/tvm/ansor/compute_dag.py
##
@@ -0,0 +1,153 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449990904
##
File path: python/tvm/ansor/compute_dag.py
##
@@ -0,0 +1,153 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449742982
##
File path: src/ansor/utils.cc
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450003640
##
File path: src/ansor/transform_step.h
##
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
junrushao1994 commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450001473
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
junrushao1994 commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450001473
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
junrushao1994 commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r450001473
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r449964790
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r45927
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r44961
##
File path: src/ansor/compute_dag.cc
##
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r44028
##
File path: python/tvm/ansor/utils.py
##
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r44028
##
File path: python/tvm/ansor/utils.py
##
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
merrymercy commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r44028
##
File path: python/tvm/ansor/utils.py
##
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
79 matches
Mail list logo
