[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8228: [EZ] [Typo] Add a missing override

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #8228: URL: https://github.com/apache/tvm/pull/8228#issuecomment-858295549 I'm not entirely sure Matthew. What's the best way for me to check to answer your question? -- This is an automated message from the Apache Git Service. To respond to the

[tvm] branch main updated (d97d8d3 -> b93e56e)

2021-06-09 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d97d8d3 fake quantization to integer (#8228) add b93e56e [CuBLAS] Support implicit broadcast in batch_matmul

[GitHub] [tvm] masahi commented on pull request #8229: [CuBLAS] Support implicit broadcast in batch_matmul

2021-06-09 Thread GitBox
masahi commented on pull request #8229: URL: https://github.com/apache/tvm/pull/8229#issuecomment-858291499 Thanks @comaniac, we should do this for rocblas too @csullivan @altanh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] masahi closed issue #7730: [Bug] Missing broadcast_to before batch_matmul for CuBLAS

2021-06-09 Thread GitBox
masahi closed issue #7730: URL: https://github.com/apache/tvm/issues/7730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[tvm] branch main updated (a468f08 -> d97d8d3)

2021-06-09 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from a468f08 Add metadata information to the listing of PassContext configuration listing function (#8226) add d97d8d3

[GitHub] [tvm] masahi merged pull request #8229: [CuBLAS] Support implicit broadcast in batch_matmul

2021-06-09 Thread GitBox
masahi merged pull request #8229: URL: https://github.com/apache/tvm/pull/8229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] masahi merged pull request #8228: [EZ] [Typo] Add a missing override

2021-06-09 Thread GitBox
masahi merged pull request #8228: URL: https://github.com/apache/tvm/pull/8228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] jcf94 commented on pull request #8226: Add metadata information to the PassContext configuration listing function

2021-06-09 Thread GitBox
jcf94 commented on pull request #8226: URL: https://github.com/apache/tvm/pull/8226#issuecomment-858246889 Thanks! @leandron @comaniac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: Add metadata information to the listing of PassContext configuration listing function (#8226)

2021-06-09 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new a468f08 Add metadata information to the listing of

[GitHub] [tvm] jcf94 merged pull request #8226: Add metadata information to the PassContext configuration listing function

2021-06-09 Thread GitBox
jcf94 merged pull request #8226: URL: https://github.com/apache/tvm/pull/8226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[tvm] branch main updated (34e9a4f -> d767659)

2021-06-09 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 34e9a4f [Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor (#8179) add d767659 Fix use of wrong

[GitHub] [tvm] jcf94 merged pull request #8227: Fix use of wrong variable

2021-06-09 Thread GitBox
jcf94 merged pull request #8227: URL: https://github.com/apache/tvm/pull/8227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] dvhg opened a new issue #8233: [Bug] PyTorch MaskRCNN GPU OOM error

2021-06-09 Thread GitBox
dvhg opened a new issue #8233: URL: https://github.com/apache/tvm/issues/8233 I'm trying to run PyTorch MaskRCNN on GPU and have been running into GPU memory issues. I get errors when running repeated inferences using different inputs. There's some variety in the error messages but this

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648799216 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +95,13 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648798469 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: Yes, if you think

[GitHub] [tvm] YongtaoHuang1994 opened a new issue #8232: NVIDIA GPU inference on TVM Docker

2021-06-09 Thread GitBox
YongtaoHuang1994 opened a new issue #8232: URL: https://github.com/apache/tvm/issues/8232 **OS**: ubuntu 18.04 **NVIDIA GPU**: GM107GL [Quadro K620] First, the inference code can run in the on the physical machine (no docker env) ``` (tvm-build)

[GitHub] [tvm] fantasyRqg commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
fantasyRqg commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648789399 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: Should I modify

[GitHub] [tvm] tiandiao123 commented on issue #8057: deformable_conv2 error when converting torch traced model to relay

2021-06-09 Thread GitBox
tiandiao123 commented on issue #8057: URL: https://github.com/apache/tvm/issues/8057#issuecomment-858216535 > It is possible that relay and PT have different deform conv 2d results. I had put up a PR #7397 which fixed this for PT 1.6 . It's possible they changed something for later

[GitHub] [tvm] fantasyRqg commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
fantasyRqg commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648791852 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +95,13 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] fantasyRqg commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
fantasyRqg commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648789399 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: Should modify

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648788698 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +95,13 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648786905 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: your pr should not

[GitHub] [tvm] FrozenGene commented on pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on pull request #8223: URL: https://github.com/apache/tvm/pull/8223#issuecomment-858210821 please fix the format problem using clang-format-10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] FrozenGene commented on pull request #8179: [Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor

2021-06-09 Thread GitBox
FrozenGene commented on pull request #8179: URL: https://github.com/apache/tvm/pull/8179#issuecomment-858210014 Thanks @rohanmukh @trevor-m TF2 is one important frontend for TVM users. Great work and let us go on! -- This is an automated message from the Apache Git Service. To respond

[tvm] branch main updated (4d9bc9b -> 34e9a4f)

2021-06-09 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 4d9bc9b [RUNTIME] ShapeTuple Container (#8200) add 34e9a4f [Frontend, Tensorflow, Tensorflow2] Tensorflow frontend

[GitHub] [tvm] FrozenGene merged pull request #8179: [Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor

2021-06-09 Thread GitBox
FrozenGene merged pull request #8179: URL: https://github.com/apache/tvm/pull/8179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address

2021-06-09 Thread GitBox
lmxyy commented on pull request #8203: URL: https://github.com/apache/tvm/pull/8203#issuecomment-858208528 @tqchen @areusch @merrymercy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] merrymercy opened a new pull request #8231: [COMMUNITY] Egor Churaev -> reviewer

2021-06-09 Thread GitBox
merrymercy opened a new pull request #8231: URL: https://github.com/apache/tvm/pull/8231 Please join us to welcome @echuraev as a new reviewer He has contributed to the metal backend, auto-scheduler, and ONNX frontend. He also actively participates in the discussion forum. -

[GitHub] [tvm] gromero opened a new pull request #8230: [µTVM] Zephyr: Fix missing board-specific config file in build dir

2021-06-09 Thread GitBox
gromero opened a new pull request #8230: URL: https://github.com/apache/tvm/pull/8230 Hi, Could the following small change be reviewed please? It's necessary to make the build of the libraries (`common`, `utvm_rpc_common`, `utvm_rpc_server`, etc) be aware of board-specific

[GitHub] [tvm] ZihengJiang commented on pull request #8200: [RUNTIME] ShapeTuple Container

2021-06-09 Thread GitBox
ZihengJiang commented on pull request #8200: URL: https://github.com/apache/tvm/pull/8200#issuecomment-858156751 Merged. Thanks @tqchen @junrushao1994 @tkonolige for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[tvm] branch main updated: [RUNTIME] ShapeTuple Container (#8200)

2021-06-09 Thread ziheng
This is an automated email from the ASF dual-hosted git repository. ziheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 4d9bc9b [RUNTIME] ShapeTuple Container (#8200)

[GitHub] [tvm] ZihengJiang merged pull request #8200: [RUNTIME] ShapeTuple Container

2021-06-09 Thread GitBox
ZihengJiang merged pull request #8200: URL: https://github.com/apache/tvm/pull/8200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tvm] ZihengJiang commented on a change in pull request #8200: [RUNTIME] ShapeTuple Container

2021-06-09 Thread GitBox
ZihengJiang commented on a change in pull request #8200: URL: https://github.com/apache/tvm/pull/8200#discussion_r648739431 ## File path: include/tvm/runtime/container/shape_tuple.h ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [tvm] Lunderberg commented on pull request #8010: [UnitTests] Automatic parametrization over targets, with explicit opt-out

2021-06-09 Thread GitBox
Lunderberg commented on pull request #8010: URL: https://github.com/apache/tvm/pull/8010#issuecomment-858150839 Added one more bugfix. First implementation of removing fixture functions from module scope was a bit overzealous, also removed any objects that implement `__getattr__`, such

[GitHub] [tvm] mbrookhart commented on pull request #8228: [EZ] [Typo] Add a missing override

2021-06-09 Thread GitBox
mbrookhart commented on pull request #8228: URL: https://github.com/apache/tvm/pull/8228#issuecomment-858149355 But which clang? We run both gcc and clang in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] comaniac opened a new pull request #8229: [CuBLAS] Support implicit broadcast in batch_matmul

2021-06-09 Thread GitBox
comaniac opened a new pull request #8229: URL: https://github.com/apache/tvm/pull/8229 Closing #7730 This PR improves CuBLAS batch_matmul to support implicit broadcasting (i.e., the first dimension of matrix B is 1). Before this PR, the added test cases will throw errors like

[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.

2021-06-09 Thread GitBox
Lunderberg commented on pull request #8029: URL: https://github.com/apache/tvm/pull/8029#issuecomment-858127739 Next round of updates, tested locally against the newer version of sphinx used by CI, and rebased against main. Should have all build warnings fixed up through commit

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8228: [EZ] [Typo] Add a missing override

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #8228: URL: https://github.com/apache/tvm/pull/8228#issuecomment-858122312 I'm on mac so it must be `clang` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #8228: [EZ] [Typo] Add a missing override

2021-06-09 Thread GitBox
AndrewZhaoLuo opened a new pull request #8228: URL: https://github.com/apache/tvm/pull/8228 Without this, the compiler generates a warning. cc @mbrookhart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo edited a comment on pull request #8069: URL: https://github.com/apache/tvm/pull/8069#issuecomment-858045479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] tkonolige commented on a change in pull request #8200: [RUNTIME] ShapeTuple Container

2021-06-09 Thread GitBox
tkonolige commented on a change in pull request #8200: URL: https://github.com/apache/tvm/pull/8200#discussion_r648688459 ## File path: include/tvm/runtime/container/shape_tuple.h ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo edited a comment on pull request #8069: URL: https://github.com/apache/tvm/pull/8069#issuecomment-858045479 Hey folks, covered the simple changes requested, here is the list of more involved changes along with the associated reviewer. Several of these changes were planned to

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648649618 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648649618 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648649618 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648649618 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #8069: URL: https://github.com/apache/tvm/pull/8069#issuecomment-858045479 Hey folks, covered the simple changes requested, here is the list of more involved changes along with the associated reviewer. Several of these changes were planned to be

[GitHub] [tvm] comaniac commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648620237 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] SerkanMuhcu opened a new pull request #8227: Fix use of wrong variable

2021-06-09 Thread GitBox
SerkanMuhcu opened a new pull request #8227: URL: https://github.com/apache/tvm/pull/8227 The function argument is named `kernel` and these lines used `filter` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] comaniac commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648618186 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648609224 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648617582 ## File path: tests/python/relay/test_fp32_to_fp16_transform.py ## @@ -0,0 +1,328 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [tvm] leandron opened a new pull request #8226: Add metadata information to the listing of PassContext configuration listing function

2021-06-09 Thread GitBox
leandron opened a new pull request #8226: URL: https://github.com/apache/tvm/pull/8226 Add metadata information to the listing of PassContext configuration listing function. * Rename PassContext::ListConfigNames() to PassContext::ListConfigs() and its Python counterpart

[GitHub] [tvm] kparzysz-quic commented on pull request #8213: [LLVM] Fix CodeGenLLVM::LinkParameters

2021-06-09 Thread GitBox
kparzysz-quic commented on pull request #8213: URL: https://github.com/apache/tvm/pull/8213#issuecomment-858034729 I've been using the entire clang toolchain built with assertions (the Release+Assertions build) in my daily work and I don't find it too slow. Frankly, I'm not sure if I

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648611836 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648609224 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] SerkanMuhcu opened a new pull request #8225: Implement bitserial_conv1d operator

2021-06-09 Thread GitBox
SerkanMuhcu opened a new pull request #8225: URL: https://github.com/apache/tvm/pull/8225 This is mostly a copy of the implementation of `bitserial_conv2d` with the height dimension removed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tvm] comaniac commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648604259 ## File path: src/relay/transforms/fp32_to_fp16.h ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648601951 ## File path: src/relay/transforms/fp32_to_fp16.h ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] comaniac commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs

2021-06-09 Thread GitBox
comaniac commented on pull request #8212: URL: https://github.com/apache/tvm/pull/8212#issuecomment-858015437 Thanks @leandron @mbaret @zhiics @zackcquic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[tvm] branch main updated (53e4c60 -> 1f2ca06)

2021-06-09 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 53e4c60 [DOC] Improve "Getting Started with TVM" tutorials and fix warnings (#8221) add 1f2ca06 Expose list of

[GitHub] [tvm] comaniac merged pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs

2021-06-09 Thread GitBox
comaniac merged pull request #8212: URL: https://github.com/apache/tvm/pull/8212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] leandron commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs

2021-06-09 Thread GitBox
leandron commented on pull request #8212: URL: https://github.com/apache/tvm/pull/8212#issuecomment-858012625 > Hi @leandron: > > LGTM. > > May I know what kind of features (next PR as you mentioned before) depend on this change? Hi @zackcquic yes, sure. I'm working on

[GitHub] [tvm] comaniac commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648599365 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr pass.

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648598356 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648596936 ## File path: python/tvm/relay/transform/transform.py ## @@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger(): The registered SimplifyExpr

[GitHub] [tvm-rfcs] comaniac commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
comaniac commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857950295 > > Thanks for the answers. I'll review the PR to get more implementation details. > > One more question regarding the extensibility: can this be extended easily to support

[GitHub] [tvm] comaniac commented on a change in pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r648541663 ## File path: src/relay/transforms/fp32_to_fp16.cc ## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm-rfcs] tmoreau89 commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
tmoreau89 commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857933603 CCing @csullivan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm-rfcs] AndrewZhaoLuo commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857931228 I don't know Chris Sullivan's github handle so if someone could cc him too that would be great. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm-rfcs] AndrewZhaoLuo commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857922283 > Thanks for the answers. I'll review the PR to get more implementation details. > One more question regarding the extensibility: can this be extended easily to support

[GitHub] [tvm] csullivan commented on pull request #8069: [Relay] [Pass] Add FP16 model conversion pass

2021-06-09 Thread GitBox
csullivan commented on pull request #8069: URL: https://github.com/apache/tvm/pull/8069#issuecomment-857915269 Thanks for this great PR! Would it be too much to ask for AMPRewrite and corresponding infra to support mixed precision with generic reduced precision floating point types? I

[GitHub] [tvm-rfcs] comaniac commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
comaniac commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857914672 Thanks for the answers. I'll review the PR to get more implementation details. One more question regarding the extensibility: can this be extended easily to support bfloat16?

[GitHub] [tvm] junrushao1994 commented on a change in pull request #8215: [TVMSCRIPT] Fix printing of rank 0 buffer access

2021-06-09 Thread GitBox
junrushao1994 commented on a change in pull request #8215: URL: https://github.com/apache/tvm/pull/8215#discussion_r648535578 ## File path: python/tvm/script/intrin.py ## @@ -180,6 +185,11 @@ def opaque_axis(begin, end, span): return get_axis(begin, end, "opaque", span)

[GitHub] [tvm-rfcs] AndrewZhaoLuo edited a comment on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
AndrewZhaoLuo edited a comment on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857903539 > Thanks for the RFC. I have two questions: > > 1. How to mark/set the color (i.e., attribute) of every operator? > 2. It seems to me that if we register a

[GitHub] [tvm-rfcs] AndrewZhaoLuo edited a comment on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
AndrewZhaoLuo edited a comment on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857903539 > Thanks for the RFC. I have two questions: > > 1. How to mark/set the color (i.e., attribute) of every operator? > 2. It seems to me that if we register a

[GitHub] [tvm-rfcs] AndrewZhaoLuo commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
AndrewZhaoLuo commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857903539 > Thanks for the RFC. I have two questions: > > 1. How to mark/set the color (i.e., attribute) of every operator? > 2. It seems to me that if we register a casting

[GitHub] [tvm-rfcs] tqchen commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
tqchen commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648528792 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) Review comment: Please add asf

[GitHub] [tvm-rfcs] comaniac commented on pull request #6: Automatic Mixed Precision Pass RFC

2021-06-09 Thread GitBox
comaniac commented on pull request #6: URL: https://github.com/apache/tvm-rfcs/pull/6#issuecomment-857889774 Thanks for the RFC. I have two questions: 1. How to mark/set the color (i.e., attribute) of every operator? 2. It seems to me that if we register a casting checker instead of

[GitHub] [tvm] tkonolige commented on a change in pull request #8220: [DOCS] Add docs for Pass Instrument

2021-06-09 Thread GitBox
tkonolige commented on a change in pull request #8220: URL: https://github.com/apache/tvm/pull/8220#discussion_r648494489 ## File path: docs/dev/pass_infra.rst ## @@ -109,7 +109,8 @@ configure the compilation options, including optimization level and required/disabled

[GitHub] [tvm-rfcs] tqchen commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
tqchen commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648515238 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm-rfcs] tqchen commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
tqchen commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648514264 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm-rfcs] Lunderberg opened a new pull request #7: [UnitTests] Parametrized Unit Tests

2021-06-09 Thread GitBox
Lunderberg opened a new pull request #7: URL: https://github.com/apache/tvm-rfcs/pull/7 Migrating earlier conversation from https://discuss.tvm.apache.org/t/rfc-parametrized-unit-tests/9946. RFC should be up to date with all changes/conversations that occurred in that thread.

[GitHub] [tvm-rfcs] tqchen commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
tqchen commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648507080 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm-rfcs] comaniac commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648506005 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm-rfcs] comaniac commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648492658 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm-rfcs] comaniac commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648491301 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[GitHub] [tvm] tkonolige commented on a change in pull request #8215: [TVMSCRIPT] Fix printing of rank 0 buffer access

2021-06-09 Thread GitBox
tkonolige commented on a change in pull request #8215: URL: https://github.com/apache/tvm/pull/8215#discussion_r648491258 ## File path: python/tvm/script/intrin.py ## @@ -180,6 +185,11 @@ def opaque_axis(begin, end, span): return get_axis(begin, end, "opaque", span)

[tvm-site] branch asf-site updated: Build at Wed Jun 9 12:44:31 EDT 2021

2021-06-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 12a3558 Build at Wed Jun 9 12:44:31 EDT

[tvm-site] branch main updated: Update community.yml

2021-06-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/main by this push: new 2cba23c Update community.yml 2cba23c is

[GitHub] [tvm] tkonolige commented on a change in pull request #8215: [TVMSCRIPT] Fix printing of rank 0 buffer access

2021-06-09 Thread GitBox
tkonolige commented on a change in pull request #8215: URL: https://github.com/apache/tvm/pull/8215#discussion_r648490597 ## File path: tests/python/unittest/test_tvmscript_roundtrip.py ## @@ -2888,6 +2888,67 @@ def test_opaque_block(): assert

[GitHub] [tvm-rfcs] comaniac commented on a change in pull request #5: [RFC] Meta Schedule (AutoTIR)

2021-06-09 Thread GitBox
comaniac commented on a change in pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#discussion_r648490438 ## File path: rfcs/0001-meta-schedule-autotensorir.md ## @@ -0,0 +1,297 @@ +* Feature Name: Meta Schedule (AutoTensorIR) +* Start Date: 2021-05-28 +* RFC PR:

[tvm-site] branch asf-site updated: Build at Wed Jun 9 12:42:18 EDT 2021

2021-06-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new aef74e6 Build at Wed Jun 9 12:42:18 EDT

[tvm-site] branch main updated: Add a card with community calendar information (#28)

2021-06-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/main by this push: new b29da47 Add a card with community calendar

[tvm] branch main updated (8a04efa -> 53e4c60)

2021-06-09 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 8a04efa Graph executor: remove unnecessary unique_ptr, NFC (#8214) add 53e4c60 [DOC] Improve "Getting Started

[GitHub] [tvm] comaniac commented on pull request #8221: [DOC] Improve "Getting Started with TVM" tutorials and fix warnings

2021-06-09 Thread GitBox
comaniac commented on pull request #8221: URL: https://github.com/apache/tvm/pull/8221#issuecomment-857854344 Thanks @merrymercy @jcf94 @hogepodge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] comaniac merged pull request #8221: [DOC] Improve "Getting Started with TVM" tutorials and fix warnings

2021-06-09 Thread GitBox
comaniac merged pull request #8221: URL: https://github.com/apache/tvm/pull/8221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] areusch commented on a change in pull request #8072: Add "operator" style to Model Library Format

2021-06-09 Thread GitBox
areusch commented on a change in pull request #8072: URL: https://github.com/apache/tvm/pull/8072#discussion_r648477840 ## File path: python/tvm/micro/model_library_format.py ## @@ -203,60 +209,200 @@ def _build_function_memory_map(function_metadata): return ret -def

[GitHub] [tvm] areusch commented on a change in pull request #8072: Add "operator" style to Model Library Format

2021-06-09 Thread GitBox
areusch commented on a change in pull request #8072: URL: https://github.com/apache/tvm/pull/8072#discussion_r648477840 ## File path: python/tvm/micro/model_library_format.py ## @@ -203,60 +209,200 @@ def _build_function_memory_map(function_metadata): return ret -def

[GitHub] [tvm] areusch commented on a change in pull request #8072: Add "operator" style to Model Library Format

2021-06-09 Thread GitBox
areusch commented on a change in pull request #8072: URL: https://github.com/apache/tvm/pull/8072#discussion_r648474389 ## File path: src/printer/model_library_format_printer.cc ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

  1   2   >