[GitHub] [tvm] wrongtest commented on pull request #9699: [TIR] Affine utility support iter lowerbound and diagnostics

2021-12-19 Thread GitBox
wrongtest commented on pull request #9699: URL: https://github.com/apache/tvm/pull/9699#issuecomment-997668914 > 2\. Iters with lower bound constraints can be substituted with a zero-starting iter plus offset Hi~ @spectrometerHBH Could you kindly take another round of review for lo

[GitHub] [tvm] zxybazh commented on pull request #9773: [community] @lunderberg -> Committer

2021-12-19 Thread GitBox
zxybazh commented on pull request #9773: URL: https://github.com/apache/tvm/pull/9773#issuecomment-997647288 Congrats Eric! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9768: [Target] Fix device mask issue and typos

2021-12-19 Thread GitBox
junrushao1994 commented on a change in pull request #9768: URL: https://github.com/apache/tvm/pull/9768#discussion_r772113310 ## File path: python/tvm/_ffi/runtime_ctypes.py ## @@ -217,13 +216,15 @@ class Device(ctypes.Structure): "stackvm": 1, "cpu": 1,

[GitHub] [tvm] gussmith23 opened a new pull request #9775: Include \0 terminating character in strncpy

2021-12-19 Thread GitBox
gussmith23 opened a new pull request #9775: URL: https://github.com/apache/tvm/pull/9775 I'm fairly certain that this bugfix is correct, but please check my code. I'm not sure how this hasn't caused more problems for people! Perhaps the malloced memory is usually filled with 0s? Either way

[GitHub] [tvm] leeexyz commented on a change in pull request #9768: [Target] Fix device mask issue and typos

2021-12-19 Thread GitBox
leeexyz commented on a change in pull request #9768: URL: https://github.com/apache/tvm/pull/9768#discussion_r772066271 ## File path: python/tvm/_ffi/runtime_ctypes.py ## @@ -217,13 +216,15 @@ class Device(ctypes.Structure): "stackvm": 1, "cpu": 1, "c

[tvm] branch main updated: Fix GLOBAL_SCOPE Shallow copy bug (#9718)

2021-12-19 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 5cb5c5b Fix GLOBAL_SCOPE Shallow copy bug (#9718) 5cb5c

[GitHub] [tvm] vinx13 merged pull request #9718: Fix GLOBAL_SCOPE Shallow copy bug

2021-12-19 Thread GitBox
vinx13 merged pull request #9718: URL: https://github.com/apache/tvm/pull/9718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] shengxinhu commented on pull request #9767: [PartitionPattern] Modify Pattern Partitioner to only check expr in current group

2021-12-19 Thread GitBox
shengxinhu commented on pull request #9767: URL: https://github.com/apache/tvm/pull/9767#issuecomment-997549985 Hi @mbrookhart , there are many test cases could not pass this changes, as there are new Variables in new function body. Do you has any better idea for my issue? or maybe I need

[tvm] branch main updated: [TE][TensorIR] fix tensor attr in create_prim_func (#9764)

2021-12-19 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 8352f2f [TE][TensorIR] fix tensor attr in create_pr

[GitHub] [tvm] junrushao1994 merged pull request #9764: [TE][TensorIR] fix tensor attr in create_prim_func

2021-12-19 Thread GitBox
junrushao1994 merged pull request #9764: URL: https://github.com/apache/tvm/pull/9764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [tvm] xiaolong18 opened a new pull request #9774: [Bugfix] fix the bug that occurs when the test_pass_ctx_exception() is

2021-12-19 Thread GitBox
xiaolong18 opened a new pull request #9774: URL: https://github.com/apache/tvm/pull/9774 tested separately. In the batch test ,cause a previous function will specify the value of PassContext.current() as None,so tests the test_pass_exception() will pass. but when testing it indi

[GitHub] [tvm] chunit-quic edited a comment on pull request #9723: [Frontend] Add Span filling for frontends to Relay

2021-12-19 Thread GitBox
chunit-quic edited a comment on pull request #9723: URL: https://github.com/apache/tvm/pull/9723#issuecomment-997486966 Hi @mbs-octoml, @jroesch, Just a gentle ping. Should I modify something more or would it be fine to be merged? Thanks :) -- This is an automated message from the

[GitHub] [tvm] chunit-quic commented on pull request #9723: [Frontend] Add Span filling for frontends to Relay

2021-12-19 Thread GitBox
chunit-quic commented on pull request #9723: URL: https://github.com/apache/tvm/pull/9723#issuecomment-997486966 Hi @mbs-octoml, @jroesch, Just a gentle ping. Should I modify something more or would it be fine to merged? Thanks :) -- This is an automated message from the Apache Gi

[GitHub] [tvm] masahi commented on pull request #9768: [Target] Fix device mask issue and typos

2021-12-19 Thread GitBox
masahi commented on pull request #9768: URL: https://github.com/apache/tvm/pull/9768#issuecomment-997479800 cc @zxybazh @junrushao1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [tvm] masahi commented on a change in pull request #9768: [Target] Fix device mask issue and typos

2021-12-19 Thread GitBox
masahi commented on a change in pull request #9768: URL: https://github.com/apache/tvm/pull/9768#discussion_r772014649 ## File path: python/tvm/_ffi/runtime_ctypes.py ## @@ -217,13 +216,15 @@ class Device(ctypes.Structure): "stackvm": 1, "cpu": 1, "c"

[GitHub] [tvm] masahi commented on a change in pull request #9637: Add FP requantize flow for llvm target

2021-12-19 Thread GitBox
masahi commented on a change in pull request #9637: URL: https://github.com/apache/tvm/pull/9637#discussion_r771999877 ## File path: src/relay/qnn/op/requantize.cc ## @@ -208,6 +310,127 @@ Expr RequantizeLower(const Expr& input_tensor, const Expr& input_scale, return Cast(c

[GitHub] [tvm] masahi commented on pull request #9637: Add FP requantize flow for llvm target

2021-12-19 Thread GitBox
masahi commented on pull request #9637: URL: https://github.com/apache/tvm/pull/9637#issuecomment-997459968 Have you benchmarked on ARM? I think we should enable this only for x86 for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[tvm] branch main updated (7b9538f -> 7fac08b)

2021-12-19 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 7b9538f [community] @lunderberg -> Committer (#9773) add 7fac08b Clarify error message for missing libraries (#9710

[GitHub] [tvm] masahi merged pull request #9710: Clarify error message for missing libraries

2021-12-19 Thread GitBox
masahi merged pull request #9710: URL: https://github.com/apache/tvm/pull/9710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] tqchen commented on pull request #9773: [community] @lunderberg -> Committer

2021-12-19 Thread GitBox
tqchen commented on pull request #9773: URL: https://github.com/apache/tvm/pull/9773#issuecomment-997454010 Congrats Eric -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [tvm] kk2049 commented on issue #9715: [Bug] Te.gradient not work with complex forward workload

2021-12-19 Thread GitBox
kk2049 commented on issue #9715: URL: https://github.com/apache/tvm/issues/9715#issuecomment-997443436 @comaniac Thanks for your reply! I have tried to run this workload with `tvm.target.Target("llvm")`. This workload can be successfully launched. So I select `target("cuda")` again and tr

[GitHub] [tvm] junrushao1994 commented on pull request #9755: [TIRScript] fix parse StringImm value in for loop annotations

2021-12-19 Thread GitBox
junrushao1994 commented on pull request #9755: URL: https://github.com/apache/tvm/pull/9755#issuecomment-997436517 @Hzfengsy is that exactly the same issue we talked about a while ago? BTW please rebase to our latest HEAD -- This is an automated message from the Apache Git Service.

[GitHub] [tvm] junrushao1994 commented on pull request #9764: [TE][TensorIR] fix tensor attr in create_prim_func

2021-12-19 Thread GitBox
junrushao1994 commented on pull request #9764: URL: https://github.com/apache/tvm/pull/9764#issuecomment-997436161 okay to be more careful, I retriggered the CI to see if the problem is really gone. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] Lunderberg commented on pull request #9773: [community] @lunderberg -> Committer

2021-12-19 Thread GitBox
Lunderberg commented on pull request #9773: URL: https://github.com/apache/tvm/pull/9773#issuecomment-997419968 Thank you, all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[tvm] branch main updated: [community] @lunderberg -> Committer (#9773)

2021-12-19 Thread syfeng
This is an automated email from the ASF dual-hosted git repository. syfeng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 7b9538f [community] @lunderberg -> Committer (#9773) 7

[GitHub] [tvm] Hzfengsy merged pull request #9773: [community] @lunderberg -> Committer

2021-12-19 Thread GitBox
Hzfengsy merged pull request #9773: URL: https://github.com/apache/tvm/pull/9773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [tvm] Hzfengsy commented on pull request #9764: [TE][TensorIR] fix tensor attr in create_prim_func

2021-12-19 Thread GitBox
Hzfengsy commented on pull request #9764: URL: https://github.com/apache/tvm/pull/9764#issuecomment-997403984 I'm not sure. But just apply @junrushao1994 's suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [tvm] wrongtest commented on pull request #9755: [TIRScript] fix parse StringImm value in for loop annotations

2021-12-19 Thread GitBox
wrongtest commented on pull request #9755: URL: https://github.com/apache/tvm/pull/9755#issuecomment-997388960 > handle String annotation value and create StringImm I update it by the suggestion. But another problem is detected. Primfunc with flattened loop attrs seems not supported

[GitHub] [tvm] wrongtest commented on pull request #9764: [TE][TensorIR] fix tensor attr in create_prim_func

2021-12-19 Thread GitBox
wrongtest commented on pull request #9764: URL: https://github.com/apache/tvm/pull/9764#issuecomment-997387504 I notice that the check is successful now. So the error is due to binding the const reference to a temp vallue? :) @Hzfengsy -- This is an automated message from the Apache Git

[tvm] branch main updated (115919b -> 9ee0007)

2021-12-19 Thread syfeng
This is an automated email from the ASF dual-hosted git repository. syfeng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 115919b [MetaSchedule] Misc improvement of the Measurer (#9757) add 9ee0007 [M3c][MetaScheduler] Add ScheduleRule c

[GitHub] [tvm] Hzfengsy merged pull request #9761: [M3c][MetaScheduler] Add ScheduleRule class & PostOrderApply space generator.

2021-12-19 Thread GitBox
Hzfengsy merged pull request #9761: URL: https://github.com/apache/tvm/pull/9761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.