[GitHub] [incubator-tvm] comaniac commented on pull request #5409: [BYOC] Don't annotate constants

2020-04-28 Thread GitBox
comaniac commented on pull request #5409: URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-620711882 @manupa-arm I agree with your point and I prefer A1 more because it at least maintains annotation pairs. A1 actually treats a constant node as an input variable when

[GitHub] [incubator-tvm] comaniac commented on pull request #5409: [BYOC] Don't annotate constants

2020-04-24 Thread GitBox
comaniac commented on pull request #5409: URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-619198333 > I'm concerned that if we enforce annotation of individual constant nodes, MergeCompilerRegions will become a necessary pass to run. Otherwise we'll generate partitions