icemelon9 commented on issue #4769: [TOPI] Remove cpp upsampling and resize op
URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577910874
 
 
   I agree with @masahi. During the work of #4644, I found a few inconsistency 
between cpp and python topi implementation. Even for some simple schedule like 
injective, python version is better than cpp version, and has already 
overwritten the cpp implementation. I feel that keeping both cpp and python 
implementation for topi is a bit confusing, even that one op may only exist in 
cpp or python. Given that most of people now contribute to topi python, it 
makes sense that we only maintain the python version.
   
   In response to @tqchen, op compute could be stable, but the schedule might 
not be. Even op compute doesn't change over the time, we can still improve its 
schedule for better performance. It's easier to do so in python than in cpp.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to