[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-18 Thread GitBox
junrushao1994 commented on pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-646395649 @zhiics Could you take another look? Thanks! This is an automated message from the Apache Git

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-18 Thread GitBox
junrushao1994 commented on pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-646226758 @tqchen Just responded to all the review comments, added test cases and code comments, could you take another look?

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-16 Thread GitBox
junrushao1994 commented on pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-644613259 Summary of the change: - Remove most of the short names (i, n, m, d, b) and use more informative ones instead. - Added comments between important code blocks

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-15 Thread GitBox
junrushao1994 commented on pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-644234500 @zhiics @icemelon9 could you guys take another look? much appreciated! This is an automated message