[GitHub] [incubator-tvm] masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577930418 so tvm will finally compile itself :) This is an automated message from

[GitHub] [incubator-tvm] masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577927317 will wait for others to give opinions, will merge tomorrow. This is an

[GitHub] [incubator-tvm] masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577882904 Choosing cpp vs python per operator (rather than one lang for all ops) is a good compromise, but it creates other problems (need to

[GitHub] [incubator-tvm] masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577870143 I do agree that the cpp solution is desirable and has many benefits. For operators whose api and implementation would not be expected to

[GitHub] [incubator-tvm] masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
masahi commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577656902 I don't think C++ only solution is realistic so I prefer to keep only python. C++ resize in particular is hopelessly outdated and I