[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-612313039 Thanks @zhiics @comaniac This is an automated

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-612260657 Changes to multi output support in dnnl/codegen.cc has also been reverted in #5277, but I've already integrated that

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-612259904 @comaniac Done. Please take a look at the last commit

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-612254537 @zhiics @comaniac The change to the vm/compiler.cc that moved second fusion before Inline has been reverted in #5277.

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-612242732 Yes I'm working on fixing it. Resolving conflict turned out a bit complicated, so I wanted to start fresh.

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-611758714 > Although I still feel this is a bit ad-hoc, it should be fine for now as we only use DNNL as an example to

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-611273441 Yes I got that error too, but also there is a problem on i386 CI causing segfault from crt.

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-611248042 @tqchen Can you have a look at CI problem?

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-611211709 Also added support for conv2d + relu pattern. This shows how easy to add a new pattern and support it in the codegen.

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-610771579 @tqchen I got segfault in CI that is not related to this PR. Can you have a look?

[GitHub] [incubator-tvm] masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op

masahi commented on issue #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op URL: https://github.com/apache/incubator-tvm/pull/5272#issuecomment-610732150 Please review @zhiics @mbaret @comaniac @trevor-m