[GitHub] [incubator-tvm] mbaret commented on pull request #5646: Add a check Callback to the Pattern Paritioner

2020-05-21 Thread GitBox
mbaret commented on pull request #5646: URL: https://github.com/apache/incubator-tvm/pull/5646#issuecomment-632398727 I'll be honest and say the reason I didn't use structural equal for the second check was because I didn't want to write out the partitioned Relay expression :) I figured

[GitHub] [incubator-tvm] mbaret commented on pull request #5646: Add a check Callback to the Pattern Paritioner

2020-05-21 Thread GitBox
mbaret commented on pull request #5646: URL: https://github.com/apache/incubator-tvm/pull/5646#issuecomment-632383842 We should have a test case to investigate this. Calling type infer after the partitioning pass probably deals with most of the issues that could arise.