mbarrett97 commented on issue #4879: [Relay][Pass] Fix bug in re-processing
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586527273
So long as the test now correctly fails for the current behaviour, I'm
happy. The ordering mattering is
mbarrett97 commented on issue #4879: [Relay][Pass] Fix bug in re-processing
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586516413
So is the issue that the test case currently passes both pre and post fix?
If so, I'd say it probably d
mbarrett97 commented on issue #4879: [Relay][Pass] Fix bug in re-processing
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586472060
Unless I'm missing something, those graphs don't appear to me to be 'data
flow equivalent', so this may
mbarrett97 commented on issue #4879: [Relay][Pass] Fix bug in re-processing
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586429654
You could try graph_equal which claims to check for data flow equivalency,
although I am a bit surprise
mbarrett97 commented on issue #4879: [Relay][Pass] Fix bug in re-processing
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586364932
Good catch :) Fix looks to be correct, looking forward to the test case.
--
