[GitHub] [incubator-tvm] mbrookhart commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

2020-06-01 Thread GitBox
mbrookhart commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636976223 Just to look at what this did to the API docs, I did a local build of the docs and realized I didn't get the pattern language into the API doc build :scream: @comaniac

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

2020-06-01 Thread GitBox
mbrookhart commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636974410 :+1: I'm happy with that, it's more clear. This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

2020-05-31 Thread GitBox
mbrookhart commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636586492 I'm cool with the PR in general, but I'm a little skeptical of removing all of the doc strings for the syntactic sugar functions. Then again, I love the simplicity of