[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

tqchen commented on a change in pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#discussion_r443835313 ## File path: src/tir/op/builtin.cc ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

tqchen commented on a change in pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#discussion_r443819279 ## File path: python/tvm/contrib/nvcc.py ## @@ -98,7 +98,8 @@ def compile_cuda(code, (out, _) = proc.communicate() if proc.returncode !=

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

tqchen commented on a change in pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#discussion_r443819013 ## File path: include/tvm/tir/op_attr_types.h ## @@ -0,0 +1,48 @@ +/* Review comment: Most op belongs to either TIR primitive op or relay

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

tqchen commented on a change in pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#discussion_r443818595 ## File path: include/tvm/tir/expr.h ## @@ -888,66 +888,43 @@ class CallNode : public PrimExprNode { /*! \brief Intrinsic functions that are