[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577944754 I am half joking but who knows, maybe we will get there This is an

[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577929141 btw, we all love python. Perhaps the final solution is we use tvm to compile these python descriptions XD so we don’t need to to have

[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577921569 We can have another discussion thread about the scope of ops that goes to cxx. My current take is that the decision will likely

[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577874461 Hmm, i hear you. I think the nature of “need to adding new features” marks the op unstable, thus merit a python version as the primary

[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577710438 I do not mean that we have do it in this PR. Indeed having a C++ impl would be harder than the python version. On the other

[GitHub] [incubator-tvm] tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op

2020-01-23 Thread GitBox
tqchen commented on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577646627 In the case of upsampling and resize though should we consider them as stable ops and keep only cxx impl instead ? I agree it is