[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-22 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772 Thanks @rkimball @tmoreau89 @junrushao1994 ! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-21 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772 Thanks @rkimball @tmoreau89 @junrushao1994 ! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-21 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772 Thanks @rkimball @tmoreau89 @junrushao1994 ! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-12 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-12 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-12 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-11 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691334017 One thing we can do is `-Wextra, -pendenatic` then add a list of the warnings you want to enable in the WarningFlags.cmake. From time to time we can turn on -Weverything

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-11 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691333020 @rkimball how about we follow the recommendation to turn on -Weverything locally to see what is going on, but keep something more cross platform like `- Wextra, -Wall,

[GitHub] [incubator-tvm] tqchen commented on pull request #6456: Enable more warnings when compiling with clang 10.0 or greater

2020-09-11 Thread GitBox
tqchen commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275 Also FYI https://github.com/apache/incubator-tvm/pull/6450 fixes the MSVC warnings with a shorter list of disabled ones. Perhaps we can go with -Wextra -pedenatic for