tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772
Thanks @rkimball @tmoreau89 @junrushao1994 !
This is an automated message from the Apache Git Service.
To
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772
Thanks @rkimball @tmoreau89 @junrushao1994 !
This is an automated message from the Apache Git Service.
To
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-696462772
Thanks @rkimball @tmoreau89 @junrushao1994 !
This is an automated message from the Apache Git Service.
To
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691334017
One thing we can do is `-Wextra, -pendenatic` then add a list of the
warnings you want to enable in the WarningFlags.cmake.
From time to time we can turn on -Weverything
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691333020
@rkimball how about we follow the recommendation to turn on -Weverything
locally to see what is going on, but keep something more cross platform like `-
Wextra, -Wall,
tqchen commented on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691331275
Also FYI https://github.com/apache/incubator-tvm/pull/6450 fixes the MSVC
warnings with a shorter list of disabled ones.
Perhaps we can go with -Wextra -pedenatic for