tqchen edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-649619450
Thanks @jcf94 we should add a testcase to test_arith_rewrite_simplify, by constructing the case and - verify each of the rule added in this PR. - Use `isinstance(x, tvm.ir.Ramp)` to assert the ramp node - You mentioned a bug in the previous rule, it would be great if the testcase covers the bug you mentioned ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org