[GitHub] [incubator-tvm] zhiics commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-29 Thread GitBox
zhiics commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-621515297 @MarisaKirisame Sorry for the late response. Yeah, transforming it to ANF should work as well and seems like better fix. Let me try it.

[GitHub] [incubator-tvm] zhiics commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-28 Thread GitBox
zhiics commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-620886209 @MarisaKirisame Good question, I am not sure about large it is. @kevinthesun had a failed cased. Maybe he can give a better answer.