[GitHub] [tvm] Lunderberg commented on pull request #8532: [UnitTests] Expose TVM pytest helpers as plugin

2021-08-23 Thread GitBox
Lunderberg commented on pull request #8532: URL: https://github.com/apache/tvm/pull/8532#issuecomment-903756393 @areusch This PR is now rebased onto main to avoid conflicts with #8492, and I've included the refactoring that you suggested in an earlier comment. All integrations with

[GitHub] [tvm] Lunderberg commented on pull request #8532: [UnitTests] Expose TVM pytest helpers as plugin

2021-08-10 Thread GitBox
Lunderberg commented on pull request #8532: URL: https://github.com/apache/tvm/pull/8532#issuecomment-896225053 Looks like there's two additional failure modes after the rebase. One is related to the extracting of `tvm.testing.plugin`, and is now fixed here. I have one resolved here,

[GitHub] [tvm] Lunderberg commented on pull request #8532: [UnitTests] Expose TVM pytest helpers as plugin

2021-08-10 Thread GitBox
Lunderberg commented on pull request #8532: URL: https://github.com/apache/tvm/pull/8532#issuecomment-896050331 > @Lunderberg thanks, i think we can merge as is. It looks like there's a merge conflict now unfortunately--can you sync? Rebased now, and waiting on CI. I'm guessing

[GitHub] [tvm] Lunderberg commented on pull request #8532: [UnitTests] Expose TVM pytest helpers as plugin

2021-08-06 Thread GitBox
Lunderberg commented on pull request #8532: URL: https://github.com/apache/tvm/pull/8532#issuecomment-894509298 #8383 is the last PR I have open that impacts `testing.py`, after which I can add in a refactor to split apart user-facing utilities in `tvm.testing` from pytest integrations in

[GitHub] [tvm] Lunderberg commented on pull request #8532: [UnitTests] Expose TVM pytest helpers as plugin

2021-07-22 Thread GitBox
Lunderberg commented on pull request #8532: URL: https://github.com/apache/tvm/pull/8532#issuecomment-884964836 Potential reviewers: @areusch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to