[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-06 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-987508357 @leandron Thanks! Submitted a follow-up PR #9662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-03 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-985907705 Would you guys mind if I take over and implement my proposed approach to avoid creating dummy objects that lead to messy warnings? -- This is an automated message from the

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-03 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-985824643 @u99127 Yep those warnings are annoying and that’s exactly we need to avoid. With my proposal (avoid creating dummy Target objects), these warnings won’t pop up -- This is

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-01 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-984093437 Hey what do you think of my proposal? It could completely avoid creating dummy targets in TVMC and preserve the warning message :-) -- This is an automated message from the

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-29 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-981978677 Aha I got it now. Thanks @leandron for the explanation! The problem could go away if we do not create dummy `Target`s in TVMC if users don't specify them explicitly,

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-28 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-981189740 Thank you @leandron for the explanation! > Sure, if you see the example I provide in the initial message, it is expected that some machines won’t have a Rocm and/or

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-27 Thread GitBox
junrushao1994 commented on pull request #9599: URL: https://github.com/apache/tvm/pull/9599#issuecomment-980778920 Thanks @leandron for bringing it up! The error message is only supposed to appear when user doesn’t supply arch information, and it could not be detected in our local