[GitHub] [tvm] masahi edited a comment on pull request #7332: [PatternLang] Add a relay LetPattern

2021-01-22 Thread GitBox
masahi edited a comment on pull request #7332: URL: https://github.com/apache/tvm/pull/7332#issuecomment-765798515 I wonder, do we need to match against the let bound variable? Isn't it always `Var`? Not sure if relay Let supports pattern destructing on let lhs, like `let (x, y) = ... in

[GitHub] [tvm] masahi edited a comment on pull request #7332: [PatternLang] Add a relay LetPattern

2021-01-22 Thread GitBox
masahi edited a comment on pull request #7332: URL: https://github.com/apache/tvm/pull/7332#issuecomment-765798515 I wonder, do we need to match against the let bound variable? Isn't it always `Var`? Not sure if relay Let supports pattern destructing on let lhs, like `let (x, y) = ... in

[GitHub] [tvm] masahi edited a comment on pull request #7332: [PatternLang] Add a relay LetPattern

2021-01-22 Thread GitBox
masahi edited a comment on pull request #7332: URL: https://github.com/apache/tvm/pull/7332#issuecomment-765798515 I wonder, do we need to match against the let bound variable? Isn't it always `Var`? Not sure if relay Let supports pattern destructing on let lhs, like `let (x, y) = ... in