[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument

2021-09-01 Thread GitBox
vinx13 commented on pull request #8799: URL: https://github.com/apache/tvm/pull/8799#issuecomment-909711370 @Lyken17 could you add a test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument

2021-08-31 Thread GitBox
vinx13 commented on pull request #8799: URL: https://github.com/apache/tvm/pull/8799#issuecomment-909711370 @Lyken17 could you add a test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument

2021-08-24 Thread GitBox
vinx13 commented on pull request #8799: URL: https://github.com/apache/tvm/pull/8799#issuecomment-904816930 `relay.nn` is graph level operator, `topi.nn` is the platform-aware implementation of each operator. There is a lowering rule registered here

[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument

2021-08-23 Thread GitBox
vinx13 commented on pull request #8799: URL: https://github.com/apache/tvm/pull/8799#issuecomment-904153346 Merging these functions sounds good to me. Note that we have unified operators in Relay level, it might be fine to lower to different topi operators if this is simpler -- This is