Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-05-09 Thread via GitHub
gyenesvi commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2102803235 Great, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-05-09 Thread via GitHub
tqchen commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2102706022 Leaving it open for another week in case others want to chime in, otherwise LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-05-09 Thread via GitHub
gyenesvi commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2102668139 Thanks for the info about the schedules and differences, it makes sense. As for moving on, what would be the next step now? Do you need any other info from us for reviewing? --

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-05-09 Thread via GitHub
tqchen commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2102587457 I think the main reason here was relay default incorporate autotuning by default, while Relax dos not. The main rationale as of now is we would like to choose to decouple metaschedule

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-05-08 Thread via GitHub
agoston-mc commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2100973263 We have updated the PR with Relax frontend, but we have also kept the Relay, as an option, thinking it could be useful to have both, because we noticed performance differences during

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-04-16 Thread via GitHub
tqchen commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2058952581 Thanks for the note. We are in the process of revamping docs. The latest set of emerging model optimizations like LLMs will be based on relax.

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-04-16 Thread via GitHub
gyenesvi commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2058579469 Hi, > as a community we recently moves towards the relax IR for latest genAI workloads Thanks for directing us towards Relax. I guess that means that new frontends should

Re: [PR] [RFC] Add NNEF frontend [tvm-rfcs]

2024-04-13 Thread via GitHub
tqchen commented on PR #108: URL: https://github.com/apache/tvm-rfcs/pull/108#issuecomment-2053701317 Thanks for the proposal, as a community we recently moves towards the relax IR for latest genAI workloads, additionally, it is unclear how much adoption NNEF have as of now versus ONNX and