[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac edited a comment on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636633165 Hmm, docstring is a fair point. One solution I can think of is adding the API description in the docstring of the corresponding class. For example, adding

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5625: [Arith] ExtendedEuclidean merge impl to int_operator

ANSHUMAN87 commented on pull request #5625: URL: https://github.com/apache/incubator-tvm/pull/5625#issuecomment-636669406 @yzhliu : Thanks! CI is green, now! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5708: [PYTORCH]ReplicationPad support added

siju-samuel opened a new pull request #5708: URL: https://github.com/apache/incubator-tvm/pull/5708 Support the followng pad ops - aten::reflection_pad1d - aten::replication_pad1d - aten::replication_pad2d - aten::replication_pad3d @masahi please help me to review and

[GitHub] [incubator-tvm] comaniac commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636633165 Hmm, docstring is a fair point. One solution I can think of is adding the API description in the docstring of the corresponding class. For example, adding “is_tuple” to

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5426: [PY][FFI] Refactor runtime.String to subclass str

junrushao1994 commented on pull request #5426: URL: https://github.com/apache/incubator-tvm/pull/5426#issuecomment-637223693 If on python side we pass a `runtime::String` to packed function, whose signature uses `std::string` instead, is this case un-supported in this PR?

[GitHub] [incubator-tvm] tqchen commented on pull request #5426: [PY][FFI] Refactor runtime.String to subclass str

tqchen commented on pull request #5426: URL: https://github.com/apache/incubator-tvm/pull/5426#issuecomment-637249135 No, we don't support auto convert from String to std::string, we do want to convert most user facing packed api to use String though so no conversion is needed

[GitHub] [incubator-tvm] tqchen merged pull request #5712: Remove opengl runtime and cmake

tqchen merged pull request #5712: URL: https://github.com/apache/incubator-tvm/pull/5712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (f272e06 -> 13277a5)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f272e06 Remove deprecated opengl files (#5711) add 13277a5 Remove opengl runtime and cmake (#5712) No

[GitHub] [incubator-tvm] liangfu opened a new pull request #5713: [BUGFIX][CRT] Fix Compilation Error in CRT

liangfu opened a new pull request #5713: URL: https://github.com/apache/incubator-tvm/pull/5713 This is a hotfix for #5709 . @siju-samuel @mehrdadh Would you please help review this PR? This is an automated message

[GitHub] [incubator-tvm] tqchen commented on issue #5709: tvm/apps/bundle_deploy/build --> make failed

tqchen commented on issue #5709: URL: https://github.com/apache/incubator-tvm/issues/5709#issuecomment-637079716 cc @liangfu This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] kazum commented on a change in pull request #5634: [CODEGEN][CONTRIB] CoreML codegen

kazum commented on a change in pull request #5634: URL: https://github.com/apache/incubator-tvm/pull/5634#discussion_r433468578 ## File path: tests/python/contrib/test_coreml_codegen.py ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [incubator-tvm] comaniac commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-637038571 Ah, this is a bit tricky. For type annotation, we should use `DFPattern` in this case. However, in Python 3.6, it parses the source file only once for type checking. It

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac edited a comment on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-637038571 Ah, this is a bit tricky. For type annotation, we should use `DFPattern` in this case. However, in Python 3.6, it evaluates the annotations at function definition

[GitHub] [incubator-tvm] kazum commented on pull request #5634: [CODEGEN][CONTRIB] CoreML codegen

kazum commented on pull request #5634: URL: https://github.com/apache/incubator-tvm/pull/5634#issuecomment-637083244 @mbaret Thanks for your comment and sorry for my slow response. I've rebased and updated the code, could you take another look?

[GitHub] [incubator-tvm] tqchen commented on pull request #5706: fix typo: anchor windoes should be anchor windows

tqchen commented on pull request #5706: URL: https://github.com/apache/incubator-tvm/pull/5706#issuecomment-636929146 Thanks @randxie @cchung100m @siju-samuel ! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on pull request #5625: [Arith] ExtendedEuclidean merge impl to int_operator

tqchen commented on pull request #5625: URL: https://github.com/apache/incubator-tvm/pull/5625#issuecomment-636928852 Thanks @ANSHUMAN87 , @yzhliu please followup with other changes including gcd and lcm in the another PR(e.g #5618.)

[incubator-tvm] branch master updated (12cfe4a -> b0959d4)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 12cfe4a [AutoTVM][TOPI] Fix bifrost spatial packing conv2d auto tune (#5684) add b0959d4 [Arith]

[incubator-tvm] branch master updated (b0959d4 -> f280883)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b0959d4 [Arith] ExtendedEuclidean merge impl to int_operator (#5625) add f280883 fix typo: anchor

[GitHub] [incubator-tvm] tqchen merged pull request #5706: fix typo: anchor windoes should be anchor windows

tqchen merged pull request #5706: URL: https://github.com/apache/incubator-tvm/pull/5706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

mbrookhart commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636974410 :+1: I'm happy with that, it's more clear. This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tqchen commented on issue #5707: Publish TVM4J artifact

tqchen commented on issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707#issuecomment-636955709 Please open a new discuss thread on https://discuss.tvm.ai/ for the related topic. Due to the ASF policy, we only release source release officially. But we could

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5703: [PatternLang] Simplify Pattern API Implementations

tqchen edited a comment on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636961679 I agree that it is better to keep the docstring and add indirection in this case, as we did in many places in the codebase

[GitHub] [incubator-tvm] breandan commented on issue #5707: Publish TVM4J artifact

breandan commented on issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707#issuecomment-636962274 Tried to resubmit this issue on the forums, but received the following message:

[GitHub] [incubator-tvm] tqchen commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

tqchen commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636961679 I agree that it is better to keep the docstring and add indirection in this case, as we did in many cases in the codebase

[GitHub] [incubator-tvm] comaniac commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636971180 OK I'll change them back then. @mbrookhart how about `is_input` vs. `is_var`? This is an

[GitHub] [incubator-tvm] tqchen merged pull request #5625: [Arith] ExtendedEuclidean merge impl to int_operator

tqchen merged pull request #5625: URL: https://github.com/apache/incubator-tvm/pull/5625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on pull request #5705: [REFACTOR][PY] relay.op.Op -> tvm.ir.Op

tqchen commented on pull request #5705: URL: https://github.com/apache/incubator-tvm/pull/5705#issuecomment-636952764 cc @jroesch @zhiics @yzhliu This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] breandan commented on issue #5707: Publish TVM4J artifact

breandan commented on issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707#issuecomment-636966615 Thanks @tqchen, continuing the discussion [here](https://discuss.tvm.ai/t/publish-tvm4j-artifact/6861). This

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

mbrookhart commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636976223 Just to look at what this did to the API docs, I did a local build of the docs and realized I didn't get the pattern language into the API doc build :scream: @comaniac

[GitHub] [incubator-tvm] tqchen closed issue #5707: Publish TVM4J artifact

tqchen closed issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen closed issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

tqchen closed issue #5650: URL: https://github.com/apache/incubator-tvm/issues/5650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5707: Publish TVM4J artifact

tqchen edited a comment on issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707#issuecomment-636955709 Thanks for bringing it up. Please open a new discuss thread on https://discuss.tvm.ai/ for the related topic. Due to the ASF policy, we only release source release

[GitHub] [incubator-tvm] tqchen commented on issue #5707: Publish TVM4J artifact

tqchen commented on issue #5707: URL: https://github.com/apache/incubator-tvm/issues/5707#issuecomment-636964890 seems to be a false alarm of the discours, just approved, Thanks @breandan This is an automated message from

[GitHub] [incubator-tvm] comaniac commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

comaniac commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-636985743 Sure I can do that as well in this PR. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] aGiant opened a new issue #5709: tvm/apps/bundle_deploy/build --> make failed

aGiant opened a new issue #5709: URL: https://github.com/apache/incubator-tvm/issues/5709 - Ubuntu 18.04 LTS - LLVM installed according to https://apt.llvm.org/ - tvm was successfully compiled and worked well using python 3.7 with MXNet. - tvm 0.7 dev But for this

[GitHub] [incubator-tvm] tqchen merged pull request #5705: [REFACTOR][PY] relay.op.Op -> tvm.ir.Op

tqchen merged pull request #5705: URL: https://github.com/apache/incubator-tvm/pull/5705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: [REFACTOR][PY] relay.op.Op -> tvm.ir.Op (#5705)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new afc239a [REFACTOR][PY] relay.op.Op ->

[GitHub] [incubator-tvm] tqchen opened a new pull request #5712: Remove opengl runtime and cmake

tqchen opened a new pull request #5712: URL: https://github.com/apache/incubator-tvm/pull/5712 cc @zhiics @icemelon9 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

tqchen commented on pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637205361 @zhiics Good point, i opened https://github.com/apache/incubator-tvm/pull/5712 for that This is an

[GitHub] [incubator-tvm] mole10 opened a new issue #5710: [BUG][CODEGEN][OPENCL]Invalid data type in generated OpenCL kernel

mole10 opened a new issue #5710: URL: https://github.com/apache/incubator-tvm/issues/5710 Hello all, I believe there is a bug within OpenCL codegen which results in a typo in data type identifiers. I am recently observing undefined type identifiers such as 'float44' and 'float88'

[GitHub] [incubator-tvm] tqchen commented on issue #5710: [BUG][CODEGEN][OPENCL]Invalid data type in generated OpenCL kernel

tqchen commented on issue #5710: URL: https://github.com/apache/incubator-tvm/issues/5710#issuecomment-637156680 cc @kazum @kevinthesun @vinx13 please help confirm the issue This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5710: [BUG][CODEGEN][OPENCL]Invalid data type in generated OpenCL kernel

tqchen edited a comment on issue #5710: URL: https://github.com/apache/incubator-tvm/issues/5710#issuecomment-637156680 cc @kazum @kevinthesun @huochaitiantang@vinx13 please see if you can send a fix. This is an automated

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

tqchen commented on pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637162637 cc @icemelon9 @zhiics @yzhliu This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen opened a new pull request #5711: Remove deprecated opengl files

tqchen opened a new pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-tvm] zhiics commented on pull request #5711: Remove deprecated opengl files

zhiics commented on pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637174561 BTW, do we still need to keep the files under src/runtime/opengl ? This is an automated message from the

[incubator-tvm] branch master updated: [PatternLang] Simplify Pattern API Implementations (#5703)

This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 43162d6 [PatternLang] Simplify Pattern

[GitHub] [incubator-tvm] masahi commented on pull request #5703: [PatternLang] Simplify Pattern API Implementations

masahi commented on pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703#issuecomment-637192655 Thanks @comaniac @mbrookhart @tqchen This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (43162d6 -> 663a5ab)

This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 43162d6 [PatternLang] Simplify Pattern API Implementations (#5703) add 663a5ab [PYTORCH]ReplicationPad

[GitHub] [incubator-tvm] masahi merged pull request #5708: [PYTORCH]ReplicationPad support added

masahi merged pull request #5708: URL: https://github.com/apache/incubator-tvm/pull/5708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] masahi commented on pull request #5708: [PYTORCH]ReplicationPad support added

masahi commented on pull request #5708: URL: https://github.com/apache/incubator-tvm/pull/5708#issuecomment-637192979 Thanks @siju-samuel This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] masahi merged pull request #5703: [PatternLang] Simplify Pattern API Implementations

masahi merged pull request #5703: URL: https://github.com/apache/incubator-tvm/pull/5703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5711: Remove deprecated opengl files

icemelon9 commented on pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637179418 Do we still need the `type_hint` in the device API that is specific for opengl? This is an automated

[GitHub] [incubator-tvm] tqchen merged pull request #5711: Remove deprecated opengl files

tqchen merged pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: Remove deprecated opengl files (#5711)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new f272e06 Remove deprecated opengl files

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

tqchen commented on pull request #5711: URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637204039 @icemelon9 I think it makes sense to keep it since future graphics API like vulkan could benefit from it, if we decide to extend include texture memory support.

[GitHub] [incubator-tvm] kevinthesun commented on issue #4118: [RFC] Dynamic Shape Support - Graph Dispatching

kevinthesun commented on issue #4118: URL: https://github.com/apache/incubator-tvm/issues/4118#issuecomment-637296508 @zhanghaohit This feature is one part of dynamic codegen. We are working some significant backend features and will update this later.