[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442105064 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"torch.u

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442105064 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"torch.u

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442088235 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] siju-samuel edited a comment on issue #5835: Darknet library support out of date/inconsistent with master?

2020-06-18 Thread GitBox
siju-samuel edited a comment on issue #5835: URL: https://github.com/apache/incubator-tvm/issues/5835#issuecomment-645889680 @alexwong This error is because the `network` and `layer` datastructure is not same between master and tvmbranch. So the parsing have issues. Im currently updating

[GitHub] [incubator-tvm] siju-samuel commented on issue #5835: Darknet library support out of date/inconsistent with master?

2020-06-18 Thread GitBox
siju-samuel commented on issue #5835: URL: https://github.com/apache/incubator-tvm/issues/5835#issuecomment-645889680 @alexwong This error is because the `network` and `layer` datastructure is not same. So the parsing have issues. Im currently updating the whole code based on 'https://g

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator implem

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator implem

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator implem

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442071688 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070736 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"torch.u

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"torch.u

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070171 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator implem

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066837 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator implem

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"torch.u

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5839: [Torch][Quantized] Fix converting serialized quantized models

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5839: URL: https://github.com/apache/incubator-tvm/pull/5839#discussion_r442066028 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -595,15 +601,18 @@ def _impl(inputs, input_types): return _op.log(_op.tensor.s

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-06-18 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r442061994 ## File path: python/tvm/contrib/target/onnx.py ## @@ -0,0 +1,899 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442032927 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val): 0:"

<    1   2