[GitHub] [incubator-tvm] cchung100m edited a comment on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
cchung100m edited a comment on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552075617 Hi @jwfromm Thanks for the suggestion and I change the code of testing loop. However,

[GitHub] [incubator-tvm] cchung100m edited a comment on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
cchung100m edited a comment on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552075617 Hi @jwfromm Thanks for the suggestion and I had changed the code of testing loop. How

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552075617 Hi @jwfromm Thanks for the suggestion and I had changed the code of testing loop. However, I

[GitHub] [incubator-tvm] u99127 commented on issue #4292: Retain qnn input kernel scales

2019-11-08 Thread GitBox
u99127 commented on issue #4292: Retain qnn input kernel scales URL: https://github.com/apache/incubator-tvm/pull/4292#issuecomment-552075218 > > > Overall LGTM. The only change I request is changing the name to input_scale and kernel_scale. I have similar naming elsewhere, so will

[GitHub] [incubator-tvm] anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation.

2019-11-08 Thread GitBox
anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation. URL: https://github.com/apache/incubator-tvm/pull/4249#issuecomment-552074719 @jackwish It will be good if you could review this as well :)

[GitHub] [incubator-tvm] u99127 opened a new pull request #4292: Retain qnn input kernel scales

2019-11-08 Thread GitBox
u99127 opened a new pull request #4292: Retain qnn input kernel scales URL: https://github.com/apache/incubator-tvm/pull/4292 The QNN dialect loses the input tensor scale and the weight tensor scale too early. This inhibits the work one could do with integrating 3rd party codegen or li

[GitHub] [incubator-tvm] wweic opened a new issue #4291: [Prelude][Relay] Add utility function to extract tensor from prelude tensor_t

2019-11-08 Thread GitBox
wweic opened a new issue #4291: [Prelude][Relay] Add utility function to extract tensor from prelude tensor_t URL: https://github.com/apache/incubator-tvm/issues/4291 `tensor_t` in prelude is a type that wraps variable rank tensor with variable shape. Like, `tensor_array_concat` will retur

[GitHub] [incubator-tvm] yzhliu opened a new pull request #4290: Rename ml.dmlc.tvm to org.apache.tvm

2019-11-08 Thread GitBox
yzhliu opened a new pull request #4290: Rename ml.dmlc.tvm to org.apache.tvm URL: https://github.com/apache/incubator-tvm/pull/4290 @tqchen This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-tvm] FrozenGene commented on issue #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
FrozenGene commented on issue #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#issuecomment-552069295 > If I understand tolerance correctly, I think atol of 1 is good for integers and current implementation. Let me know if I am wrong. >

[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-552068563 > split then check creates additional data structures such as vector and string(additional data structures), which can be avoided as you can simply do

[GitHub] [incubator-tvm] wweic commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape

2019-11-08 Thread GitBox
wweic commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape URL: https://github.com/apache/incubator-tvm/pull/4287#discussion_r344429813 ## File path: python/tvm/relay/frontend/common.py ## @@ -451,20 +451,27 @@ def get_name(node):

[GitHub] [incubator-tvm] wweic commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape

2019-11-08 Thread GitBox
wweic commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape URL: https://github.com/apache/incubator-tvm/pull/4287#discussion_r344429675 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -90,6 +90,12 @@ def _get_list_param(para

[GitHub] [incubator-tvm] junrushao1994 commented on issue #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module

2019-11-08 Thread GitBox
junrushao1994 commented on issue #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module URL: https://github.com/apache/incubator-tvm/pull/4289#issuecomment-552062951 Will do this Sunday This is an automated

[GitHub] [incubator-tvm] jwfromm commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
jwfromm commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552056942 Although your changes to the tests removing the hardcoding are definitely in the right direction, I think we

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape

2019-11-08 Thread GitBox
icemelon9 commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape URL: https://github.com/apache/incubator-tvm/pull/4287#discussion_r344421852 ## File path: python/tvm/relay/frontend/common.py ## @@ -451,20 +451,27 @@ def get_name(node):

[GitHub] [incubator-tvm] minminsun commented on issue #4234: Auto TensorCore CodeGen

2019-11-08 Thread GitBox
minminsun commented on issue #4234: Auto TensorCore CodeGen URL: https://github.com/apache/incubator-tvm/pull/4234#issuecomment-552050894 Hi @Laurawly, could you please help to review the updates? Thank you! This is an automat

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #4234: Auto TensorCore CodeGen

2019-11-08 Thread GitBox
minminsun commented on a change in pull request #4234: Auto TensorCore CodeGen URL: https://github.com/apache/incubator-tvm/pull/4234#discussion_r344420309 ## File path: src/pass/tensor_core.cc ## @@ -0,0 +1,1247 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [incubator-tvm] yongwww commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape

2019-11-08 Thread GitBox
yongwww commented on a change in pull request #4287: [TF][Relay][Op] Pass module when infer shape URL: https://github.com/apache/incubator-tvm/pull/4287#discussion_r344418376 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -90,6 +90,12 @@ def _get_list_param(pa

[GitHub] [incubator-tvm] tqchen opened a new pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module

2019-11-08 Thread GitBox
tqchen opened a new pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module URL: https://github.com/apache/incubator-tvm/pull/4289 Previously runtime::Module was supported using shared_ptr. This PR refactors the codebase to use the Object protocol. I

[GitHub] [incubator-tvm] tqchen commented on issue #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module

2019-11-08 Thread GitBox
tqchen commented on issue #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module URL: https://github.com/apache/incubator-tvm/pull/4289#issuecomment-552045007 cc @jroesch @junrushao1994 @yzhliu This is an

[GitHub] [incubator-tvm] tqchen commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
tqchen commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-552038806 Yes, we can do that This is an automated message from the Apache Git Serv

[GitHub] [incubator-tvm] Rphaet0n opened a new issue #4288: [Relay][Feature] CoreML MLModel PipelineClassifier support

2019-11-08 Thread GitBox
Rphaet0n opened a new issue #4288: [Relay][Feature] CoreML MLModel PipelineClassifier support URL: https://github.com/apache/incubator-tvm/issues/4288 Now Core ML (>= 2.0) models created using Create ML framework for image classification have [PipelineClassifier ](https://apple.github.io/

[GitHub] [incubator-tvm] yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-552027579 @tqchen Shall we print warning message when ppl use nnvm? This is an auto

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4268: [Codegen][cuda-fp16] fallback to fp32 simulation when cuda arch < sm53

2019-11-08 Thread GitBox
yzhliu commented on a change in pull request #4268: [Codegen][cuda-fp16] fallback to fp32 simulation when cuda arch < sm53 URL: https://github.com/apache/incubator-tvm/pull/4268#discussion_r344391770 ## File path: src/codegen/codegen_cuda.cc ## @@ -50,6 +50,9 @@ void CodeG

[GitHub] [incubator-tvm] wweic opened a new pull request #4287: [TF][Relay][Op] Pass module when infer shape

2019-11-08 Thread GitBox
wweic opened a new pull request #4287: [TF][Relay][Op] Pass module when infer shape URL: https://github.com/apache/incubator-tvm/pull/4287 The existing tests should be sufficient to validate this change. It's not easy to craft a unit test case that failed before and pass after this change.

[GitHub] [incubator-tvm] tqchen commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
tqchen commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-552003171 wrt to nnvm. Our original proposal is to keep nnvm until v0.6 release. Which means nnvm will appear in v0.6 with limited support(the legac

[GitHub] [incubator-tvm] yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-552002504 I updated the issue, please let us know if anything's missing. (I didn't include "Build and Test" and "Bug fixes" section as the entire

[GitHub] [incubator-tvm] tqchen commented on issue #4286: [RFC] Use Object Protocol to Support runtime::Module

2019-11-08 Thread GitBox
tqchen commented on issue #4286: [RFC] Use Object Protocol to Support runtime::Module URL: https://github.com/apache/incubator-tvm/issues/4286#issuecomment-552001542 previous discussions here https://discuss.tvm.ai/t/discuss-use-object-protocol-for-module-ndarray/4583

[GitHub] [incubator-tvm] tqchen opened a new issue #4286: [RFC] Use Object Protocol to Support runtime::Module

2019-11-08 Thread GitBox
tqchen opened a new issue #4286: [RFC] Use Object Protocol to Support runtime::Module URL: https://github.com/apache/incubator-tvm/issues/4286 The [unified object protocol](https://github.com/dmlc/tvm/issues/4116) is now used by almost all of our runtime objects. However, there are still t

[GitHub] [incubator-tvm] ajtulloch commented on issue #4277: [ARM][Topi] Improving Int8 Perf in Spatial Conv2D schedule.

2019-11-08 Thread GitBox
ajtulloch commented on issue #4277: [ARM][Topi] Improving Int8 Perf in Spatial Conv2D schedule. URL: https://github.com/apache/incubator-tvm/pull/4277#issuecomment-551993046 @FrozenGene wow, those are very impressive results. Congratulations, looking forward to the talk and the code :) --

[GitHub] [incubator-tvm] tqchen commented on issue #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-551981112 split then check creates additional data structures such as vector and string(additional data structures), which can be avoided as you can simply do ist

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
FrozenGene commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344347686 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
FrozenGene commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344347149 ## File path: apps/cpp_rpc/rpc_env.h ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-551969728 @tqchen Wish I have solved many comments. I also replace SelectHelper into PoolHelper. Remained: Ideally, we should just use std::istringstr

[GitHub] [incubator-tvm] anijain2305 edited a comment on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation.

2019-11-08 Thread GitBox
anijain2305 edited a comment on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation. URL: https://github.com/apache/incubator-tvm/pull/4249#issuecomment-551966857 @FrozenGene I made it work. The workload had to be modified. I tried with my 2 conv network. It

[GitHub] [incubator-tvm] anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation.

2019-11-08 Thread GitBox
anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation. URL: https://github.com/apache/incubator-tvm/pull/4249#issuecomment-551966857 @FrozenGene I made it work. The workload had to be modified. I tried with my 2 conv network. It finish

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551960356 As a followup thread about what we might be able to benefit from in terms of external module, it would be great if we

[GitHub] [incubator-tvm] tqchen commented on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen commented on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551960356 As a followup thread about what we might be able to benefit from in terms of external module, it would be great if we have an

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551957000 To followup on the discussion thread. While we understand that the current PR achieves the purpose of supporting exter

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551957000 To followup on the discussion thread. While we understand that the current PR achieves the purpose of supporting exter

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551957000 To followup on the discussion thread. While we understand that the current PR achieves the purpose of supporting exter

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen edited a comment on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551957000 To followup on the discussion thread. While we understand that the current PR achieves the purpose of supporting exter

[GitHub] [incubator-tvm] tqchen commented on issue #4280: [tvm][runtime] A minimum runtime for external library

2019-11-08 Thread GitBox
tqchen commented on issue #4280: [tvm][runtime] A minimum runtime for external library URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-551957000 To followup on the discussion thread. While we understand that the current PR achieves the purpose of supporting external lib

[GitHub] [incubator-tvm] kevinthesun opened a new pull request #4285: Fix tf reshape

2019-11-08 Thread GitBox
kevinthesun opened a new pull request #4285: Fix tf reshape URL: https://github.com/apache/incubator-tvm/pull/4285 Move symbolic related logic after infer value is failed. This is an automated message from the Apache Git S

[GitHub] [incubator-tvm] anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation.

2019-11-08 Thread GitBox
anijain2305 commented on issue #4249: [TOPI][AlterOpLayout][ARM] Enabling NHWC to NCHW layout transformation. URL: https://github.com/apache/incubator-tvm/pull/4249#issuecomment-551951671 I tried to call AtlerOpLayout() before extracting the tasks, it was able to extract the NCHW convs and

[GitHub] [incubator-tvm] adityaatluri commented on a change in pull request #4234: Auto TensorCore CodeGen

2019-11-08 Thread GitBox
adityaatluri commented on a change in pull request #4234: Auto TensorCore CodeGen URL: https://github.com/apache/incubator-tvm/pull/4234#discussion_r344321090 ## File path: src/pass/tensor_core.cc ## @@ -0,0 +1,1247 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
anijain2305 commented on a change in pull request #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#discussion_r344305651 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -624,17 +661,23 @@ def _test_greater(dat

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
anijain2305 commented on a change in pull request #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#discussion_r344304495 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -545,34 +561,55 @@ def test_forward_conc

[GitHub] [incubator-tvm] anijain2305 commented on issue #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
anijain2305 commented on issue #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#issuecomment-551935940 If I understand tolerance correctly, I think atol of 1 is good for integers and current implementation. Let me know if I am wrong. For

[GitHub] [incubator-tvm] tqchen commented on issue #4284: [TEST][FLAKY] darknet/test_forward.py::test_forward_conv_batch_norm

2019-11-08 Thread GitBox
tqchen commented on issue #4284: [TEST][FLAKY] darknet/test_forward.py::test_forward_conv_batch_norm URL: https://github.com/apache/incubator-tvm/issues/4284#issuecomment-551929915 cc @srkreddy1238 can you take a look? This i

[GitHub] [incubator-tvm] tqchen opened a new issue #4284: [TEST][FLAKY] tests/python/frontend/darknet/test_forward.py::test_forward_conv_batch_norm

2019-11-08 Thread GitBox
tqchen opened a new issue #4284: [TEST][FLAKY] tests/python/frontend/darknet/test_forward.py::test_forward_conv_batch_norm URL: https://github.com/apache/incubator-tvm/issues/4284 http://ci.tvm.ai:8080/blue/rest/organizations/jenkins/pipelines/tvm/branches/master/runs/12/nodes/239/log/?sta

[GitHub] [incubator-tvm] tqchen commented on issue #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-551928185 @weberlo @srkreddy1238 @snowolfhawk it would be great if you can also help to review the PR -

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344291688 ## File path: src/common/socket.h ## @@ -62,6 +65,25 @@ inline std::string GetHostName() { return std::string(buf.c_

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344288316 ## File path: apps/cpp_rpc/rpc_env.h ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344289337 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344290589 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344292628 ## File path: src/common/socket.h ## @@ -468,7 +524,134 @@ class TCPSocket : public Socket { } return ndone;

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344289079 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344291055 ## File path: src/common/socket.h ## @@ -62,6 +65,25 @@ inline std::string GetHostName() { return std::string(buf.c_

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344293873 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344288617 ## File path: apps/cpp_rpc/rpc_env.h ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344290100 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344289033 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344288861 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344288460 ## File path: apps/cpp_rpc/rpc_env.h ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344293102 ## File path: apps/cpp_rpc/rpc_tracker_client.h ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344289224 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344292057 ## File path: src/common/socket.h ## @@ -62,6 +65,25 @@ inline std::string GetHostName() { return std::string(buf.c_

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344289299 ## File path: apps/cpp_rpc/rpc_server.cc ## @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC

2019-11-08 Thread GitBox
tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344288389 ## File path: apps/cpp_rpc/rpc_env.h ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] weberlo edited a comment on issue #4274: [µTVM] Enable AutoTVM for ARM STM32F746XX Boards

2019-11-08 Thread GitBox
weberlo edited a comment on issue #4274: [µTVM] Enable AutoTVM for ARM STM32F746XX Boards URL: https://github.com/apache/incubator-tvm/pull/4274#issuecomment-551330769 @tqchen It looks like the CI doesn't allow assembly---namely, [utvm_init.s](https://github.com/apache/incubator-tvm/pull/4

[GitHub] [incubator-tvm] yzhliu commented on issue #4104: Fix the TF tutorial to run against TF2.0 and TF1.x

2019-11-08 Thread GitBox
yzhliu commented on issue #4104: Fix the TF tutorial to run against TF2.0 and TF1.x URL: https://github.com/apache/incubator-tvm/pull/4104#issuecomment-551897488 @ic could you retrigger the CI by push a trivial commit? This i

[GitHub] [incubator-tvm] inadob commented on issue #4283: Add support for quant. mul operator in tflite frontend

2019-11-08 Thread GitBox
inadob commented on issue #4283: Add support for quant. mul operator in tflite frontend URL: https://github.com/apache/incubator-tvm/pull/4283#issuecomment-551878667 @kevinthesun @FrozenGene can you please take a look at this? --

[GitHub] [incubator-tvm] inadob opened a new pull request #4283: Add support for quant. mul operator in tflite frontend

2019-11-08 Thread GitBox
inadob opened a new pull request #4283: Add support for quant. mul operator in tflite frontend URL: https://github.com/apache/incubator-tvm/pull/4283 A test for qnn_mul has to be added when the qnn elemwise tests (#4282) get merged.

[GitHub] [incubator-tvm] yangjunpro commented on a change in pull request #4234: Auto TensorCore CodeGen

2019-11-08 Thread GitBox
yangjunpro commented on a change in pull request #4234: Auto TensorCore CodeGen URL: https://github.com/apache/incubator-tvm/pull/4234#discussion_r344225553 ## File path: src/pass/tensor_core.cc ## @@ -0,0 +1,1247 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
cchung100m commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#discussion_r344206710 ## File path: tests/python/frontend/onnx/test_forward.py ## @@ -142,6 +

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox
cchung100m commented on a change in pull request #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#discussion_r344206403 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -466,6 +466,76 @@

[GitHub] [incubator-tvm] FrozenGene commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
FrozenGene commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-551657497 Though C++ RPC haven't been reviewed, but personally, I wish C++ RPC https://github.com/apache/incubator-tvm/pull/4281 could enter int

[GitHub] [incubator-tvm] FrozenGene edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-08 Thread GitBox
FrozenGene edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-551657497 Though C++ RPC haven't been reviewed, personally, I wish C++ RPC https://github.com/apache/incubator-tvm/pull/4281 could enter

[GitHub] [incubator-tvm] JuanIsernGhosn commented on issue #4009: [RFC] 3D model support

2019-11-08 Thread GitBox
JuanIsernGhosn commented on issue #4009: [RFC] 3D model support URL: https://github.com/apache/incubator-tvm/issues/4009#issuecomment-551604526 That's a great idea. It would be a great advance to include support for 3D models. ---

[GitHub] [incubator-tvm] FrozenGene commented on issue #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
FrozenGene commented on issue #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#issuecomment-551539810 @inadob Thanks for improvement. Abs tolerance up to 1 doesn't make sense. I think it should be the problem I discuss with @anijain2305 : http

[GitHub] [incubator-tvm] inadob commented on issue #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
inadob commented on issue #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282#issuecomment-551508197 @FrozenGene @anijain2305 can you please review this patch This is an automated m

[GitHub] [incubator-tvm] inadob opened a new pull request #4282: Add test for the qnn_add operator

2019-11-08 Thread GitBox
inadob opened a new pull request #4282: Add test for the qnn_add operator URL: https://github.com/apache/incubator-tvm/pull/4282 The tests use fake quant approach so until the tf session, tensors remain in float32. The test data has to be passed in uint8 because of how the tflite/tvm co

[GitHub] [incubator-tvm] DaniDeniz commented on issue #4009: [RFC] 3D model support

2019-11-08 Thread GitBox
DaniDeniz commented on issue #4009: [RFC] 3D model support URL: https://github.com/apache/incubator-tvm/issues/4009#issuecomment-551452672 I am interested in running 3D networks! Thank you This is an automated message from

[GitHub] [incubator-tvm] comaniac commented on issue #4276: [TOPI][CUDA] Fix Winograd Kernel Size Support

2019-11-08 Thread GitBox
comaniac commented on issue #4276: [TOPI][CUDA] Fix Winograd Kernel Size Support URL: https://github.com/apache/incubator-tvm/pull/4276#issuecomment-551436043 > > @comaniac > > * It is normal to have increased error when tile size are beyond (3x3) in case of winograd. Than

[GitHub] [incubator-tvm] cbalint13 commented on issue #4276: [TOPI][CUDA] Fix Winograd Kernel Size Support

2019-11-08 Thread GitBox
cbalint13 commented on issue #4276: [TOPI][CUDA] Fix Winograd Kernel Size Support URL: https://github.com/apache/incubator-tvm/pull/4276#issuecomment-551433546 > Thanks for the suggestion. The unit test has been added and I've confirmed the unit test covers the desire part. > > One

[GitHub] [incubator-tvm] yzhliu merged pull request #4278: Fix the problem that android_rpc compilation failed

2019-11-08 Thread GitBox
yzhliu merged pull request #4278: Fix the problem that android_rpc compilation failed URL: https://github.com/apache/incubator-tvm/pull/4278 This is an automated message from the Apache Git Service. To respond to the message

[incubator-tvm] branch master updated (76b7967 -> 281f643)

2019-11-08 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 76b7967 [TOPI][CUDA] Fix Winograd Kernel Size Support (#4276) add 281f643 Update tvm_runtime.h (#4278

[GitHub] [incubator-tvm] yzhliu commented on issue #4278: Fix the problem that android_rpc compilation failed

2019-11-08 Thread GitBox
yzhliu commented on issue #4278: Fix the problem that android_rpc compilation failed URL: https://github.com/apache/incubator-tvm/pull/4278#issuecomment-551432237 Thanks @PeikeLi This is an automated message from the Apache