[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-29 Thread GitBox
alexwong commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r372766377 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,1098 @@ +# Licensed to the

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-29 Thread GitBox
masahi commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r372752325 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,1098 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] FrozenGene commented on issue #4785: [FFI][Windows] Parse additional exception strings

2020-01-29 Thread GitBox
FrozenGene commented on issue #4785: [FFI][Windows] Parse additional exception strings URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-580071366 @soiferj if you have no other comment, please approve this change according to this doc:

[GitHub] [incubator-tvm] shoubhik commented on issue #4764: [CI] ci-gpu update blockers

2020-01-29 Thread GitBox
shoubhik commented on issue #4764: [CI] ci-gpu update blockers URL: https://github.com/apache/incubator-tvm/issues/4764#issuecomment-580066405 @tqchen, in that case, can we create a new docker instance specifically for testing the qnn parser?

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4790: Fast exponent

2020-01-29 Thread GitBox
FrozenGene commented on a change in pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r372741774 ## File path: topi/include/topi/elemwise.h ## @@ -360,5 +359,71 @@ inline Tensor full_like(const Tensor& x, }, name, tag);

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4775: conv3d_ndhwc schedule

2020-01-29 Thread GitBox
vinx13 commented on a change in pull request #4775: conv3d_ndhwc schedule URL: https://github.com/apache/incubator-tvm/pull/4775#discussion_r372740925 ## File path: topi/python/topi/x86/conv3d.py ## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-01-29 Thread GitBox
FrozenGene commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r372740391 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -244,6 +244,57 @@

[GitHub] [incubator-tvm] jroesch merged pull request #4783: Make sure to visit the arguments of inlined functions

2020-01-29 Thread GitBox
jroesch merged pull request #4783: Make sure to visit the arguments of inlined functions URL: https://github.com/apache/incubator-tvm/pull/4783 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (1b8522e -> 6798ba8)

2020-01-29 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 1b8522e [AUTOTVM] Fix a bug in generating the search space (#4779) add 6798ba8 Make sure to visit the

[GitHub] [incubator-tvm] icemelon9 commented on issue #4764: [CI] ci-gpu update blockers

2020-01-29 Thread GitBox
icemelon9 commented on issue #4764: [CI] ci-gpu update blockers URL: https://github.com/apache/incubator-tvm/issues/4764#issuecomment-580047528 @shoubhik @tqchen I found out that mxnet-mkl RNN layer has some bug. If we use mxnet, the rnn layer test can pass. But if we install

[GitHub] [incubator-tvm] zxy844288792 commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
zxy844288792 commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372718146 ## File path: python/tvm/relay/op/nn/nn.py ## @@ -202,6 +203,8 @@ def conv2d(data,

[GitHub] [incubator-tvm] Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372695578 ## File path: python/tvm/autotvm/task/task.py ## @@ -116,43 +149,134 @@ def __repr__(self): self.name,

[GitHub] [incubator-tvm] Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372700311 ## File path: python/tvm/relay/quantize/_annotate.py ## @@ -53,11 +53,11 @@ def simulated_quantize_compute(attrs,

[GitHub] [incubator-tvm] Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
Laurawly commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372704546 ## File path: topi/python/topi/intel_graphics/conv2d.py ## @@ -443,8 +354,32 @@ def

[GitHub] [incubator-tvm] zxy844288792 commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
zxy844288792 commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372702055 ## File path: python/tvm/relay/op/nn/nn.py ## @@ -202,6 +203,8 @@ def conv2d(data,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372636908 ## File path: python/tvm/relay/backend/compile_engine.py ## @@ -63,6 +83,316 @@ def _get_cache_key(source_func,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372683444 ## File path: python/tvm/relay/backend/compile_engine.py ## @@ -63,6 +83,316 @@ def _get_cache_key(source_func,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372640446 ## File path: python/tvm/build_module.py ## @@ -425,6 +425,8 @@ def lower(sch, stmt =

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372685610 ## File path: python/tvm/relay/backend/compile_engine.py ## @@ -63,6 +83,316 @@ def _get_cache_key(source_func,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4644: [WIP] Relay op strategy

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4644: [WIP] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r372693044 ## File path: python/tvm/autotvm/task/dispatcher.py ## @@ -481,8 +412,12 @@ def _query_inside(self, target, workload):

[GitHub] [incubator-tvm] huajsj opened a new pull request #4791: [TOPI] upsample operator 'NCHWinic' format support.

2020-01-29 Thread GitBox
huajsj opened a new pull request #4791: [TOPI] upsample operator 'NCHWinic' format support. URL: https://github.com/apache/incubator-tvm/pull/4791 some hardware accelerator ask packed format data like NCHWinic to fit the hardware resource, here add 'upsample' 'NCHWinic' format support

[GitHub] [incubator-tvm] alexwong edited a comment on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-29 Thread GitBox
alexwong edited a comment on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-579987071 I cleaned up the code based off the simpler feedback and will focus on getting the CI to pass (w/ refactored test code based

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess

2020-01-29 Thread GitBox
mbarrett97 commented on issue #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess URL: https://github.com/apache/incubator-tvm/pull/4543#issuecomment-579987271 @FrozenGene are there any other changes you want?

[GitHub] [incubator-tvm] alexwong commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-29 Thread GitBox
alexwong commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-579987071 I cleaned up all of the simpler fixes and will focus on getting the CI to pass (w/ refactored test code based off @jwfromm's

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-29 Thread GitBox
alexwong commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r372650550 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,1135 @@ +# Licensed to the

[GitHub] [incubator-tvm] icemelon9 commented on issue #4644: [Draft] Relay op strategy

2020-01-29 Thread GitBox
icemelon9 commented on issue #4644: [Draft] Relay op strategy URL: https://github.com/apache/incubator-tvm/pull/4644#issuecomment-579944529 I've added the strategy for all ops. We can start to review this PR since it's huge. Could you help review it? @tqchen @kevinthesun @comaniac

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4775: conv3d_ndhwc schedule

2020-01-29 Thread GitBox
vinx13 commented on a change in pull request #4775: conv3d_ndhwc schedule URL: https://github.com/apache/incubator-tvm/pull/4775#discussion_r372586297 ## File path: topi/python/topi/x86/conv3d.py ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] jmorrill commented on issue #4785: [FFI][Windows] Parse additional exception strings

2020-01-29 Thread GitBox
jmorrill commented on issue #4785: [FFI][Windows] Parse additional exception strings URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-579897309 Clean fix was all you. I just did the clerical work. Thanks man!

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372523989 ## File path: python/tvm/relay/op/nn/nn.py ## @@ -202,6 +203,8 @@ def conv2d(data, dilation =

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372528150 ## File path: topi/python/topi/nn/conv2d.py ## @@ -62,6 +62,8 @@ def conv2d(input, filter, strides,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372525767 ## File path: python/tvm/relay/op/nn/util.py ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
comaniac commented on a change in pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372526415 ## File path: python/tvm/relay/op/nn/nn.py ## @@ -202,6 +203,8 @@ def conv2d(data, dilation =

[GitHub] [incubator-tvm] alexgl-github opened a new pull request #4790: Fast exponent

2020-01-29 Thread GitBox
alexgl-github opened a new pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please

[GitHub] [incubator-tvm] alexgl-github commented on issue #4775: conv3d_ndhwc schedule

2020-01-29 Thread GitBox
alexgl-github commented on issue #4775: conv3d_ndhwc schedule URL: https://github.com/apache/incubator-tvm/pull/4775#issuecomment-579823237 > @alexgl-github Thanks for the contribution. > > Almost every PR needs to have a test case in Apache TVM project. In this case, it can be a

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

2020-01-29 Thread GitBox
FrozenGene commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695#discussion_r372449323 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -705,47 +710,87 @@

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

2020-01-29 Thread GitBox
FrozenGene commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695#discussion_r372450103 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -843,6

[GitHub] [incubator-tvm] u99127 commented on issue #4696: [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

2020-01-29 Thread GitBox
u99127 commented on issue #4696: [Relay][Frontend][TFlite] Add support for quantized LOGISTIC URL: https://github.com/apache/incubator-tvm/pull/4696#issuecomment-579765000 ping for an approving review ? @FrozenGene @anijain2305.

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-01-29 Thread GitBox
u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r372389879 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -747,6 +749,158 @@ def

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-01-29 Thread GitBox
u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r372390838 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -747,6 +749,158 @@ def

[GitHub] [incubator-tvm] inadob commented on issue #4789: [Frontend][TFLite] Dynamically calculate input_stats of any fake_quant range

2020-01-29 Thread GitBox
inadob commented on issue #4789: [Frontend][TFLite] Dynamically calculate input_stats of any fake_quant range URL: https://github.com/apache/incubator-tvm/pull/4789#issuecomment-579739378 @kevinthesun @anijain2305 can you please take a look

[GitHub] [incubator-tvm] inadob opened a new pull request #4789: [Frontend][TFLite] Dynamically calculate input_stats of any fake_quant range

2020-01-29 Thread GitBox
inadob opened a new pull request #4789: [Frontend][TFLite] Dynamically calculate input_stats of any fake_quant range URL: https://github.com/apache/incubator-tvm/pull/4789 * pass the input range to the convertor and caclulate (mean, scale) there * change the range of the second tensor

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

2020-01-29 Thread GitBox
siju-samuel opened a new pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added URL: https://github.com/apache/incubator-tvm/pull/4788 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After

[GitHub] [incubator-tvm] zxy844288792 opened a new pull request #4787: [Relay] Conv2D padding representation

2020-01-29 Thread GitBox
zxy844288792 opened a new pull request #4787: [Relay] Conv2D padding representation URL: https://github.com/apache/incubator-tvm/pull/4787 As discussed here: https://discuss.tvm.ai/t/rfc-conv2d-padding-representation/5394. We agree we should enforce topi.nn.conv2d to accept 4-way