[GitHub] [incubator-tvm] zhen-jia commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner

2020-03-09 Thread GitBox
zhen-jia commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-596927909 > @zhen-jia Overall lgtm. Can you take a look at the ci failure? I am working on it and fixed the fai

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type

2020-03-09 Thread GitBox
ANSHUMAN87 commented on issue #5012: [1] Test case modified for int type URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-596916189 > Please look into the CI error @tqchen : This error does not reproduce in my setup. Looks like some random issue. To isolate i may p

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5022: [TFLITE]Round op parsing support added

2020-03-09 Thread GitBox
siju-samuel opened a new pull request #5022: [TFLITE]Round op parsing support added URL: https://github.com/apache/incubator-tvm/pull/5022 @wyc-ruiker @anijain2305 @FrozenGene Please help to review and merge this PR. TIA Thanks for contributing to TVM! Please refer to guideline h

[GitHub] [incubator-tvm] masahi opened a new issue #5021: [Relay, TOPI] Implement Adaptive Pool 3D op

2020-03-09 Thread GitBox
masahi opened a new issue #5021: [Relay, TOPI] Implement Adaptive Pool 3D op URL: https://github.com/apache/incubator-tvm/issues/5021 I found that we are missing adaptive pool 3d in our 3D op collections. With this, we can run 3D resnet from torchvision https://github.com/pytorch/vision/bl

[GitHub] [incubator-tvm] zhiics commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

2020-03-09 Thread GitBox
zhiics commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#issuecomment-596901640 I think leaving it under the contrib fold is probably not very good because we are not really testing them. Ther

[GitHub] [incubator-tvm] comaniac commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction

2020-03-09 Thread GitBox
comaniac commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction URL: https://github.com/apache/incubator-tvm/pull/5019#issuecomment-596901315 > Thanks for looking into this. I have hit the stackoverflow before. I've been working around it b

[GitHub] [incubator-tvm] jmorrill commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction

2020-03-09 Thread GitBox
jmorrill commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction URL: https://github.com/apache/incubator-tvm/pull/5019#issuecomment-596899986 Thanks for looking into this. I have hit the stackoverflow before. I've been working around it b

[GitHub] [incubator-tvm] masahi commented on issue #4949: Conv3D ONNX support and conv3D_ncdhw x86 schedules

2020-03-09 Thread GitBox
masahi commented on issue #4949: Conv3D ONNX support and conv3D_ncdhw x86 schedules URL: https://github.com/apache/incubator-tvm/pull/4949#issuecomment-596896933 hi, I'd like to use this schedule in my next Torch frontend PR (loading resnet 3D from torchvision). Can you merge this? @icemel

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #4951: Conditions updated to cover better user scenarios

2020-03-09 Thread GitBox
ANSHUMAN87 commented on issue #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#issuecomment-596897066 > This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM com

[GitHub] [incubator-tvm] zhiics commented on issue #5010: Early checking added and new test cases added for schedule fuse

2020-03-09 Thread GitBox
zhiics commented on issue #5010: Early checking added and new test cases added for schedule fuse URL: https://github.com/apache/incubator-tvm/pull/5010#issuecomment-596895536 Thanks @ANSHUMAN87 This is an automated message f

[GitHub] [incubator-tvm] zhiics merged pull request #5010: Early checking added and new test cases added for schedule fuse

2020-03-09 Thread GitBox
zhiics merged pull request #5010: Early checking added and new test cases added for schedule fuse URL: https://github.com/apache/incubator-tvm/pull/5010 This is an automated message from the Apache Git Service. To respond to

[incubator-tvm] branch master updated (fd39c5c -> c41e040)

2020-03-09 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from fd39c5c Implemented kDLCPUPinned (cudaMallocHost) (#4985) add c41e040 Early checking added and new test c

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5010: Early checking added and new test cases added for schedule fuse

2020-03-09 Thread GitBox
ANSHUMAN87 commented on issue #5010: Early checking added and new test cases added for schedule fuse URL: https://github.com/apache/incubator-tvm/pull/5010#issuecomment-596893416 > Could you add some description about what problems are trying to solve? It would help people to understand th

[GitHub] [incubator-tvm] wrongtest commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

2020-03-09 Thread GitBox
wrongtest commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#issuecomment-596892463 > For python unit test, something similar in your RFC should be okay. We have TensorFlow in the CI. For gtest

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390082464 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,116 @@ +# Licensed to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390082658 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,116 @@ +# Licensed to

[GitHub] [incubator-tvm] tqchen commented on issue #5012: [1] Test case modified for int type

2020-03-09 Thread GitBox
tqchen commented on issue #5012: [1] Test case modified for int type URL: https://github.com/apache/incubator-tvm/pull/5012#issuecomment-596873783 Please look into the CI error This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on issue #4931: Tighten split's extent

2020-03-09 Thread GitBox
tqchen commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-596873565 @merrymercy can you followup by reverting this PR first? Then @yongfeng-nv can send another PR back

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo

2020-03-09 Thread GitBox
tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo URL: https://github.com/apache/incubator-tvm/pull/5005#discussion_r390066083 ## File path: apps/android_camera/app/src/main/res/drawable/item_selector.xml ## @@ -0,0 +1,21 @@ +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo

2020-03-09 Thread GitBox
tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo URL: https://github.com/apache/incubator-tvm/pull/5005#discussion_r390066315 ## File path: apps/android_camera/app/src/main/res/drawable/item_selector.xml ## @@ -0,0 +1,21 @@ +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo

2020-03-09 Thread GitBox
tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo URL: https://github.com/apache/incubator-tvm/pull/5005#discussion_r390066315 ## File path: apps/android_camera/app/src/main/res/drawable/item_selector.xml ## @@ -0,0 +1,21 @@ +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo

2020-03-09 Thread GitBox
tqchen commented on a change in pull request #5005: [WIP]TVM android camera demo URL: https://github.com/apache/incubator-tvm/pull/5005#discussion_r390066083 ## File path: apps/android_camera/app/src/main/res/drawable/item_selector.xml ## @@ -0,0 +1,21 @@ +

[GitHub] [incubator-tvm] tqchen commented on issue #4500: [VTA][Python] Instruction Level Metal Test Infrastructure

2020-03-09 Thread GitBox
tqchen commented on issue #4500: [VTA][Python] Instruction Level Metal Test Infrastructure URL: https://github.com/apache/incubator-tvm/pull/4500#issuecomment-596872446 close for now due to inactive status, feel free to bring it back

[GitHub] [incubator-tvm] tqchen closed pull request #4500: [VTA][Python] Instruction Level Metal Test Infrastructure

2020-03-09 Thread GitBox
tqchen closed pull request #4500: [VTA][Python] Instruction Level Metal Test Infrastructure URL: https://github.com/apache/incubator-tvm/pull/4500 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5011: [Intrin] Adding a few missing math intrin

2020-03-09 Thread GitBox
tqchen edited a comment on issue #5011: [Intrin] Adding a few missing math intrin URL: https://github.com/apache/incubator-tvm/pull/5011#issuecomment-596872089 Thanks @antinucleon please add testcases to cover these cases Th

[GitHub] [incubator-tvm] tqchen commented on issue #4628: [Object] Add String container

2020-03-09 Thread GitBox
tqchen commented on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-596871935 ping @wweic :) This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-tvm] tqchen commented on issue #5011: [Intrin] Adding a few missing math intrin

2020-03-09 Thread GitBox
tqchen commented on issue #5011: [Intrin] Adding a few missing math intrin URL: https://github.com/apache/incubator-tvm/pull/5011#issuecomment-596872089 Thanks @antinucleon pleas eadd testcase to cover these cases This is an

[GitHub] [incubator-tvm] tqchen commented on issue #4985: Implemented kDLCPUPinned (cudaMallocHost)

2020-03-09 Thread GitBox
tqchen commented on issue #4985: Implemented kDLCPUPinned (cudaMallocHost) URL: https://github.com/apache/incubator-tvm/pull/4985#issuecomment-596871762 Thanks @jmorrill ! this is merged This is an automated message from the A

[incubator-tvm] branch master updated (41e1d5f -> fd39c5c)

2020-03-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 41e1d5f Revive the Rust + SGX refactor (#4976) add fd39c5c Implemented kDLCPUPinned (cudaMallocHost) (#

[GitHub] [incubator-tvm] tqchen merged pull request #4985: Implemented kDLCPUPinned (cudaMallocHost)

2020-03-09 Thread GitBox
tqchen merged pull request #4985: Implemented kDLCPUPinned (cudaMallocHost) URL: https://github.com/apache/incubator-tvm/pull/4985 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-tvm] tqchen commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod

2020-03-09 Thread GitBox
tqchen commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-596871412 ping @FrozenGene please followup This is an a

[GitHub] [incubator-tvm] tqchen closed issue #4860: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-03-09 Thread GitBox
tqchen closed issue #4860: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort URL: https://github.com/apache/incubator-tvm/issues/4860 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on issue #4860: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-03-09 Thread GitBox
tqchen commented on issue #4860: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort URL: https://github.com/apache/incubator-tvm/issues/4860#issuecomment-596871188 https://github.com/apache/incubator-tvm/pull/4891 ---

[GitHub] [incubator-tvm] tqchen edited a comment on issue #2885: [SGX] Use Fortanix EDP

2020-03-09 Thread GitBox
tqchen edited a comment on issue #2885: [SGX] Use Fortanix EDP URL: https://github.com/apache/incubator-tvm/pull/2885#issuecomment-596870953 superseded by https://github.com/apache/incubator-tvm/pull/4976 This is an automated

[GitHub] [incubator-tvm] tqchen closed pull request #2885: [SGX] Use Fortanix EDP

2020-03-09 Thread GitBox
tqchen closed pull request #2885: [SGX] Use Fortanix EDP URL: https://github.com/apache/incubator-tvm/pull/2885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-tvm] branch master updated (93dff44 -> 41e1d5f)

2020-03-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 93dff44 [REDO AFTER GH BUG] Add support for quantized models via QNN (#5016) add 41e1d5f Revive the Ru

[GitHub] [incubator-tvm] tqchen commented on issue #2885: [SGX] Use Fortanix EDP

2020-03-09 Thread GitBox
tqchen commented on issue #2885: [SGX] Use Fortanix EDP URL: https://github.com/apache/incubator-tvm/pull/2885#issuecomment-596870953 superceded by https://github.com/apache/incubator-tvm/pull/4976 This is an automated message

[GitHub] [incubator-tvm] tqchen commented on issue #4976: Revive the Rust + SGX refactor

2020-03-09 Thread GitBox
tqchen commented on issue #4976: Revive the Rust + SGX refactor URL: https://github.com/apache/incubator-tvm/pull/4976#issuecomment-596870852 Thanks @jroesch @nhynes ! This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tqchen merged pull request #4976: Revive the Rust + SGX refactor

2020-03-09 Thread GitBox
tqchen merged pull request #4976: Revive the Rust + SGX refactor URL: https://github.com/apache/incubator-tvm/pull/4976 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent

2020-03-09 Thread GitBox
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-596866979 > This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has

[GitHub] [incubator-tvm] masahi commented on issue #4964: [Torch] Add initial control flow support

2020-03-09 Thread GitBox
masahi commented on issue #4964: [Torch] Add initial control flow support URL: https://github.com/apache/incubator-tvm/pull/4964#issuecomment-596858140 @zhiics @MarisaKirisame @alexwong Comments were addressed and I have no plan of updating this PR further. Can we merge this? ---

[GitHub] [incubator-tvm] masahi commented on issue #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN

2020-03-09 Thread GitBox
masahi commented on issue #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN URL: https://github.com/apache/incubator-tvm/pull/5016#issuecomment-596857613 Thanks @anijain2305 @jwfromm This is an automated me

[GitHub] [incubator-tvm] masahi merged pull request #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN

2020-03-09 Thread GitBox
masahi merged pull request #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN URL: https://github.com/apache/incubator-tvm/pull/5016 This is an automated message from the Apache Git Service. To respond to th

[incubator-tvm] branch master updated (f346c60 -> 93dff44)

2020-03-09 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f346c60 Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)" (#5013) add 93dff44 [RE

[GitHub] [incubator-tvm] kevinthesun opened a new pull request #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement

2020-03-09 Thread GitBox
kevinthesun opened a new pull request #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement URL: https://github.com/apache/incubator-tvm/pull/5020 RFC: https://github.com/apache/incubator-tvm/issues/4969 In addition to control flow improvements, this PR also changes som

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390036823 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,116 @@ +# Licensed

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390036855 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,116 @@ +# Licensed

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction

2020-03-09 Thread GitBox
icemelon9 opened a new pull request #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction URL: https://github.com/apache/incubator-tvm/pull/5019 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful informatio

[GitHub] [incubator-tvm] icemelon9 commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction

2020-03-09 Thread GitBox
icemelon9 commented on issue #5019: [AutoTVM] Temporary fix to the stack overflow issue in autotvm task extraction URL: https://github.com/apache/incubator-tvm/pull/5019#issuecomment-596839279 cc @comaniac @merrymercy @kevinthesun --

[GitHub] [incubator-tvm] anijain2305 commented on issue #5018: Look for TupleType instead of TupleNode in LayoutRewriter

2020-03-09 Thread GitBox
anijain2305 commented on issue #5018: Look for TupleType instead of TupleNode in LayoutRewriter URL: https://github.com/apache/incubator-tvm/pull/5018#issuecomment-596832368 Trevor, can you please add a test case? The implementation is good, but we need a test case. -

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390018799 ## File path: src/relay/pass/extract_functions.cc ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390020988 ## File path: src/relay/pass/extract_functions.cc ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390019016 ## File path: src/relay/pass/extract_functions.cc ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
zhiics commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390019935 ## File path: src/relay/pass/extract_functions.cc ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] anwang2009 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
anwang2009 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390019572 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,114 @@ +# Licensed

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
tmoreau89 commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390011187 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,114 @@ +# Licensed

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390009947 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,114 @@ +# Licensed to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
jwfromm commented on a change in pull request #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#discussion_r390008819 ## File path: tests/python/relay/test_pass_extract_functions.py ## @@ -0,0 +1,114 @@ +# Licensed to

[GitHub] [incubator-tvm] notoraptor commented on issue #5017: Revert "[topi][relay] add operation tan to TVM (#4938)"

2020-03-09 Thread GitBox
notoraptor commented on issue #5017: Revert "[topi][relay] add operation tan to TVM (#4938)" URL: https://github.com/apache/incubator-tvm/pull/5017#issuecomment-596812398 Ok ! So, I wait for this PR to be merged. This is an a

[GitHub] [incubator-tvm] kevinthesun commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner

2020-03-09 Thread GitBox
kevinthesun commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-596810383 @zhen-jia Overall lgtm. Can you take a look at the ci failure? -

[GitHub] [incubator-tvm] trevor-m opened a new pull request #5018: Look for TupleType instead of TupleNode in LayoutRewriter

2020-03-09 Thread GitBox
trevor-m opened a new pull request #5018: Look for TupleType instead of TupleNode in LayoutRewriter URL: https://github.com/apache/incubator-tvm/pull/5018 When getting the input shapes from the args LayoutRewriter checked for tuples only by seeing if the node is an instance of TupleNOde. W

[GitHub] [incubator-tvm] mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596800033 Yep, I'll try and give a better explanation there in the morning. --

[GitHub] [incubator-tvm] kevinthesun commented on issue #5017: Revert "[topi][relay] add operation tan to TVM (#4938)"

2020-03-09 Thread GitBox
kevinthesun commented on issue #5017: Revert "[topi][relay] add operation tan to TVM (#4938)" URL: https://github.com/apache/incubator-tvm/pull/5017#issuecomment-596799940 @notoraptor Can you make another PR after this is merged? Thanks!

[GitHub] [incubator-tvm] kevinthesun opened a new pull request #5017: Revert "[topi][relay] add operation tan to TVM (#4938)"

2020-03-09 Thread GitBox
kevinthesun opened a new pull request #5017: Revert "[topi][relay] add operation tan to TVM (#4938)" URL: https://github.com/apache/incubator-tvm/pull/5017 This reverts PR: https://github.com/apache/incubator-tvm/pull/4938. @tqchen @notoraptor ---

[GitHub] [incubator-tvm] zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596797859 Can you post the questions on discussion forum? ---

[GitHub] [incubator-tvm] mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596795800 It's possible we're doing something wrong, but the function LowerExternalFunctions in compile_en

[GitHub] [incubator-tvm] anwang2009 commented on issue #4960: [Relay][Pass] Add submodule extraction pass

2020-03-09 Thread GitBox
anwang2009 commented on issue #4960: [Relay][Pass] Add submodule extraction pass URL: https://github.com/apache/incubator-tvm/pull/4960#issuecomment-596795439 I have made edits in accordance with the above RFC This is an autom

[GitHub] [incubator-tvm] zhiics edited a comment on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
zhiics edited a comment on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596790065 I personally don't think TVM should be aware of accelerator specific transformations beca

[GitHub] [incubator-tvm] zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596790065 I personally don't think TVM should be aware of accelerator specific transformations because the

[GitHub] [incubator-tvm] mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596785558 Beforehand, we had been running some passes after partitioning (for instance a layout transform

[GitHub] [incubator-tvm] zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
zhiics commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596783209 Yes, this is intended. We plan to do it. For example, we may want to have a build pipeline that

[GitHub] [incubator-tvm] mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen

2020-03-09 Thread GitBox
mbaret commented on issue #4996: [relay][external codegen] outline and inline lifted functions for external codegen URL: https://github.com/apache/incubator-tvm/pull/4996#issuecomment-596777325 @zhiics It looks like this makes it so we can't run any passes on external functions. Is this th

[GitHub] [incubator-tvm] leezu commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle

2020-03-09 Thread GitBox
leezu commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle URL: https://github.com/apache/incubator-tvm/issues/4958#issuecomment-596773696 > GCC5 is enough for c++14 support and should be available in most edge devices. Is there any overview on the edge devices to be su

[GitHub] [incubator-tvm] leezu edited a comment on issue #4958: [RFC] Require C++14 in 0.7 release cycle

2020-03-09 Thread GitBox
leezu edited a comment on issue #4958: [RFC] Require C++14 in 0.7 release cycle URL: https://github.com/apache/incubator-tvm/issues/4958#issuecomment-596773696 > GCC5 is enough for c++14 support and should be available in most edge devices. Is there any overview on the edge devices t

[GitHub] [incubator-tvm] tqchen commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle

2020-03-09 Thread GitBox
tqchen commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle URL: https://github.com/apache/incubator-tvm/issues/4958#issuecomment-596769163 GCC5 is enough for c++14 support and should be available in most edge devices. For runtime only support, the community recently introduce

[GitHub] [incubator-tvm] leezu commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle

2020-03-09 Thread GitBox
leezu commented on issue #4958: [RFC] Require C++14 in 0.7 release cycle URL: https://github.com/apache/incubator-tvm/issues/4958#issuecomment-596767825 An alternative is to require C++17 which gcc7 supports and ships by default in Ubuntu 18.04. C++17 compiler can be used on as old syste

[GitHub] [incubator-tvm] tqchen commented on issue #5015: [DEV] Amend Github Attribution Bug

2020-03-09 Thread GitBox
tqchen commented on issue #5015: [DEV] Amend Github Attribution Bug URL: https://github.com/apache/incubator-tvm/issues/5015#issuecomment-596763925 cc @merrymercy @kevinthesun @anijain2305 @masahi This is an automated message

[GitHub] [incubator-tvm] masahi opened a new pull request #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN

2020-03-09 Thread GitBox
masahi opened a new pull request #5016: [REDO AFTER GH BUG] Add support for quantized models via QNN URL: https://github.com/apache/incubator-tvm/pull/5016 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the

[GitHub] [incubator-tvm] masahi commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)"

2020-03-09 Thread GitBox
masahi commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)" URL: https://github.com/apache/incubator-tvm/pull/5013#issuecomment-596758568 yes coming, thanks for the quick action. Th

[GitHub] [incubator-tvm] tqchen commented on issue #4938: [topi][relay] add operation tan to TVM

2020-03-09 Thread GitBox
tqchen commented on issue #4938: [topi][relay] add operation tan to TVM URL: https://github.com/apache/incubator-tvm/pull/4938#issuecomment-596758207 cc @kevinthesun please send the reverting PR, then @notoraptor can send the patch --

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4938: [topi][relay] add operation tan to TVM

2020-03-09 Thread GitBox
tqchen edited a comment on issue #4938: [topi][relay] add operation tan to TVM URL: https://github.com/apache/incubator-tvm/pull/4938#issuecomment-596747804 This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. Th

[GitHub] [incubator-tvm] tqchen commented on issue #4975: Fix gpu not found when running TVM docker

2020-03-09 Thread GitBox
tqchen commented on issue #4975: Fix gpu not found when running TVM docker URL: https://github.com/apache/incubator-tvm/pull/4975#issuecomment-596757344 This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The com

[GitHub] [incubator-tvm] anijain2305 commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)"

2020-03-09 Thread GitBox
anijain2305 commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)" URL: https://github.com/apache/incubator-tvm/pull/5013#issuecomment-596757362 @masahi can you please follow-up with re-submission of your PR? ---

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4951: Conditions updated to cover better user scenarios

2020-03-09 Thread GitBox
tqchen edited a comment on issue #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#issuecomment-596750643 This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM co

[GitHub] [incubator-tvm] anijain2305 merged pull request #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)"

2020-03-09 Thread GitBox
anijain2305 merged pull request #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)" URL: https://github.com/apache/incubator-tvm/pull/5013 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-tvm] anijain2305 commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)"

2020-03-09 Thread GitBox
anijain2305 commented on issue #5013: Revert "[Torch, QNN] Add support for quantized models via QNN (#4977)" URL: https://github.com/apache/incubator-tvm/pull/5013#issuecomment-596757045 Thanks @tqchen this is merged This is

[GitHub] [incubator-tvm] tqchen commented on issue #4931: Tighten split's extent

2020-03-09 Thread GitBox
tqchen commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-596757101 This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has decided

[incubator-tvm] branch master updated (6ee9c2f -> f346c60)

2020-03-09 Thread anijain2305
This is an automated email from the ASF dual-hosted git repository. anijain2305 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 6ee9c2f typo (#5008) add f346c60 Revert "[Torch, QNN] Add support for quantized models via QNN (#

[GitHub] [incubator-tvm] tqchen commented on issue #4977: [Torch, QNN] Add support for quantized models via QNN

2020-03-09 Thread GitBox
tqchen commented on issue #4977: [Torch, QNN] Add support for quantized models via QNN URL: https://github.com/apache/incubator-tvm/pull/4977#issuecomment-596756472 This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM commu

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4951: Conditions updated to cover better user scenarios

2020-03-09 Thread GitBox
tqchen edited a comment on issue #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#issuecomment-596750643 Hi everyone. This PR is among one of the PRs affected by the github squash commit bug. See background here https://discus

[GitHub] [incubator-tvm] notoraptor commented on issue #4938: [topi][relay] add operation tan to TVM

2020-03-09 Thread GitBox
notoraptor commented on issue #4938: [topi][relay] add operation tan to TVM URL: https://github.com/apache/incubator-tvm/pull/4938#issuecomment-596751590 Hi @tqchen ! OK for that. Anyway, if it causes some problems, then we can just let things as it is, as my main goal was just to ma

[GitHub] [incubator-tvm] tqchen commented on issue #4951: Conditions updated to cover better user scenarios

2020-03-09 Thread GitBox
tqchen commented on issue #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#issuecomment-596750643 Hi everyone. This PR is among one of the PRs affected by the github squash commit bug. See background here https://discuss.tvm.a

[GitHub] [incubator-tvm] tqchen opened a new issue #5015: [DEV] Amend Github Attribution Bug

2020-03-09 Thread GitBox
tqchen opened a new issue #5015: [DEV] Amend Github Attribution Bug URL: https://github.com/apache/incubator-tvm/issues/5015 See background here https://discuss.tvm.ai/t/response-to-github-author-attribution-bug/5909 On Mar 5th 2020, github changed the the squash merge behavior, whic

[GitHub] [incubator-tvm] tqchen commented on issue #4938: [topi][relay] add operation tan to TVM

2020-03-09 Thread GitBox
tqchen commented on issue #4938: [topi][relay] add operation tan to TVM URL: https://github.com/apache/incubator-tvm/pull/4938#issuecomment-596747804 Hi @notoraptor @kevinthesun The community has reach a concensus to correct the github author attribution problem by reverting the affected PR

[incubator-tvm] branch master updated (450f716 -> 6ee9c2f)

2020-03-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 450f716 [Runtime] MISRA-C compliant TVM runtime (#3934) add 6ee9c2f typo (#5008) No new revisions were

[GitHub] [incubator-tvm] tqchen merged pull request #5008: typo

2020-03-09 Thread GitBox
tqchen merged pull request #5008: typo URL: https://github.com/apache/incubator-tvm/pull/5008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] jmorrill commented on issue #4968: [TOPI][CUDA] Teak CUDA injective scheduler

2020-03-09 Thread GitBox
jmorrill commented on issue #4968: [TOPI][CUDA] Teak CUDA injective scheduler URL: https://github.com/apache/incubator-tvm/pull/4968#issuecomment-596717519 > @jmorrill Could you help review #4983 first? This PR exposed a bug in TVM codegen. #4983 fixed it. Thanks! In addition to #498

[GitHub] [incubator-tvm] wpan11nv commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode

2020-03-09 Thread GitBox
wpan11nv commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode URL: https://github.com/apache/incubator-tvm/pull/4983#issuecomment-596715298 > While I am not qualified to give a review of this, I have applied your changes on this PR and it I was able to compile a mx

[GitHub] [incubator-tvm] wpan11nv commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode

2020-03-09 Thread GitBox
wpan11nv commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode URL: https://github.com/apache/incubator-tvm/pull/4983#issuecomment-596714625 @vinx13 Could you help review this PR? This is an automated

[GitHub] [incubator-tvm] jmorrill commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode

2020-03-09 Thread GitBox
jmorrill commented on issue #4983: [CodeGen][CUDA] Enhance CUDA codegen for SelectNode URL: https://github.com/apache/incubator-tvm/pull/4983#issuecomment-596712676 > Kindly ping. Can someone help review this PR? @wpan11nv, I think you have to tag some reviewers from here: https://git

  1   2   >