[GitHub] [incubator-tvm] jroesch commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
jroesch commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650484640 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] siju-samuel commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
siju-samuel commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650478109 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] junrushao1994 commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
junrushao1994 commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650476981 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] ZihengJiang commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
ZihengJiang commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650471485 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tvm-archiver commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
tvm-archiver commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650469065 +1 Thierry > On Jun 26, 2020, at 6:16 PM, masahi wrote: > > +1 > > -- > You are receiving this because you are subscribed to this thread.

[GitHub] [incubator-tvm] weberlo opened a new pull request #5940: Add Quantize/Dequantize Partitioning

2020-06-26 Thread GitBox
weberlo opened a new pull request #5940: URL: https://github.com/apache/incubator-tvm/pull/5940 Implements step 1 of the [Improvements to Automatic Quantization for Bare-Metal RFC](https://discuss.tvm.ai/t/rfc-improvements-to-automatic-quantization-for-bare-metal/7108). The code

[GitHub] [incubator-tvm] masahi commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
masahi commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650468556 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-tvm] tqchen commented on issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
tqchen commented on issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939#issuecomment-650460122 +1 (binding), I checked - Signatures and hashes good - DISCLAIMER, LICENSE, NOTICE - Signatures and hashes - No unexpected binary files - Code compiles

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
masahi commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446457483 ## File path: src/runtime/contrib/dnnl/dnnl_json_runtime.cc ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5921: µTVM CRT modifications for on-device RPC server

2020-06-26 Thread GitBox
tqchen commented on a change in pull request #5921: URL: https://github.com/apache/incubator-tvm/pull/5921#discussion_r446457499 ## File path: src/runtime/crt/Makefile ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: I

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-26 Thread GitBox
tqchen commented on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650457793 ping @giuseros This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] yzhliu opened a new issue #5939: [VOTE] Release Apache TVM (incubating) v0.6.1.rc0

2020-06-26 Thread GitBox
yzhliu opened a new issue #5939: URL: https://github.com/apache/incubator-tvm/issues/5939 Dear TVM community, This is a call for vote to release Apache TVM (incubating) version 0.6.1. This is a maintenance release incorporating important bug fixes. All users of Apache TVM

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5921: µTVM CRT modifications for on-device RPC server

2020-06-26 Thread GitBox
areusch commented on a change in pull request #5921: URL: https://github.com/apache/incubator-tvm/pull/5921#discussion_r446455221 ## File path: src/runtime/crt/Makefile ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Im

svn commit: r40189 - in /dev/incubator/tvm/tvm-v0.6.1-rc0: ./ apache-tvm-src-v0.6.1.rc0-incubating.tar.gz apache-tvm-src-v0.6.1.rc0-incubating.tar.gz.asc apache-tvm-src-v0.6.1.rc0-incubating.tar.gz.sh

2020-06-26 Thread liuyizhi
Author: liuyizhi Date: Fri Jun 26 23:51:23 2020 New Revision: 40189 Log: Add v0.6.1 RC0 Added: dev/incubator/tvm/tvm-v0.6.1-rc0/ dev/incubator/tvm/tvm-v0.6.1-rc0/apache-tvm-src-v0.6.1.rc0-incubating.tar.gz (with props)

[GitHub] [incubator-tvm] merrymercy commented on pull request #5938: [TOPI] Fix x86 conv2d template when tuning with unpacked layout

2020-06-26 Thread GitBox
merrymercy commented on pull request #5938: URL: https://github.com/apache/incubator-tvm/pull/5938#issuecomment-650450425 cc @kevinthesun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] merrymercy opened a new pull request #5938: Fix x86 conv2d template

2020-06-26 Thread GitBox
merrymercy opened a new pull request #5938: URL: https://github.com/apache/incubator-tvm/pull/5938 Fix a bug occurred when tuning a conv2d_nhwc with the unpacked layout. Without this fix, we will have ``` UnboundLocalError("local variable 'oc_bn' referenced before assignment"

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
zhiics commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446450843 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #5921: µTVM CRT modifications for on-device RPC server

2020-06-26 Thread GitBox
liangfu commented on a change in pull request #5921: URL: https://github.com/apache/incubator-tvm/pull/5921#discussion_r446450205 ## File path: src/runtime/crt/Makefile ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment:

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
masahi commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446449540 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen commented on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
tqchen commented on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650440958 OK, this is merged. the binary need to be manually updated, will report back when it is ready, This is

[GitHub] [incubator-tvm] tqchen merged pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
tqchen merged pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] tag v0.6.1.rc0 created (now 802f055)

2020-06-26 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to tag v0.6.1.rc0 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at 802f055 (commit) No new revisions were added by this update.

[incubator-tvm] branch master updated (69313a7 -> 5786e82)

2020-06-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 69313a7 [CODEGEN][CONTRIB] Various update for CoreML codegen (#5934) add 5786e82 add dnnl (#5936) No

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

2020-06-26 Thread GitBox
tqchen edited a comment on pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#issuecomment-650440226 Followup PR https://github.com/apache/incubator-tvm/pull/5937 This is an automated message from the

[GitHub] [incubator-tvm] tqchen commented on pull request #5937: [TIR][OP][API-CHANGE] Remove CallNode.call_type in favor of attribute.

2020-06-26 Thread GitBox
tqchen commented on pull request #5937: URL: https://github.com/apache/incubator-tvm/pull/5937#issuecomment-650440265 cc @junrushao1994 @yzhliu @merrymercy @ZihengJiang @wpan11nv @yongfeng-nv @masahi @Hzfengsy @spectrometerHBH @xqdan @FrozenGene @antinucleon @vinx13 @jwfromm

[GitHub] [incubator-tvm] tqchen commented on pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

2020-06-26 Thread GitBox
tqchen commented on pull request #5863: URL: https://github.com/apache/incubator-tvm/pull/5863#issuecomment-650440226 Followup PR This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446439808 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] comaniac commented on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
comaniac commented on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650432776 Verified that this docker image with DNNL works for AMD CPU (EC2 m5a.4xlarge instance). This is an

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
comaniac edited a comment on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650406197 OK will verify it on EC2 M5a instance and get back here. This is an automated message from the

[GitHub] [incubator-tvm] tqchen commented on pull request #5937: [TIR][OP][API-CHANGE] Remove CallNode.call_type in favor of attribute.

2020-06-26 Thread GitBox
tqchen commented on pull request #5937: URL: https://github.com/apache/incubator-tvm/pull/5937#issuecomment-650430255 Followup of https://github.com/apache/incubator-tvm/pull/5863 This is an automated message from the Apache

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446435931 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen opened a new pull request #5937: [TIR][OP][API-CHANGE] Remove CallNode.call_type in favor of attribute.

2020-06-26 Thread GitBox
tqchen opened a new pull request #5937: URL: https://github.com/apache/incubator-tvm/pull/5937 This is a followup refactor for tir::Call. Now that we have switched call->name to call->op, the function effect property can be registered through the op itself, so we no longer need the

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
comaniac edited a comment on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650406197 OK will verify it on EC2 M5c instance and get back here. This is an automated message from the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
zhiics commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446429394 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
zhiics commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446429394 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
masahi commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446427066 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
masahi commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446427066 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446425905 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
masahi commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446425296 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] comaniac commented on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
comaniac commented on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650406197 OK will verify it on EC2 A1 instance and get back here. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
tqchen commented on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-650393102 Please confirm if the dnnl works with AMD cpu, as we also have AMD cpus in the CI. This is an automated

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5855: [RELAY][VM] Add shape_of instruction

2020-06-26 Thread GitBox
zhiics commented on a change in pull request #5855: URL: https://github.com/apache/incubator-tvm/pull/5855#discussion_r446401587 ## File path: src/relay/op/vm/vm.cc ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] comaniac opened a new pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-26 Thread GitBox
comaniac opened a new pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936 The current BYOC flow uses DNNL as an example backend to demonstrate and test its functionality, but all related tests are currently skipped in CI due to the lack of DNNL in the environment.

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-26 Thread GitBox
jroesch commented on a change in pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r446388132 ## File path: python/tvm/relay/op/dyn/transform.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446383112 ## File path: tests/python/relay/test_json_runtime.py ## @@ -0,0 +1,625 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446382837 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] weberlo commented on a change in pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-26 Thread GitBox
weberlo commented on a change in pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#discussion_r446348563 ## File path: src/parser/parser.cc ## @@ -0,0 +1,968 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] weberlo commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-26 Thread GitBox
weberlo commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-650369009 A few thoughts: It's not clear to me that modifying this parser is any easier than the current parser. One could make a case that the current parser is suboptimal,

[GitHub] [incubator-tvm] yzhliu commented on pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#issuecomment-650352627 @sergei-grechanik @ANSHUMAN87 @tqchen @MarisaKirisame Please take a look again. This is an automated

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446365570 ## File path: tests/python/unittest/test_arith_solve_linear_inequality.py ## @@ -0,0 +1,166 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-26 Thread GitBox
mbrookhart commented on pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#issuecomment-650348127 @icemelon9 @lixiaoquan Per Haichen's request, I removed the dynamic option from the standard reshape and changed the places that used it to use the new purely dynamic

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-26 Thread GitBox
tmoreau89 commented on pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-650347598 In addition were you able to put a guide together? Which Intel FPGA have you tested this on? This

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-26 Thread GitBox
tmoreau89 commented on pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-650347427 @zhanghaohit good news, the end to end tests ran successfully on VTA hardware with your changes. Given that this PR brings modifications to the ISA spec, we need to

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446359570 ## File path: tests/python/unittest/test_arith_solve_linear_inequality.py ## @@ -0,0 +1,187 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446359262 ## File path: python/tvm/testing.py ## @@ -188,5 +189,96 @@ def assert_prim_expr_equal(lhs, rhs): raise ValueError("{} and {} are not

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5910: [Please Do Not Review] Trying to Unlink libcuda.so

2020-06-26 Thread GitBox
junrushao1994 commented on pull request #5910: URL: https://github.com/apache/incubator-tvm/pull/5910#issuecomment-650343229 Just FYI, if you want to run CI locally, you may find the commands in Jenkins helpful. More specifically, you can find commands like below to run what tvm ci

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-26 Thread GitBox
lhutton1 commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r445562478 ## File path: tests/python/relay/test_json_runtime.py ## @@ -0,0 +1,625 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446351576 ## File path: include/tvm/arith/int_solver.h ## @@ -191,6 +286,56 @@ void SmithNormalFormDiag(std::vector>* S, std::vector= f0(x1, x2, ..., xn) + *

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446351576 ## File path: include/tvm/arith/int_solver.h ## @@ -191,6 +286,56 @@ void SmithNormalFormDiag(std::vector>* S, std::vector= f0(x1, x2, ..., xn) + *

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446351576 ## File path: include/tvm/arith/int_solver.h ## @@ -191,6 +286,56 @@ void SmithNormalFormDiag(std::vector>* S, std::vector= f0(x1, x2, ..., xn) + *

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5855: [RELAY][VM] Add shape_of instruction

2020-06-26 Thread GitBox
icemelon9 commented on a change in pull request #5855: URL: https://github.com/apache/incubator-tvm/pull/5855#discussion_r446347040 ## File path: src/relay/op/vm/vm.cc ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5618: [Arith] Inequalities solver

2020-06-26 Thread GitBox
yzhliu commented on a change in pull request #5618: URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r446343013 ## File path: include/tvm/arith/int_solver.h ## @@ -26,17 +26,110 @@ #include #include +#include #include +#include #include

[GitHub] [incubator-tvm] comaniac commented on issue #5809: [RFC][AutoTVM] Non-square ConfigSpace

2020-06-26 Thread GitBox
comaniac commented on issue #5809: URL: https://github.com/apache/incubator-tvm/issues/5809#issuecomment-650312544 Polyhedral analysis would be an approach to generate the constraints in this scenario. On the other hand, the runtime validation sounds not a general solution, because it

[incubator-tvm] branch master updated (2bbfbb1 -> 69313a7)

2020-06-26 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 2bbfbb1 [Runtime] Only initialize required module (#5926) add 69313a7 [CODEGEN][CONTRIB] Various update

[GitHub] [incubator-tvm] zhiics commented on pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
zhiics commented on pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934#issuecomment-650305829 Thanks @kazum This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] zhiics merged pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
zhiics merged pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] zhiics commented on pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
zhiics commented on pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934#issuecomment-650303757 @kazum no problem. We shouldn't do that in this PR. I was just curious if you have a plan to do that.

[GitHub] [incubator-tvm] kazum commented on pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
kazum commented on pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934#issuecomment-650301527 @zhiics Relevant changes to #5770 are: https://github.com/apache/incubator-tvm/pull/5934/files#diff-639424334c798703f0e62ec8a5eaf779R30

[GitHub] [incubator-tvm] anijain2305 closed pull request #5935: [BACKPORT-0.6] [BUGFIX] [TFLite] Using real image for QNN testing.

2020-06-26 Thread GitBox
anijain2305 closed pull request #5935: URL: https://github.com/apache/incubator-tvm/pull/5935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-tvm] anijain2305 opened a new pull request #5935: [BACKPORT-0.6] [BUGFIX] [TFLite] Using real image for QNN testing.

2020-06-26 Thread GitBox
anijain2305 opened a new pull request #5935: URL: https://github.com/apache/incubator-tvm/pull/5935 Backport request - https://github.com/apache/incubator-tvm/issues/4824 Bugfix PR - https://github.com/apache/incubator-tvm/pull/4816

[GitHub] [incubator-tvm] shoubhik commented on pull request #5880: [BACKPORT-0.6][Bugfix] fskip of EliminateCommonSubexpr cannot always return false

2020-06-26 Thread GitBox
shoubhik commented on pull request #5880: URL: https://github.com/apache/incubator-tvm/pull/5880#issuecomment-650266446 Could you point me the CI commands that run for v0.6. I have a use case where I need to verify the v0.6 build by running test cases for v0.6 with docker CI locally

[GitHub] [incubator-tvm] trevor-m commented on pull request #5857: [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add

2020-06-26 Thread GitBox
trevor-m commented on pull request #5857: URL: https://github.com/apache/incubator-tvm/pull/5857#issuecomment-650261839 > Looks good to me. I'll merge this after CI is passed. Thanks! This is an automated message from

[GitHub] [incubator-tvm] zhiics edited a comment on pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
zhiics edited a comment on pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934#issuecomment-650246386 aah, I haven't noticed that CoreML codegen was also using BYOC infra. Thanks for updating it. I have a question which is not relevant to this change. I see

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5855: [RELAY][VM] Add shape_of instruction

2020-06-26 Thread GitBox
zhiics commented on a change in pull request #5855: URL: https://github.com/apache/incubator-tvm/pull/5855#discussion_r446250485 ## File path: python/tvm/relay/op/dialect/vm.py ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] zhiics commented on pull request #5926: [Runtime] Only initialize required module

2020-06-26 Thread GitBox
zhiics commented on pull request #5926: URL: https://github.com/apache/incubator-tvm/pull/5926#issuecomment-650229136 Thanks @comaniac This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] zhiics merged pull request #5926: [Runtime] Only initialize required module

2020-06-26 Thread GitBox
zhiics merged pull request #5926: URL: https://github.com/apache/incubator-tvm/pull/5926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: [Runtime] Only initialize required module (#5926)

2020-06-26 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 2bbfbb1 [Runtime] Only initialize

[GitHub] [incubator-tvm] tqchen commented on issue #5809: [RFC][AutoTVM] Non-square ConfigSpace

2020-06-26 Thread GitBox
tqchen commented on issue #5809: URL: https://github.com/apache/incubator-tvm/issues/5809#issuecomment-650211024 In this case it is not polyhedral model, but just some constraints on the config space. This is an automated

[GitHub] [incubator-tvm] tqchen commented on pull request #4704: [Relay][Frontend][TFLite] Add parser support for arg_min_max

2020-06-26 Thread GitBox
tqchen commented on pull request #4704: URL: https://github.com/apache/incubator-tvm/pull/4704#issuecomment-650208021 ping @inadob @anijain2305 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on pull request #5931: Add TupleGetItem to CSE

2020-06-26 Thread GitBox
tqchen commented on pull request #5931: URL: https://github.com/apache/incubator-tvm/pull/5931#issuecomment-650206266 Thanks @mbrookhart , thanks @comaniac for reviewing. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on pull request #5923: Update code_review.rst

2020-06-26 Thread GitBox
tqchen commented on pull request #5923: URL: https://github.com/apache/incubator-tvm/pull/5923#issuecomment-650206455 Thanks @badenh ! Thanks @liangfu @junrushao1994 for reviewing This is an automated message from the Apache

[incubator-tvm] branch master updated (c9203c7 -> 75f2539)

2020-06-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from c9203c7 Add TupleGetItem to CSE (#5931) add 75f2539 Update code_review.rst (#5923) No new revisions

[GitHub] [incubator-tvm] tqchen merged pull request #5931: Add TupleGetItem to CSE

2020-06-26 Thread GitBox
tqchen merged pull request #5931: URL: https://github.com/apache/incubator-tvm/pull/5931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (fcbebea -> c9203c7)

2020-06-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from fcbebea [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching (#5924) add c9203c7 Add

[GitHub] [incubator-tvm] tqchen merged pull request #5923: Update code_review.rst

2020-06-26 Thread GitBox
tqchen merged pull request #5923: URL: https://github.com/apache/incubator-tvm/pull/5923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5855: [RELAY][VM] Add shape_of instruction

2020-06-26 Thread GitBox
tqchen commented on a change in pull request #5855: URL: https://github.com/apache/incubator-tvm/pull/5855#discussion_r446214527 ## File path: python/tvm/relay/op/dialect/vm.py ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] tqchen merged pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
tqchen merged pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-06-26 Thread GitBox
tqchen commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-650205070 @FrozenGene please followup This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
tqchen commented on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650204858 Thanks @jcf94 @merrymercy . this PR is now merged This is an automated message from the Apache Git

[incubator-tvm] branch master updated (e1a1c2a -> fcbebea)

2020-06-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from e1a1c2a [PatternLang] Don't rewrite expressions used outside of the pattern (#5930) add fcbebea

[incubator-tvm] branch master updated (96bf271 -> e1a1c2a)

2020-06-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 96bf271 [TE] Add LegalizeInvalidAttach to legalize the compute_at location after split or fuse (#5917)

[GitHub] [incubator-tvm] tqchen commented on pull request #5930: [PatternLang] Don't rewrite expressions used outside of the pattern

2020-06-26 Thread GitBox
tqchen commented on pull request #5930: URL: https://github.com/apache/incubator-tvm/pull/5930#issuecomment-650202765 Thanks @mbrookhart , Thanks @comaniac for reviewing This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5933: Fix string argument mismatch in GraphRuntimeCodegen

2020-06-26 Thread GitBox
tqchen commented on a change in pull request #5933: URL: https://github.com/apache/incubator-tvm/pull/5933#discussion_r446210500 ## File path: python/tvm/relay/backend/graph_runtime_codegen.py ## @@ -85,7 +85,7 @@ def codegen(self, func): param_names =

[GitHub] [incubator-tvm] tqchen closed issue #5928: [PatternLang] The pattern failed to match some subgraphs in a model

2020-06-26 Thread GitBox
tqchen closed issue #5928: URL: https://github.com/apache/incubator-tvm/issues/5928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen merged pull request #5930: [PatternLang] Don't rewrite expressions used outside of the pattern

2020-06-26 Thread GitBox
tqchen merged pull request #5930: URL: https://github.com/apache/incubator-tvm/pull/5930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] kazum opened a new pull request #5934: [CODEGEN][CONTRIB] Various update for CoreML codegen

2020-06-26 Thread GitBox
kazum opened a new pull request #5934: URL: https://github.com/apache/incubator-tvm/pull/5934 - Update relay.ext.coremlcompiler based on the change in #5770. - Support int32 for Core ML input and output - Handle "run" in CoreMLRuntime::GetFunction to measure time with

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail. For example in

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail, for exp `test_arith_intset.py`.

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail.

[GitHub] [incubator-tvm] jcf94 commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 commented on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail, they're actually not always correct. For

  1   2   >