[GitHub] [incubator-tvm] hanzz2007 commented on issue #6093: [BUG] Exception may be throwed when attrs is constructed

2020-07-18 Thread GitBox
hanzz2007 commented on issue #6093: URL: https://github.com/apache/incubator-tvm/issues/6093#issuecomment-660596761 for example ```C++ struct LoopPartitionConfigNode : public tvm::AttrsNode { bool partition_const_loop; TVM_DECLARE_ATTRS(LoopPartitionConfigNode, "tir.tr

[GitHub] [incubator-tvm] hanzz2007 opened a new issue #6093: [BUG] Exception may be throwed when attrs is constructed

2020-07-18 Thread GitBox
hanzz2007 opened a new issue #6093: URL: https://github.com/apache/incubator-tvm/issues/6093 ```C++ template class AttrInitVisitor { public: // Counter of number of matched attributes during visit. // This is used to decide if there is additional unmatched attributes.

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456844187 ## File path: tests/python/unittest/test_auto_scheduler_measure.py ## @@ -18,17 +18,55 @@ """ Test measurement and log serialization. """ import t

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
comaniac commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456834812 ## File path: tests/python/unittest/test_auto_scheduler_measure.py ## @@ -18,17 +18,55 @@ """ Test measurement and log serialization. """ impor

[GitHub] [incubator-tvm] tqchen merged pull request #6091: [Docs] improve the doc of release

2020-07-18 Thread GitBox
tqchen merged pull request #6091: URL: https://github.com/apache/incubator-tvm/pull/6091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch master updated: [Docs] improve the doc of release (#6091)

2020-07-18 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new a3b600a [Docs] improve the doc of releas

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
junrushao1994 commented on pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#issuecomment-660520586 A minor typo we didn't catch before (github doesn't allow me to comment on that line because it is not related to this change): in file "loop_state.h", document for

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456811108 ## File path: src/auto_scheduler/measure_record.cc ## @@ -169,6 +206,18 @@ struct Handler<::tvm::Array<::tvm::auto_scheduler::Step>> { fuse

[GitHub] [incubator-tvm-vta] remotego commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-07-18 Thread GitBox
remotego commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r456264532 ## File path: config/intelfocl_sample.json ## @@ -0,0 +1,13 @@ +{ + "TARGET" : "intelfocl", + "HW_VER" : "0.0.1", Review comment: Agreed. L

[GitHub] [incubator-tvm-vta] zhanghaohit commented on pull request #9: [Hardware][OpenCL] Intelfocl support

2020-07-18 Thread GitBox
zhanghaohit commented on pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-660502710 > Thanks for the changes. Please apply the 0.0.2 and rename the vta target to something more specific, e.g. "arria10". Also there are some CI errors related to linting t

[GitHub] [incubator-tvm] zhanghaohit opened a new pull request #6092: lint: add opencl .cl file type

2020-07-18 Thread GitBox
zhanghaohit opened a new pull request #6092: URL: https://github.com/apache/incubator-tvm/pull/6092 add opencl .cl file type to lint This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] zhanghaohit commented on a change in pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-07-18 Thread GitBox
zhanghaohit commented on a change in pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#discussion_r456797915 ## File path: python/tvm/relay/op/strategy/generic.py ## @@ -323,8 +331,10 @@ def compute_conv2d_transpose(attrs, inputs, out_dtype): o

[GitHub] [incubator-tvm] leonwanghui commented on pull request #5892: Add TVM application extension with WASM runtime

2020-07-18 Thread GitBox
leonwanghui commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-660471166 Thanks @jroesch for the quick review, actually this PR is tightly binded with the TVM rust runtime, but currently I have to define a third-party `Tensor` struct to mee

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456772818 ## File path: tests/python/unittest/test_auto_scheduler_loop_state.py ## @@ -61,5 +61,79 @@ def test_split_fuse_reorder(): assert s1[C].iters[4].

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456772818 ## File path: tests/python/unittest/test_auto_scheduler_loop_state.py ## @@ -61,5 +61,79 @@ def test_split_fuse_reorder(): assert s1[C].iters[4].

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456770051 ## File path: tests/python/unittest/test_auto_scheduler_measure.py ## @@ -18,17 +18,55 @@ """ Test measurement and log serialization. """ import t

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456769902 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -276,10 +276,18 @@ std::pair> ComputeDAG::ApplySteps( // return value, so the ApplyToSched

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6073: [Ansor][AutoTVM v2.0] Phase 1: Add annotation/compute_at/compute_root/compute_inline steps

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6073: URL: https://github.com/apache/incubator-tvm/pull/6073#discussion_r456769902 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -276,10 +276,18 @@ std::pair> ComputeDAG::ApplySteps( // return value, so the ApplyToSched

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner

2020-07-18 Thread GitBox
jcf94 commented on a change in pull request #6077: URL: https://github.com/apache/incubator-tvm/pull/6077#discussion_r456766397 ## File path: tests/python/unittest/test_auto_scheduler_measure.py ## @@ -67,6 +67,26 @@ def test_measure_local_builder_runner(): assert mress[0]