FrozenGene commented on pull request #6294:
URL: https://github.com/apache/incubator-tvm/pull/6294#issuecomment-675267666
Thanks @tqchen @junrushao1994
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
zhaowu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new d2e15c3 [TEST] use rpc.LocalSession for
FrozenGene merged pull request #6294:
URL: https://github.com/apache/incubator-tvm/pull/6294
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
laurawly pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 9cc15a4 [TOPI] Support int4/int8
Laurawly merged pull request #6121:
URL: https://github.com/apache/incubator-tvm/pull/6121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
masahi commented on issue #6282:
URL: https://github.com/apache/incubator-tvm/issues/6282#issuecomment-675204024
@interesaaat Please try https://github.com/apache/incubator-tvm/pull/6295
This is an automated message from
masahi closed issue #6282:
URL: https://github.com/apache/incubator-tvm/issues/6282
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
masahi opened a new pull request #6295:
URL: https://github.com/apache/incubator-tvm/pull/6295
Should fix https://github.com/apache/incubator-tvm/issues/6282
Please review @siju-samuel
This is an automated message
tqchen commented on pull request #6294:
URL: https://github.com/apache/incubator-tvm/pull/6294#issuecomment-675196740
cc @FrozenGene
This is an automated message from the Apache Git Service.
To respond to the message,
tqchen opened a new pull request #6294:
URL: https://github.com/apache/incubator-tvm/pull/6294
To avoid flaky due to networking.
This is an automated message from the Apache Git Service.
To respond to the message, please log
fernchen commented on pull request #6206:
URL: https://github.com/apache/incubator-tvm/pull/6206#issuecomment-675194997
> @fernchen let us skip the tutorials for now and only add the frontend cpu
tests
Thanks for your advice! I have modified the codes, please review the other
part
electriclilies commented on pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284#issuecomment-675194479
@zhiics @icemelon9 @mbrookhart had a few bugs on this, but it's good to go
now! Please let me know what you think. Thanks
samskalicky commented on pull request #6292:
URL: https://github.com/apache/incubator-tvm/pull/6292#issuecomment-675192527
Thanks @tqchen! I will try building this into my code tonight and get back
to you tomorrow
This is
electriclilies opened a new pull request #6293:
URL: https://github.com/apache/incubator-tvm/pull/6293
@icemelon9 pointed out that we can support more layouts than just NCHW and
NHWC in shape functions for resize and upsampling. This PR adds support for
NCHW convertible layouts to
electriclilies commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471836646
##
File path: python/tvm/relay/op/dyn/nn/_nn.py
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
tqchen commented on pull request #6292:
URL: https://github.com/apache/incubator-tvm/pull/6292#issuecomment-675167784
cc @junrushao1994 @samskalicky @zhiics @yzhliu @jroesch @tmoreau89
This is an automated message from the
tqchen opened a new pull request #6292:
URL: https://github.com/apache/incubator-tvm/pull/6292
It is hard to control deallocation order of TVM and other frameworks. So
just keep the global state active and rely on OS to recycle the resources
mbrookhart edited a comment on issue #6237:
URL: https://github.com/apache/incubator-tvm/issues/6237#issuecomment-675023086
It looks like it's failing with NHWC `nearest_neighbor`. Looking at git
blame, it seems @masahi worked on the test utility and @yongwww worked on the
topi op. Could
mbrookhart edited a comment on issue #6237:
URL: https://github.com/apache/incubator-tvm/issues/6237#issuecomment-675023086
It looks like it's failing with NHWC `nearest_neighbor`. Looking at git
blame, it seems @masahi worked on the test utility and @yongwww worked on the
topi op. Could
csullivan commented on a change in pull request #6251:
URL: https://github.com/apache/incubator-tvm/pull/6251#discussion_r471818952
##
File path: python/tvm/relay/__init__.py
##
@@ -43,6 +43,7 @@
from .op import image
from .op import annotation
from .op import vision
+from
icemelon9 commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471817969
##
File path: python/tvm/relay/op/dyn/nn/_nn.py
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
icemelon9 commented on a change in pull request #6251:
URL: https://github.com/apache/incubator-tvm/pull/6251#discussion_r471816816
##
File path: python/tvm/relay/__init__.py
##
@@ -43,6 +43,7 @@
from .op import image
from .op import annotation
from .op import vision
+from
This is an automated email from the ASF dual-hosted git repository.
haichen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 4644991 [ONNX] Update slice to infer attributes when not graph inputs
(#6276)
add 37e870b
icemelon9 merged pull request #6290:
URL: https://github.com/apache/incubator-tvm/pull/6290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
icemelon9 commented on a change in pull request #6289:
URL: https://github.com/apache/incubator-tvm/pull/6289#discussion_r471814828
##
File path: include/tvm/topi/transform.h
##
@@ -481,26 +481,29 @@ inline Tensor stack(const Array& inputs, int axis
= 0, std::string name
*
cnv1989 closed pull request #6291:
URL: https://github.com/apache/incubator-tvm/pull/6291
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cnv1989 opened a new pull request #6291:
URL: https://github.com/apache/incubator-tvm/pull/6291
Thanks for contributing to TVM! Please refer to guideline
https://tvm.apache.org/docs/contribute/ for useful information and tips. After
the pull request is submitted, please request code
masahi commented on pull request #6276:
URL: https://github.com/apache/incubator-tvm/pull/6276#issuecomment-675144746
Thanks @csullivan @mbrookhart
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 4644991 [ONNX] Update slice to infer
masahi merged pull request #6276:
URL: https://github.com/apache/incubator-tvm/pull/6276
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
samskalicky commented on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-675137290
Unfortunately we're starting to see this problem in other frameworks as
well. Heres PyTorch:
```
#0 0x7fff56b0ee60 in
tqchen edited a comment on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-675124439
Unfortunately the device API encapsulation means we cannot simply make them
static(the need of virtual methods for other device APIs). In this case I think
we
tqchen commented on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-675124439
Unfortunately the device API encapsulation means we cannot simply make them
static(the need of virtual methods for other device APIs).
samskalicky commented on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-675123247
@tqchen the CPU/GPU device API classes dont seem to store any state. Can we
just make these APIs static?
electriclilies commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471674501
##
File path: src/relay/op/dyn/nn/upsampling.h
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
electriclilies commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471674361
##
File path: src/relay/op/dyn/nn/upsampling.h
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
areusch commented on a change in pull request #6154:
URL: https://github.com/apache/incubator-tvm/pull/6154#discussion_r471671743
##
File path: src/support/hexdump.h
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
mbrookhart commented on issue #6237:
URL: https://github.com/apache/incubator-tvm/issues/6237#issuecomment-675023086
It looks like it's failing with NHWC `nearest_neighbor. Looking at git
blame, it seems @masahi worked on the test utility and @yongwww worked on the
topi op. Could one or
interesaaat commented on issue #6282:
URL: https://github.com/apache/incubator-tvm/issues/6282#issuecomment-675009079
This should work:
```
import numpy as np
import torch
class My_module(torch.nn.Module):
def __init__(self, features):
super(My_module,
tqchen opened a new pull request #6290:
URL: https://github.com/apache/incubator-tvm/pull/6290
Please join us to welcome @kparzysz-quic as a new committer. He
contributes the initial scaffolding of the TVM hexagon backend. He is also an
expert in LLVM, and regularly sends patches to
leandron commented on pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#issuecomment-674989875
> Mostly LGTM. @Leo-arm, @tristan-arm, @leandron, @u99127, @lhutton1, can
any of you take a look as well since you are more familiar with the ARM side?
Thanks
Leo-arm commented on pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#issuecomment-674989939
We have done internal reviews for our initial integration, this patch and
the next few, and this LGTM.
mbaret commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471603321
##
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
tqchen commented on pull request #5913:
URL: https://github.com/apache/incubator-tvm/pull/5913#issuecomment-674986083
Thanks @FrozenGene @comaniac @merrymercy
This is an automated message from the Apache Git Service.
To
zhiics commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471601797
##
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from e4dc5c8 [Build] Add cmake options into libinfo (#6286)
add f731652 [random] support random fill
tqchen merged pull request #5913:
URL: https://github.com/apache/incubator-tvm/pull/5913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhiics commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471601797
##
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mbaret commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471597402
##
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
zhiics commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471595331
##
File path: src/relay/op/dyn/nn/upsampling.h
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
zhiics commented on pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#issuecomment-674978083
Mostly LGTM. @Leo-arm, @tristan-arm, @leandron, @u99127, @lhutton1, can any
of you take a look as well since you are more familiar with the ARM side?
zhiics commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471588713
##
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mbrookhart commented on a change in pull request #6273:
URL: https://github.com/apache/incubator-tvm/pull/6273#discussion_r471585971
##
File path: src/relay/op/dyn/nn/upsampling.h
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from f6e00a0 [Frontend][Relay] Fix node indices attribute error for
tensorflow 2.3 (#6288)
add e4dc5c8
tqchen merged pull request #6286:
URL: https://github.com/apache/incubator-tvm/pull/6286
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tqchen commented on pull request #6206:
URL: https://github.com/apache/incubator-tvm/pull/6206#issuecomment-674908816
@fernchen let us skip the tutorials for now and only add the frontend cpu
tests
This is an automated
kparzysz-quic commented on a change in pull request #6261:
URL: https://github.com/apache/incubator-tvm/pull/6261#discussion_r471419335
##
File path: src/target/llvm/codegen_hexagon.cc
##
@@ -0,0 +1,812 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
kparzysz-quic commented on a change in pull request #6261:
URL: https://github.com/apache/incubator-tvm/pull/6261#discussion_r471417488
##
File path: python/tvm/contrib/hexagon.py
##
@@ -0,0 +1,212 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
kparzysz-quic commented on a change in pull request #6261:
URL: https://github.com/apache/incubator-tvm/pull/6261#discussion_r471414408
##
File path: tests/python/unittest/test_target_codegen_hexagon.py
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF)
kparzysz-quic commented on a change in pull request #6261:
URL: https://github.com/apache/incubator-tvm/pull/6261#discussion_r471414408
##
File path: tests/python/unittest/test_target_codegen_hexagon.py
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF)
masahi commented on a change in pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r471399762
##
File path: src/runtime/contrib/ethosn/ethosn_runtime.cc
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
lixiaoquan opened a new pull request #6289:
URL: https://github.com/apache/incubator-tvm/pull/6289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mbaret commented on pull request #6222:
URL: https://github.com/apache/incubator-tvm/pull/6222#issuecomment-674782511
Now the docker image is updated this passes CI, could you take another look
@zhiics @masahi ?
This is an
junrushao1994 commented on pull request #6286:
URL: https://github.com/apache/incubator-tvm/pull/6286#issuecomment-674699758
@comaniac I agree. It would be helpful if we have a forum thread discussing
what should be included in the libinfo. A potentially issue is that I might not
have all
FrozenGene commented on a change in pull request #6261:
URL: https://github.com/apache/incubator-tvm/pull/6261#discussion_r471256935
##
File path: python/tvm/contrib/hexagon.py
##
@@ -0,0 +1,212 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
comaniac edited a comment on pull request #6286:
URL: https://github.com/apache/incubator-tvm/pull/6286#issuecomment-674687125
Hey thanks for the change. I agree with your methodology that we could
customize the libinfo to deliver whatever we want. Apparently, it's impractical
to parse
comaniac commented on pull request #6286:
URL: https://github.com/apache/incubator-tvm/pull/6286#issuecomment-674687125
Hey thanks for the change. I agree with your methodology that we could
customize the libinfo to deliver whatever we want. Apparently, it's impractical
to parse
67 matches
Mail list logo