[GitHub] [tvm] gigiblender opened a new pull request, #13776: [CI] Update ci_minimal docker image to cross-compile TVM to aarch64

2023-01-12 Thread GitBox
gigiblender opened a new pull request, #13776: URL: https://github.com/apache/tvm/pull/13776 This PR is a prerequisite to #13714 and needs to be merged before. It contains the changes to the ci_minimal docker image to support minimal cross-compilation of TVM to aarch64. -- This is an aut

[GitHub] [tvm] gigiblender commented on a diff in pull request #13714: [CI] Cross-compile libtvm_runtime to Aarch64 and run tests

2023-01-12 Thread GitBox
gigiblender commented on code in PR #13714: URL: https://github.com/apache/tvm/pull/13714#discussion_r1068650074 ## tests/scripts/task_config_build_minimal_cross_isa.sh: ## @@ -0,0 +1,49 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [tvm] AndrewZhaoLuo merged pull request #13758: [ONNX,FIX] onnx Pad operator `constant_value` omit use default value 0

2023-01-12 Thread GitBox
AndrewZhaoLuo merged PR #13758: URL: https://github.com/apache/tvm/pull/13758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.ap

[GitHub] [tvm] slyubomirsky commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-12 Thread GitBox
slyubomirsky commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1380902667 The problem seems to be that this cast on mainline will not convince Python that the result is an opaque Object rather than a PackedFunc. Not sure how to change it: ```python TV

[GitHub] [tvm] NicolaLancellotti commented on a diff in pull request #13762: Remove tutorials CMSIS dependency when not needed

2023-01-12 Thread GitBox
NicolaLancellotti commented on code in PR #13762: URL: https://github.com/apache/tvm/pull/13762#discussion_r1068501892 ## gallery/how_to/work_with_microtvm/install_cmsis.rst: ## @@ -1,35 +0,0 @@ -.. Licensed to the Apache Software Foundation (ASF) under one Review Comment:

[GitHub] [tvm] driazati commented on a diff in pull request #13714: [CI] Cross-compile libtvm_runtime to Aarch64 and run tests

2023-01-12 Thread GitBox
driazati commented on code in PR #13714: URL: https://github.com/apache/tvm/pull/13714#discussion_r1068498620 ## tests/scripts/task_config_build_minimal_cross_isa.sh: ## @@ -0,0 +1,49 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-12 Thread GitBox
AndrewZhaoLuo commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1380867142 https://github.com/apache/tvm/pull/13775 <-- is probably the best solution to my problem. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [tvm] slyubomirsky commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-12 Thread GitBox
slyubomirsky commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1380866581 Hm, this test worked in my fork. Wonder why it fails in mainline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tvm] tvm-bot commented on pull request #13775: [Target] Make `key=arm_cpu` --> `key=arm_cpu,cpu`

2023-01-12 Thread GitBox
tvm-bot commented on PR #13775: URL: https://github.com/apache/tvm/pull/13775#issuecomment-1380865994 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request, #13775: [Target] Make `key=arm_cpu` --> `key=arm_cpu,cpu`

2023-01-12 Thread GitBox
AndrewZhaoLuo opened a new pull request, #13775: URL: https://github.com/apache/tvm/pull/13775 The `key` in a target is used in dispatching to different strategies. In most of the code base `arm_cpu` --> `cpu`. E.g. in `python/tvm/target/target.py`: ``` def arm_cpu(...):

[GitHub] [tvm] driazati merged pull request #13738: [ci][docker] Make branch names valid before using them as tags

2023-01-12 Thread GitBox
driazati merged PR #13738: URL: https://github.com/apache/tvm/pull/13738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.

[GitHub] [tvm] driazati merged pull request #13689: [docs] Remove empty code blocks

2023-01-12 Thread GitBox
driazati merged PR #13689: URL: https://github.com/apache/tvm/pull/13689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.

[GitHub] [tvm] vvchernov commented on a diff in pull request #13621: [TIR][TOPI][x86][CI] Support skylake avx512

2023-01-12 Thread GitBox
vvchernov commented on code in PR #13621: URL: https://github.com/apache/tvm/pull/13621#discussion_r1068445499 ## tests/python/integration/test_auto_tensorize.py: ## @@ -278,6 +283,17 @@ def test_vnni_dense(): ) +# TODO(vvchernov): need schedule rules and postprocs for

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13762: Remove tutorials CMSIS dependency when not needed

2023-01-12 Thread GitBox
mehrdadh commented on code in PR #13762: URL: https://github.com/apache/tvm/pull/13762#discussion_r1068381448 ## gallery/how_to/work_with_microtvm/install_cmsis.rst: ## @@ -1,35 +0,0 @@ -.. Licensed to the Apache Software Foundation (ASF) under one Review Comment: Please do

[GitHub] [tvm] lhutton1 commented on a diff in pull request #13653: [microNPU] Prepare docker image to update drivers to version 22.08

2023-01-12 Thread GitBox
lhutton1 commented on code in PR #13653: URL: https://github.com/apache/tvm/pull/13653#discussion_r1068313668 ## docker/install/ubuntu_install_ethosu_driver_stack.sh: ## @@ -78,6 +78,17 @@ mkdir -p "${ethosu_dir}" cd "${ethosu_dir}" git clone --branch ${ethosu_driver_ver} "ht

[GitHub] [tvm] tvm-bot commented on pull request #13774: [UnitTest] Parametrized test_arith_iter_affine_map::test_padding

2023-01-12 Thread GitBox
tvm-bot commented on PR #13774: URL: https://github.com/apache/tvm/pull/13774#issuecomment-1380581889 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] Lunderberg opened a new pull request, #13774: [UnitTest] Parametrized test_arith_iter_affine_map::test_padding

2023-01-12 Thread GitBox
Lunderberg opened a new pull request, #13774: URL: https://github.com/apache/tvm/pull/13774 Parametrization helped in the debugging of https://github.com/apache/tvm/pull/13530, but is not otherwise related to that PR. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [tvm] tvm-bot commented on pull request #13773: [Test][Topi] Use binary fractions for crop_and_divide unit tests

2023-01-12 Thread GitBox
tvm-bot commented on PR #13773: URL: https://github.com/apache/tvm/pull/13773#issuecomment-1380470400 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] Lunderberg opened a new pull request, #13773: [Test][Topi] Use binary fractions for crop_and_divide unit tests

2023-01-12 Thread GitBox
Lunderberg opened a new pull request, #13773: URL: https://github.com/apache/tvm/pull/13773 The `crop_and_resize` operator uses floating-point arithmetic to determine whether an index is within a view-box. This can cause the use of `extrapolation_value` to depend on target-dependent roundi

[GitHub] [tvm] tvm-bot commented on pull request #13772: [microNPU] Add hardware constraints for binary elementwise

2023-01-12 Thread GitBox
tvm-bot commented on PR #13772: URL: https://github.com/apache/tvm/pull/13772#issuecomment-1380438263 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] Alexey-Yazev opened a new pull request, #13772: [microNPU] Add hardware constraints for binary elementwise

2023-01-12 Thread GitBox
Alexey-Yazev opened a new pull request, #13772: URL: https://github.com/apache/tvm/pull/13772 Does not fuse min and max operations with requantize if there are different scales as it is not supported on NPU. Since there are hardware constraints, we cannot perform min or max operation fused

[GitHub] [tvm] fPecc opened a new issue, #13771: [Bug] Problem generating Docker image for VitisAI

2023-01-12 Thread GitBox
fPecc opened a new issue, #13771: URL: https://github.com/apache/tvm/issues/13771 I noticed that there is a problem with the docker image for Vitis AI, which I also noticed was detected by @areusch in #13435, but I saw there is no specific issue opened for this, so I wanted to open one with

[GitHub] [tvm] NicolaLancellotti commented on pull request #13762: Remove tutorials CMSIS dependency when not needed

2023-01-12 Thread GitBox
NicolaLancellotti commented on PR #13762: URL: https://github.com/apache/tvm/pull/13762#issuecomment-1380236687 > This looks good, but do these tutorials still need to include instructions to install CMSIS? I'd love to remove this from `micro_aot.py`, `micro_autotune.py`, and `micro_tflite.

[GitHub] [tvm] fzi-peccia opened a new pull request, #13770: Gemmini code generation using microTVM

2023-01-12 Thread GitBox
fzi-peccia opened a new pull request, #13770: URL: https://github.com/apache/tvm/pull/13770 Added integration to generate C code able to execute neural networks on the Gemmini accelerator. Information about this can be found on [this post](https://discuss.tvm.apache.org/t/presenting-the-gen

[GitHub] [tvm] tvm-bot commented on pull request #13770: Gemmini code generation using microTVM

2023-01-12 Thread GitBox
tvm-bot commented on PR #13770: URL: https://github.com/apache/tvm/pull/13770#issuecomment-1380219284 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #13763: [ETHOSN] Remove support for NPU driver 22.05

2023-01-12 Thread GitBox
ashutosh-arm commented on code in PR #13763: URL: https://github.com/apache/tvm/pull/13763#discussion_r1068022670 ## tests/python/contrib/test_ethosn/test_conv2d.py: ## @@ -228,10 +227,7 @@ def test_conv2d_depthwise( ) ), } -if ethosn_api_version()

[GitHub] [tvm] petuca commented on issue #11691: [Bug][MXNet] MXNet dot not working with non 2D tensors

2023-01-12 Thread GitBox
petuca commented on issue #11691: URL: https://github.com/apache/tvm/issues/11691#issuecomment-1380174305 Yes, @padreofthegame this issue has been fixed in PR #11760 . Thank you for the notification. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] petuca closed issue #11691: [Bug][MXNet] MXNet dot not working with non 2D tensors

2023-01-12 Thread GitBox
petuca closed issue #11691: [Bug][MXNet] MXNet dot not working with non 2D tensors URL: https://github.com/apache/tvm/issues/11691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [tvm] padreofthegame commented on issue #11691: [Bug][MXNet] MXNet dot not working with non 2D tensors

2023-01-12 Thread GitBox
padreofthegame commented on issue #11691: URL: https://github.com/apache/tvm/issues/11691#issuecomment-1380169837 Looks like this Issue may be closed? @petuca @masahi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] ekalda merged pull request #13645: [microNPU] Add relu6 relu_n1_to_1 test cases for Ethos-U

2023-01-12 Thread GitBox
ekalda merged PR #13645: URL: https://github.com/apache/tvm/pull/13645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] ashutosh-arm merged pull request #13764: [CI][microTVM]Update ci_cortexm image

2023-01-12 Thread GitBox
ashutosh-arm merged PR #13764: URL: https://github.com/apache/tvm/pull/13764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apa

[GitHub] [tvm] ashutosh-arm commented on pull request #13764: [CI][microTVM]Update ci_cortexm image

2023-01-12 Thread GitBox
ashutosh-arm commented on PR #13764: URL: https://github.com/apache/tvm/pull/13764#issuecomment-1380160011 Thanks @mehrdadh. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [tvm] lhutton1 commented on pull request #13732: [microNPU] Add support for TFLite PAD

2023-01-12 Thread GitBox
lhutton1 commented on PR #13732: URL: https://github.com/apache/tvm/pull/13732#issuecomment-1380066522 Thanks @arina-grovety for the explanation, just following up on some of the questions... I suspect this is a case of needing to expose this functionality from within Vela, I'll see

[GitHub] [tvm] lhutton1 commented on a diff in pull request #13763: [ETHOSN] Remove support for NPU driver 22.05

2023-01-12 Thread GitBox
lhutton1 commented on code in PR #13763: URL: https://github.com/apache/tvm/pull/13763#discussion_r1067899742 ## tests/python/contrib/test_ethosn/test_conv2d.py: ## @@ -228,10 +227,7 @@ def test_conv2d_depthwise( ) ), } -if ethosn_api_version() ==

[GitHub] [tvm] Alexey-Yazev commented on a diff in pull request #13645: [microNPU] Add relu6 relu_n1_to_1 test cases for Ethos-U

2023-01-11 Thread GitBox
Alexey-Yazev commented on code in PR #13645: URL: https://github.com/apache/tvm/pull/13645#discussion_r1067796699 ## tests/python/contrib/test_ethosu/test_codegen.py: ## @@ -1109,6 +1109,77 @@ def leaky_relu_func(x): ) +# conv2d + relu_n1_to_1 is used because separate a

[GitHub] [tvm] masahi merged pull request #13733: [TOPI][OP] Support grouped conv2d_NCHWc

2023-01-11 Thread GitBox
masahi merged PR #13733: URL: https://github.com/apache/tvm/pull/13733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] masahi commented on issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
masahi commented on issue #13768: URL: https://github.com/apache/tvm/issues/13768#issuecomment-1379810702 cc @mvermeulen , is rocm 5 known to work with TVM? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] wangzy0327 commented on issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
wangzy0327 commented on issue #13768: URL: https://github.com/apache/tvm/issues/13768#issuecomment-1379809403 OK, Thank you. I try rocm 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tvm] masahi commented on issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
masahi commented on issue #13768: URL: https://github.com/apache/tvm/issues/13768#issuecomment-1379808346 I don't remember, but we didn't touch any rocm stuff. So I think recent rocm introduced some incompatibility with TVM. I'd try rocm 4 or even 3. -- This is an automated message from t

[GitHub] [tvm] wangzy0327 commented on issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
wangzy0327 commented on issue #13768: URL: https://github.com/apache/tvm/issues/13768#issuecomment-1379803549 > Don't create a new issue when you already have #13768 > > We didn't change any rocm code recently and I'm sure we had a working rocm backend before. So I have no idea what b

[GitHub] [tvm] slyubomirsky commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-11 Thread GitBox
slyubomirsky commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1379802327 Please review @junrushao (or tag other reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] slyubomirsky opened a new pull request, #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-11 Thread GitBox
slyubomirsky opened a new pull request, #13769: URL: https://github.com/apache/tvm/pull/13769 This PR makes a few improvements to `py_converter` to make it more useful for fuzz testing, especially when running larger modules. In particular, these changes are to support returning the d

[GitHub] [tvm] tvm-bot commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-11 Thread GitBox
tvm-bot commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1379801686 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] masahi closed issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
masahi closed issue #13768: [Bug] how to fix rocm platform bugs? URL: https://github.com/apache/tvm/issues/13768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] masahi commented on issue #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
masahi commented on issue #13768: URL: https://github.com/apache/tvm/issues/13768#issuecomment-1379801009 Don't create a new issue when you already have https://github.com/apache/tvm/issues/13768 We didn't change any rocm code recently and I'm sure we had a working rocm backend befor

[GitHub] [tvm] masahi merged pull request #13767: [Relay][Frontend] Span Filling ONNX

2023-01-11 Thread GitBox
masahi merged PR #13767: URL: https://github.com/apache/tvm/pull/13767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] wangzy0327 opened a new issue, #13768: [Bug] how to fix rocm platform bugs?

2023-01-11 Thread GitBox
wangzy0327 opened a new issue, #13768: URL: https://github.com/apache/tvm/issues/13768 At present, my workmate and I use AMD GPU to support the SYCL platform on tvm, and want to do related evaluations on opencl, rocm, and sycl on AMD GPU. At present, I have made the sycl platform on tvm, bu

[GitHub] [tvm] honghuichao commented on issue #13759: [Bug] a bug about onnx aten::index_put.

2023-01-11 Thread GitBox
honghuichao commented on issue #13759: URL: https://github.com/apache/tvm/issues/13759#issuecomment-1379733000 this is my demo extract from my network. @masahi ``` import torch from pdb import set_trace as d import onnx from tvm import relay class TestIndexPut(tor

[GitHub] [tvm] honghuichao commented on issue #13759: [Bug] a bug about onnx aten::index_put.

2023-01-11 Thread GitBox
honghuichao commented on issue #13759: URL: https://github.com/apache/tvm/issues/13759#issuecomment-1379729882 @masahi ##this is test demo extract from my network. thanks. import torch from pdb import set_trace as d import onnx from tvm import relay class TestIndexPut(

[GitHub] [tvm] chunit-quic commented on pull request #13767: [Relay][Frontend] Span Filling ONNX

2023-01-11 Thread GitBox
chunit-quic commented on PR #13767: URL: https://github.com/apache/tvm/pull/13767#issuecomment-1379687912 Hi community, This is a part of the RFC, TVM Explorer Infrastructure. After this PR, the source node information of ONNX will be tagged to the converted relay. Note that the n

[GitHub] [tvm] tvm-bot commented on pull request #13767: [Relay][Frontend] Span Filling ONNX

2023-01-11 Thread GitBox
tvm-bot commented on PR #13767: URL: https://github.com/apache/tvm/pull/13767#issuecomment-1379687063 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] chunit-quic opened a new pull request, #13767: [Relay][Frontend] Span Filling ONNX

2023-01-11 Thread GitBox
chunit-quic opened a new pull request, #13767: URL: https://github.com/apache/tvm/pull/13767 - Set node name as the source name of span during the conversion of ONNX model. - Assign node name to a node based on op type when it is empty. - To get the reference of renamed nodes. Add a fu

[GitHub] [tvm] driazati opened a new issue, #13766: [docs] Some tutorials are missing

2023-01-11 Thread GitBox
driazati opened a new issue, #13766: URL: https://github.com/apache/tvm/issues/13766 Some tutorials that are defined in `gallery/` are not included in the final built website since their enclosing folders are not listed in `docs/conf.py`, for example the `work_with_pytorch` tutorials https

[GitHub] [tvm] AndrewZhaoLuo closed pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
AndrewZhaoLuo closed pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules URL: https://github.com/apache/tvm/pull/13754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379581081 Ah so chatting with @tkonolige and others a bit more, this problem is a bit more complicated and maybe exposes some past inconsistency with tvm.target.Target. Anyway, here are my find

[GitHub] [tvm] masahi merged pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

2023-01-11 Thread GitBox
masahi merged PR #13688: URL: https://github.com/apache/tvm/pull/13688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] masahi commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

2023-01-11 Thread GitBox
masahi commented on PR #13688: URL: https://github.com/apache/tvm/pull/13688#issuecomment-1379531047 Hopefully we overhaul the current API to clean up mostly unused parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [tvm] tkonolige commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

2023-01-11 Thread GitBox
tkonolige commented on PR #13688: URL: https://github.com/apache/tvm/pull/13688#issuecomment-1379524724 @masahi How about we merge this as #13470 is still in discussion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] masahi commented on issue #13759: [Bug] a bug about onnx aten::index_put.

2023-01-11 Thread GitBox
masahi commented on issue #13759: URL: https://github.com/apache/tvm/issues/13759#issuecomment-1379482230 Please provide a reproducible script. Otherwise it is not clear what the issue is, so I'll close it. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [tvm] masahi merged pull request #13730: [Docs] Add `typing-extensions` dependency guide

2023-01-11 Thread GitBox
masahi merged PR #13730: URL: https://github.com/apache/tvm/pull/13730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] cconvey opened a new issue, #13765: [Bug] No symbolic values for TVMScript PrimFunc attribute "calling_conv"

2023-01-11 Thread GitBox
cconvey opened a new issue, #13765: URL: https://github.com/apache/tvm/issues/13765 This lies somewhere between feature-request and bug-report. When writing TVMScript, it's sometimes necessary to specify certain PrimFunc attribute values. E.g.: ``` python @T.prim_func

[GitHub] [tvm] driazati commented on pull request #13689: [docs] Remove empty code blocks

2023-01-11 Thread GitBox
driazati commented on PR #13689: URL: https://github.com/apache/tvm/pull/13689#issuecomment-1379467892 I updated the PR to wrap the configs with ignores and made sure they are inside a code block so they don't show up on their own, so now this PR should make everything look fine from the fr

[GitHub] [tvm] tkonolige merged pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd

2023-01-11 Thread GitBox
tkonolige merged PR #13755: URL: https://github.com/apache/tvm/pull/13755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache

[GitHub] [tvm] cconvey commented on pull request #13569: [tir][testing] Enable intra-IRModule primfunc call

2023-01-11 Thread GitBox
cconvey commented on PR #13569: URL: https://github.com/apache/tvm/pull/13569#issuecomment-1379456152 @Lunderberg @areusch : Mind giving this a look? @JosephTheOctonaut : FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [tvm] mehrdadh commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
mehrdadh commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-1379407755 https://github.com/apache/tvm/pull/13764 is updating the image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] tvm-bot commented on pull request #13764: [CI][microTVM]Update ci_cortexm image

2023-01-11 Thread GitBox
tvm-bot commented on PR #13764: URL: https://github.com/apache/tvm/pull/13764#issuecomment-1379403908 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] mehrdadh opened a new pull request, #13764: [CI][microTVM]Update ci_cortexm image

2023-01-11 Thread GitBox
mehrdadh opened a new pull request, #13764: URL: https://github.com/apache/tvm/pull/13764 This PR updates the ci_cortexm image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [tvm] tvm-bot commented on pull request #13764: [CI][microTVM]Update ci_cortexm image

2023-01-11 Thread GitBox
tvm-bot commented on PR #13764: URL: https://github.com/apache/tvm/pull/13764#issuecomment-1379403899 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on code in PR #13755: URL: https://github.com/apache/tvm/pull/13755#discussion_r1067398808 ## python/tvm/topi/scatter.py: ## @@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode): _verify_scatter_nd_inputs(data, indices, updates)

[GitHub] [tvm] mehrdadh commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
mehrdadh commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-137939 @ashutosh-arm I don't think we need https://github.com/apache/tvm/pull/13762 to merge this. Because Zephyr project API checks for dependency to CMSIS_NN and if the project is not dependent

[GitHub] [tvm] mehrdadh commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
mehrdadh commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-1379397695 Also we could separate updating the image from this PR, I think that should be fine as well -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tvm] mehrdadh commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
mehrdadh commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-1379391976 You need to update the image as well, otherwise it doesn't pass the tests. You can use this image that I just pushed https://hub.docker.com/layers/tlcpack/ci-cortexm/20230111-165944-a9c

[GitHub] [tvm] tkonolige commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd

2023-01-11 Thread GitBox
tkonolige commented on code in PR #13755: URL: https://github.com/apache/tvm/pull/13755#discussion_r1067385975 ## python/tvm/topi/scatter.py: ## @@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode): _verify_scatter_nd_inputs(data, indices, updates) def

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379375276 @tkonolige would you be fine if I made copies of the generic strategies for my target, and properly forward rewrite info there? We still have the problem with generic strategie

[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #13755: [Fix,TOPI] Consolidate generic and x86 scatter nd

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on code in PR #13755: URL: https://github.com/apache/tvm/pull/13755#discussion_r1067342210 ## python/tvm/topi/scatter.py: ## @@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode): _verify_scatter_nd_inputs(data, indices, updates)

[GitHub] [tvm] jwfromm commented on pull request #13761: [TOPI] Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
jwfromm commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1379359559 Looks like this needs to be linted. I think its also worth throwing in a comment explaining this explicit unpacking helps improve flexibility with other incoming layouts. -- This is an a

[GitHub] [tvm] michalpiszczek commented on pull request #13761: [TOPI] Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
michalpiszczek commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1379357838 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] ashutosh-arm opened a new pull request, #13763: [ETHOSN] Remove support for NPU driver 22.05

2023-01-11 Thread GitBox
ashutosh-arm opened a new pull request, #13763: URL: https://github.com/apache/tvm/pull/13763 This commit removes support for NPU driver 22.05 now that tlcpack contains the latest docker image for ci_cpu that comprises support for NPU driver 22.11. cc @lhutton1 -- This is

[GitHub] [tvm] tvm-bot commented on pull request #13763: [ETHOSN] Remove support for NPU driver 22.05

2023-01-11 Thread GitBox
tvm-bot commented on PR #13763: URL: https://github.com/apache/tvm/pull/13763#issuecomment-1379348748 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] junrushao commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
junrushao commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379342692 For context: tuning-based layout rewriting on Relay is quite hacky and buggy because Relay is not designed to support this feature (even if it's necessary to deliver better performance).

[GitHub] [tvm] areusch commented on issue #12739: [ci] Re-enable GPU other build

2023-01-11 Thread GitBox
areusch commented on issue #12739: URL: https://github.com/apache/tvm/issues/12739#issuecomment-1379302692 @mikepapadim has a few cycles to look at this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379293575 Hmm so my bug though has us hit a generic strategy, but metaschedule still rewrites the layout during tuning. During compilation step we get an error since the rewriting is not

[GitHub] [tvm] tkonolige commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
tkonolige commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379283603 Currently auto/metaschedule layout transform is enabled on a target-by-target basis. You're changing the default to be enabled for all targets that do not specify. In the past we've had s

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13754: [Generic] Forward MS and AS rewrites for generic schedules

2023-01-11 Thread GitBox
AndrewZhaoLuo commented on PR #13754: URL: https://github.com/apache/tvm/pull/13754#issuecomment-1379276998 > I don't think this is correct. Specifying `need_meta_schedule_layout` should be set from the specific target strategy. Like here: https://github.com/apache/tvm/blob/main/python/tvm/

[GitHub] [tvm] ashutosh-arm commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
ashutosh-arm commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-1379183364 @mehrdadh we would need to merge https://github.com/apache/tvm/pull/13762 before building Cortex-M docker image. Without that change, some Zephyr tests might fail. -- This is an au

[GitHub] [tvm] ekalda commented on pull request #13761: Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
ekalda commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1379168078 I know it's a miniature PR, but https://tvm.apache.org/docs/contribute/pull_request.html#commit-message-guideline -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tvm] mehrdadh commented on pull request #13760: [CMSIS-NN] Remove support for the old CMSIS NN project

2023-01-11 Thread GitBox
mehrdadh commented on PR #13760: URL: https://github.com/apache/tvm/pull/13760#issuecomment-1379152292 I'm gonna update the docker image to 20.04 once this is merged: https://github.com/apache/tvm/pull/13736 then you can open this PR -- This is an automated message from the Apache Gi

[GitHub] [tvm] ekalda commented on a diff in pull request #13645: [microNPU] Add relu6 relu_n1_to_1 test cases for Ethos-U

2023-01-11 Thread GitBox
ekalda commented on code in PR #13645: URL: https://github.com/apache/tvm/pull/13645#discussion_r1067227196 ## tests/python/contrib/test_ethosu/test_codegen.py: ## @@ -1109,6 +1109,77 @@ def leaky_relu_func(x): ) +# conv2d + relu_n1_to_1 is used because separate activat

[GitHub] [tvm] Mousius merged pull request #13736: [CI][Docker][Cortex-M]Update scripts to update ci_cortexm to Ubuntu 20.04

2023-01-11 Thread GitBox
Mousius merged PR #13736: URL: https://github.com/apache/tvm/pull/13736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.o

[GitHub] [tvm] mehrdadh commented on pull request #13736: [CI][Docker][Cortex-M]Update scripts to update ci_cortexm to Ubuntu 20.04

2023-01-11 Thread GitBox
mehrdadh commented on PR #13736: URL: https://github.com/apache/tvm/pull/13736#issuecomment-1379137378 @Mousius I updated both PR description which will be used for commit message and PR tilte -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [tvm] areusch commented on issue #13586: [Release] v0.11.0 release schedule

2023-01-11 Thread GitBox
areusch commented on issue #13586: URL: https://github.com/apache/tvm/issues/13586#issuecomment-1379070667 we discussed the release in the community meeting this morning. here are notes: - release is running late. @leandron will update the schedule - branch created, current status is p

[GitHub] [tvm] gromero commented on a diff in pull request #13751: [microTVM] Fix security vulnerability CVE-2007-4559

2023-01-11 Thread GitBox
gromero commented on code in PR #13751: URL: https://github.com/apache/tvm/pull/13751#discussion_r1066285222 ## apps/microtvm/zephyr/template_project/microtvm_api_server.py: ## @@ -657,7 +657,26 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec

[GitHub] [tvm] NicolaLancellotti commented on pull request #13762: Remove tutorials CMSIS dependencies when not needed

2023-01-11 Thread GitBox
NicolaLancellotti commented on PR #13762: URL: https://github.com/apache/tvm/pull/13762#issuecomment-137905 @ashutosh-arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [tvm] tvm-bot commented on pull request #13762: Remove tutorials CMSIS dependencies when not needed

2023-01-11 Thread GitBox
tvm-bot commented on PR #13762: URL: https://github.com/apache/tvm/pull/13762#issuecomment-1379042534 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

[GitHub] [tvm] NicolaLancellotti opened a new pull request, #13762: Remove tutorials CMSIS dependencies when not needed

2023-01-11 Thread GitBox
NicolaLancellotti opened a new pull request, #13762: URL: https://github.com/apache/tvm/pull/13762 Pr #13656 added support for CMSIS NN from a new GitHub location. The project at the new location uses a new header `arm_acle.h` which is not always present. This pr removes the CMSIS depe

[GitHub] [tvm] Alexey-Yazev commented on pull request #13645: [microNPU] Add relu6 relu_n1_to_1 test cases for Ethos-U

2023-01-11 Thread GitBox
Alexey-Yazev commented on PR #13645: URL: https://github.com/apache/tvm/pull/13645#issuecomment-1378820135 > so I suspect that if the graph consists only RELU and nothing else, it doesn't get offloaded to NPU at all. in this case requantize operation can be offloaded to NPU >

[GitHub] [tvm] michalpiszczek commented on pull request #13761: Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
michalpiszczek commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1378792355 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] michalpiszczek commented on pull request #13761: Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
michalpiszczek commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1378791553 cc @jwfromm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] michalpiszczek commented on pull request #13761: Fix tuple unpack in conv2d NCHWc int8

2023-01-11 Thread GitBox
michalpiszczek commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1378790845 cc @jfromm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [tvm] tvm-bot commented on pull request #13761: Fix tuple unpack in conv2d nchw int8

2023-01-11 Thread GitBox
tvm-bot commented on PR #13761: URL: https://github.com/apache/tvm/pull/13761#issuecomment-1378788292 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from

<    1   2   3   4   5   6   7   8   9   10   >