[GitHub] [incubator-tvm] tom-gall opened a new issue #6246: new --runtime=c fails for uTVM

2020-08-10 Thread GitBox
tom-gall opened a new issue #6246: URL: https://github.com/apache/incubator-tvm/issues/6246 @areusch The failure looks like graph, c_mod, params = relay.build(mod, target=target, params=params) Traceback (most recent call last): File "./working-micro-st-tflite.py",

[GitHub] [incubator-tvm] vinx13 merged pull request #6225: fix cuda half math function is undefined: hpow, htanh

2020-08-10 Thread GitBox
vinx13 merged pull request #6225: URL: https://github.com/apache/incubator-tvm/pull/6225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r468178808 ## File path: python/tvm/auto_scheduler/auto_schedule.py ## @@ -88,10 +91,76 @@ class SearchPolicy(Object): class EmptyPolicy(SearchPolicy):

[GitHub] [incubator-tvm] trevor-m opened a new pull request #6245: [Mxnet] Support _contrib_SyncBatchNorm

2020-08-10 Thread GitBox
trevor-m opened a new pull request #6245: URL: https://github.com/apache/incubator-tvm/pull/6245 This op can be mapped directly to batch norm. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
merrymercy commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r468171563 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -342,11 +343,16 @@ AccessAnalyzer::AccessAnalyzer(const Array& tensors) {

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#discussion_r468122151 ## File path: python/tvm/driver/tvmc/main.py ## @@ -0,0 +1,90 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] yzhliu commented on pull request #6078: [Autodiff] Optimize and eliminate the Jacobian tensor for te.autodiff

2020-08-10 Thread GitBox
yzhliu commented on pull request #6078: URL: https://github.com/apache/incubator-tvm/pull/6078#issuecomment-671536959 @sergei-grechanik I agree. Perhaps we need performance integration test run periodically as mentioned in https://discuss.tvm.ai/t/efforts-on-benchmarking-for-tvm/

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#discussion_r468109265 ## File path: python/tvm/driver/tvmc/main.py ## @@ -0,0 +1,74 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
leandron commented on a change in pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#discussion_r468104675 ## File path: python/tvm/driver/tvmc/main.py ## @@ -0,0 +1,74 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

2020-08-10 Thread GitBox
d-smirnov commented on a change in pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#discussion_r468032556 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -2456,25 +2456,27 @@ def test_forward_sparse_to_dense(): # Fully Connected #

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #6024: [Relay][TF] Make StridedSlice support dynamic input and constant attrs

2020-08-10 Thread GitBox
kevinthesun commented on a change in pull request #6024: URL: https://github.com/apache/incubator-tvm/pull/6024#discussion_r468093208 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1458,6 +1458,15 @@ def _impl(inputs, attr, params, mod): return

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
leandron commented on a change in pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#discussion_r468086427 ## File path: python/tvm/driver/tvmc/main.py ## @@ -0,0 +1,74 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#discussion_r468076880 ## File path: python/tvm/driver/tvmc/main.py ## @@ -0,0 +1,74 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] csullivan commented on pull request #6229: [RPC] Update build support for cross compiling apps/cpp_rpc with OpenCL

2020-08-10 Thread GitBox
csullivan commented on pull request #6229: URL: https://github.com/apache/incubator-tvm/pull/6229#issuecomment-671475808 @FrozenGene Thanks for the good suggestions. I updated the documentation and build system for embedded linux to use the same flow as previously described the docs.

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r468047987 ## File path: tests/python/contrib/test_ethosn/infrastructure.py ## @@ -0,0 +1,225 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r468046750 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
comaniac commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r468041057 ## File path: src/relay/backend/contrib/ethosn/codegen.cc ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

2020-08-10 Thread GitBox
d-smirnov commented on a change in pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#discussion_r468032556 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -2456,25 +2456,27 @@ def test_forward_sparse_to_dense(): # Fully Connected #

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

2020-08-10 Thread GitBox
d-smirnov commented on a change in pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#discussion_r468024543 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1720,7 +1719,7 @@ def convert_fully_connected(self, op): # Dense expected

[GitHub] [incubator-tvm] d-smirnov commented on a change in pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

2020-08-10 Thread GitBox
d-smirnov commented on a change in pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#discussion_r468024161 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1695,10 +1695,9 @@ def convert_fully_connected(self, op): raise

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-10 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r468018504 ## File path: tests/python/unittest/test_custom_datatypes_change_dtype.py ## @@ -81,163 +81,109 @@ def setup(): # You can pick a code for

[GitHub] [incubator-tvm] tqchen commented on pull request #6240: [Relay]Refine tensorflow frontend 1.x & 2.x compatibility

2020-08-10 Thread GitBox
tqchen commented on pull request #6240: URL: https://github.com/apache/incubator-tvm/pull/6240#issuecomment-671442393 Thanks @xutianming ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen merged pull request #6240: [Relay]Refine tensorflow frontend 1.x & 2.x compatibility

2020-08-10 Thread GitBox
tqchen merged pull request #6240: URL: https://github.com/apache/incubator-tvm/pull/6240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5940: Add Quantize/Dequantize Partitioning

2020-08-10 Thread GitBox
tqchen edited a comment on pull request #5940: URL: https://github.com/apache/incubator-tvm/pull/5940#issuecomment-671440740 @weberlo please rebase to resolve the conflict. @ZihengJiang please help to manage this PR This is

[GitHub] [incubator-tvm] tqchen commented on pull request #5940: Add Quantize/Dequantize Partitioning

2020-08-10 Thread GitBox
tqchen commented on pull request #5940: URL: https://github.com/apache/incubator-tvm/pull/5940#issuecomment-671440740 @weberlo please rebase to resolve the conflict. @ZihengJiang please help manage this PR This is an

[GitHub] [incubator-tvm] tqchen commented on pull request #6170: [BYOC][ACL] Improve installation tutorial

2020-08-10 Thread GitBox
tqchen commented on pull request #6170: URL: https://github.com/apache/incubator-tvm/pull/6170#issuecomment-671439854 Thanks @lhutton1 @leandron @comaniac This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] tqchen commented on pull request #6127: quanitze operation expanded to take const argument

2020-08-10 Thread GitBox
tqchen commented on pull request #6127: URL: https://github.com/apache/incubator-tvm/pull/6127#issuecomment-671440132 cc @anijain2305 please followup This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] tqchen merged pull request #6170: [BYOC][ACL] Improve installation tutorial

2020-08-10 Thread GitBox
tqchen merged pull request #6170: URL: https://github.com/apache/incubator-tvm/pull/6170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen commented on pull request #6162: [Parser] Parser 2.0 part 2

2020-08-10 Thread GitBox
tqchen commented on pull request #6162: URL: https://github.com/apache/incubator-tvm/pull/6162#issuecomment-671439329 @jroesch please followup to address the CI error This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tqchen commented on pull request #6190: [Ansor][AutoTVM v2.0] Phase 1: feature extraction for cost models

2020-08-10 Thread GitBox
tqchen commented on pull request #6190: URL: https://github.com/apache/incubator-tvm/pull/6190#issuecomment-671439086 per discussion with @merrymercy : - split the feature extraction logic into FeatureExtractor(callback by visitor) and visitor. - Provide FeatureExtractor for each

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671433629 Thanks @quic-sanirudh what you said about rfactor makes sense. We can still support rfactor, by checking the factor indices, and only assign the init value if the

[GitHub] [incubator-tvm] tqchen commented on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen commented on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671433629 Thanks @quic-sanirudh what you said about rfactor makes sense. We can still support rfactor, by checking the factor indices, and only assign the init value if the factor

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-670992782 Thanks @quic-sanirudh for proposing the new change. My only conern wrt to the custom initialization value is that it might break the follow up primitives, e.g.

[GitHub] [incubator-tvm] tqchen commented on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen commented on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671431691 TIR level scheduling is still in an early stage so no RFC yet, will keep you updated once the RFC is out.

[GitHub] [incubator-tvm] tqchen commented on pull request #6236: [TOPI, Cuda] Fix conv2d_transpose output padding

2020-08-10 Thread GitBox
tqchen commented on pull request #6236: URL: https://github.com/apache/incubator-tvm/pull/6236#issuecomment-671429187 Thanks @vinx13 ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen merged pull request #6236: [TOPI, Cuda] Fix conv2d_transpose output padding

2020-08-10 Thread GitBox
tqchen merged pull request #6236: URL: https://github.com/apache/incubator-tvm/pull/6236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen closed issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

2020-08-10 Thread GitBox
tqchen closed issue #6179: URL: https://github.com/apache/incubator-tvm/issues/6179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen commented on pull request #6227: [TIR][Hybrid] Hybrid Script Support for TIR

2020-08-10 Thread GitBox
tqchen commented on pull request #6227: URL: https://github.com/apache/incubator-tvm/pull/6227#issuecomment-671422431 Thanks @spectrometerHBH @junrushao1994 @Hzfengsy . This PR is now merged This is an automated message from

[GitHub] [incubator-tvm] tqchen merged pull request #6227: [TIR][Hybrid] Hybrid Script Support for TIR

2020-08-10 Thread GitBox
tqchen merged pull request #6227: URL: https://github.com/apache/incubator-tvm/pull/6227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#discussion_r467972074 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1695,10 +1695,9 @@ def convert_fully_connected(self, op): raise

[GitHub] [incubator-tvm] mbaret commented on pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#issuecomment-671392518 In addition to the suggested changes, I've added some further comments/documentation and moved implementations out of header files.

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467945546 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467945163 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] jainris commented on pull request #6243: [TFLite] Implemented EXPAND_DIMS Operator for TFLite.

2020-08-10 Thread GitBox
jainris commented on pull request #6243: URL: https://github.com/apache/incubator-tvm/pull/6243#issuecomment-671357199 cc @anijain2305 @u99127 @mbaret @FrozenGene @tqchen This is an automated message from the Apache Git

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467886421 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.cc ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467859711 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467886079 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
FrozenGene commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r467880423 ## File path: src/auto_scheduler/search_policy/utils.cc ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
jcf94 commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r467878808 ## File path: src/auto_scheduler/search_policy/utils.cc ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
jcf94 commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r467878505 ## File path: include/tvm/auto_scheduler/search_policy.h ## @@ -89,46 +100,54 @@ class SearchCallback : public ObjectRef {

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
FrozenGene commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r467875817 ## File path: src/auto_scheduler/search_policy/utils.cc ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467867668 ## File path: src/runtime/contrib/ethosn/ethosn_device.cc ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] jainris opened a new pull request #6243: [TFLite] Implemented EXPAND_DIMS Operator for TFLite.

2020-08-10 Thread GitBox
jainris opened a new pull request #6243: URL: https://github.com/apache/incubator-tvm/pull/6243 * Added implementation for EXPAND_DIMS Operator. * Added tests for EXPAND_DIMS Operator. This is an automated message from

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6223: [TFLite] Implemented ONE_HOT Operator for TFLite.

2020-08-10 Thread GitBox
FrozenGene commented on pull request #6223: URL: https://github.com/apache/incubator-tvm/pull/6223#issuecomment-671322235 Thanks @jainris @leandron This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] FrozenGene merged pull request #6223: [TFLite] Implemented ONE_HOT Operator for TFLite.

2020-08-10 Thread GitBox
FrozenGene merged pull request #6223: URL: https://github.com/apache/incubator-tvm/pull/6223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467861916 ## File path: tests/python/contrib/test_ethosn/infrastructure.py ## @@ -0,0 +1,225 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467861628 ## File path: src/runtime/contrib/ethosn/ethosn_device.cc ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467860284 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.cc ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467859711 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467856126 ## File path: src/relay/backend/contrib/ethosn/codegen.cc ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467850167 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.h ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467850461 ## File path: src/relay/backend/contrib/ethosn/ethosn_api.cc ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] cloud-mxd commented on pull request #6242: [relay][ir] add string type to relay ir

2020-08-10 Thread GitBox
cloud-mxd commented on pull request #6242: URL: https://github.com/apache/incubator-tvm/pull/6242#issuecomment-671304980 At the same time, thanks to @MarisaKirisame for the help and support This is an automated message from

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
leandron edited a comment on pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-671295731 @comaniac here is a new version of this patch with only the minimal code to enable the command line. Follow up patches, that I will send after this, will deal

[GitHub] [incubator-tvm] leandron commented on pull request #6112: TVMC - a command line driver for TVM (Part 1)

2020-08-10 Thread GitBox
leandron commented on pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-671295731 @comaniac here is a new version of this patch with only the minimal code to enable the command line. Follow up patches, that I will send after this, will deal with

[GitHub] [incubator-tvm] leandron commented on pull request #6112: TVMC - a command line driver for TVM

2020-08-10 Thread GitBox
leandron commented on pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-671292078 > The command name`tvmc` sounds strange, it is not immediately obvious what the c stands for. Can the shell command be called just `tvm compile` `tvm tune` etc. same as

[GitHub] [incubator-tvm] cloud-mxd commented on pull request #6242: [relay][ir] add string type to relay ir

2020-08-10 Thread GitBox
cloud-mxd commented on pull request #6242: URL: https://github.com/apache/incubator-tvm/pull/6242#issuecomment-671282626 Thanks for reply and support, RFC link below: https://discuss.tvm.ai/t/rfc-relay-containers-array-map-string/7560 @tqchen

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6222: [BYOC][ETHOSN] Introduce the Ethos-N BYOC integration

2020-08-10 Thread GitBox
mbaret commented on a change in pull request #6222: URL: https://github.com/apache/incubator-tvm/pull/6222#discussion_r467806804 ## File path: tests/python/contrib/test_ethosn/infrastructure.py ## @@ -0,0 +1,225 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6184: [Ansor][AutoTVM v2.0] Phase 2: Basic CPU Sketch Search Policy

2020-08-10 Thread GitBox
jcf94 commented on a change in pull request #6184: URL: https://github.com/apache/incubator-tvm/pull/6184#discussion_r467778942 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -342,11 +343,16 @@ AccessAnalyzer::AccessAnalyzer(const Array& tensors) {

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6229: [RPC] Update build support for cross compiling apps/cpp_rpc with OpenCL

2020-08-10 Thread GitBox
FrozenGene commented on pull request #6229: URL: https://github.com/apache/incubator-tvm/pull/6229#issuecomment-671245122 ping @csullivan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] FrozenGene merged pull request #6241: [COMMUNITY] jcf94 -> Reviewer

2020-08-10 Thread GitBox
FrozenGene merged pull request #6241: URL: https://github.com/apache/incubator-tvm/pull/6241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] masahi merged pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-10 Thread GitBox
masahi merged pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] masahi commented on pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-10 Thread GitBox
masahi commented on pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-671178412 Thanks @shiwenloong @leandron This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] cloud-mxd commented on pull request #6242: [relay][ir] add string type to relay ir

2020-08-09 Thread GitBox
cloud-mxd commented on pull request #6242: URL: https://github.com/apache/incubator-tvm/pull/6242#issuecomment-671161152 > RuntimeObjectType Great idea This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] slyubomirsky commented on a change in pull request #6219: [Runtime][WIP] Add prototype Relay AoT compiler directly into TVM

2020-08-09 Thread GitBox
slyubomirsky commented on a change in pull request #6219: URL: https://github.com/apache/incubator-tvm/pull/6219#discussion_r467686078 ## File path: python/tvm/relay/backend/aot/aot.py ## @@ -0,0 +1,282 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6227: [TIR][Hybrid] Hybrid Script Support for TIR

2020-08-09 Thread GitBox
junrushao1994 commented on a change in pull request #6227: URL: https://github.com/apache/incubator-tvm/pull/6227#discussion_r467684565 ## File path: python/tvm/__init__.py ## @@ -60,6 +60,9 @@ # tvm.parser from . import parser +# tvm tir hybrid script Review comment:

[GitHub] [incubator-tvm] tqchen commented on pull request #6227: [TIR][Hybrid] Hybrid Script Support for TIR

2020-08-09 Thread GitBox
tqchen commented on pull request #6227: URL: https://github.com/apache/incubator-tvm/pull/6227#issuecomment-671157076 cc @Hzfengsy @junrushao1994 please take another look. @spectrometerHBH please add the testcase about report error then it looks good from my side.

[GitHub] [incubator-tvm] tqchen commented on pull request #6242: [relay][ir] add string type to relay ir

2020-08-09 Thread GitBox
tqchen commented on pull request #6242: URL: https://github.com/apache/incubator-tvm/pull/6242#issuecomment-671156792 Thanks for bringing up the PR. It would be great to bring up an RFC discussion thread on the https://discuss.tvm.ai/. In particular, while we acknowledge that it is

[GitHub] [incubator-tvm] cloud-mxd opened a new pull request #6242: [relay][ir] add string type to relay ir

2020-08-09 Thread GitBox
cloud-mxd opened a new pull request #6242: URL: https://github.com/apache/incubator-tvm/pull/6242 I am a mlsys engineer who mainly provides server support for the nlp-related model for the company. In the nlp-related business scenario, we found that tvm can provide superior tensor

[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-09 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671139917 Hi @tqchen Thanks for the comments. I was aware of the issue with rfactor primitive, and so I added a check that fails if `init` is used with the rfactor

[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-09 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671139917 Hi @tqchen Thanks for the comments. I was aware of the issue with rfactor primitive, and so I added a check that fails if `init` is used with the rfactor

[GitHub] [incubator-tvm] quic-sanirudh commented on pull request #6138: Add `init` member to ReduceNode

2020-08-09 Thread GitBox
quic-sanirudh commented on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671139917 Hi @tqchen Thanks for the comments. I was aware of the issue with rfactor primitive, and so I added a check that fails if `init` is used with the rfactor

[GitHub] [incubator-tvm] shiwenloong commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
shiwenloong commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467663242 ## File path: src/relay/op/tensor/reduce.cc ## @@ -266,7 +269,7 @@ bool ArgReduceRel(const Array& types, int num_inputs, const Attrs& attrs,

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467661956 ## File path: src/relay/op/tensor/reduce.cc ## @@ -266,7 +269,7 @@ bool ArgReduceRel(const Array& types, int num_inputs, const Attrs& attrs,

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467661956 ## File path: src/relay/op/tensor/reduce.cc ## @@ -266,7 +269,7 @@ bool ArgReduceRel(const Array& types, int num_inputs, const Attrs& attrs,

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467661956 ## File path: src/relay/op/tensor/reduce.cc ## @@ -266,7 +269,7 @@ bool ArgReduceRel(const Array& types, int num_inputs, const Attrs& attrs,

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467660320 ## File path: include/tvm/relay/attrs/reduce.h ## @@ -60,6 +60,37 @@ struct ReduceAttrs : public tvm::AttrsNode { "Whether to perform

[GitHub] [incubator-tvm] shiwenloong commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
shiwenloong commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467655004 ## File path: include/tvm/relay/attrs/reduce.h ## @@ -60,6 +60,37 @@ struct ReduceAttrs : public tvm::AttrsNode { "Whether to perform

[GitHub] [incubator-tvm] masahi commented on pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-671120513 > But the inconsistency of `reduce.py` still exists because `std` and `variance` take one more parameter than all other functions in the file. I am not sure if this is a

[GitHub] [incubator-tvm] tqchen opened a new pull request #6241: [COMMUNITY] jcf94 -> Reviewer

2020-08-09 Thread GitBox
tqchen opened a new pull request #6241: URL: https://github.com/apache/incubator-tvm/pull/6241 Please join us to welcome @jcf94 as a new reviewer. He has made a good chunk of contributions to the latest AutoScheduler(AutoTVMv2) as well as support for tensor core related codegen

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467647626 ## File path: src/relay/op/tensor/reduce.cc ## @@ -542,51 +547,61 @@ bool VarianceRel(const Array& types, int num_inputs, const Attrs& attrs,

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467647366 ## File path: src/relay/op/tensor/reduce.cc ## @@ -193,15 +194,19 @@ Array ReduceCompute(const Attrs& attrs, const Array& inp /*! * \brief

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
masahi commented on a change in pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#discussion_r467646978 ## File path: include/tvm/relay/attrs/reduce.h ## @@ -60,6 +60,37 @@ struct ReduceAttrs : public tvm::AttrsNode { "Whether to perform

[GitHub] [incubator-tvm] shiwenloong commented on pull request #6232: [Relay][Op] Add unbiased variance op and corresponding support in pytorch frontend

2020-08-09 Thread GitBox
shiwenloong commented on pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-671093947 > I mean, the new `VarianceAttrs` should also have all attributes of `ReduceAttrs`. The underlying implementation of variance op can continue to be the reduce op.

[GitHub] [incubator-tvm] zyxcambridge commented on issue #4105: [RFC] Auto TensorCore CodeGen

2020-08-09 Thread GitBox
zyxcambridge commented on issue #4105: URL: https://github.com/apache/incubator-tvm/issues/4105#issuecomment-671068483 mark This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] liangfu commented on pull request #6231: [uTVM] fix crt building and running error

2020-08-09 Thread GitBox
liangfu commented on pull request #6231: URL: https://github.com/apache/incubator-tvm/pull/6231#issuecomment-671055593 Thanks @windclarion for the fix. This is now merged. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] liangfu merged pull request #6231: [uTVM] fix crt building and running error

2020-08-09 Thread GitBox
liangfu merged pull request #6231: URL: https://github.com/apache/incubator-tvm/pull/6231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] xutianming opened a new pull request #6240: [Relay]Refine tensorflow frontend 1.x & 2.x compatibility

2020-08-09 Thread GitBox
xutianming opened a new pull request #6240: URL: https://github.com/apache/incubator-tvm/pull/6240 I was compiling a TensorFlow saved model exported by TensorFlow 2.x. I encountered `ImportError` from `_get_tag_set` of `tensorflow_parser.py`. For TensorFlow 2.x,

[GitHub] [incubator-tvm] cloud-mxd commented on issue #6239: [Frontend][PyTorch] NotImplementedError: The following operators are not implemented: ['aten::is_floating_point', 'aten::true_divide']

2020-08-09 Thread GitBox
cloud-mxd commented on issue #6239: URL: https://github.com/apache/incubator-tvm/issues/6239#issuecomment-671016283 @masahi This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] cloud-mxd opened a new issue #6239: [Frontend][PyTorch] NotImplementedError: The following operators are not implemented: ['aten::is_floating_point', 'aten::true_divide']

2020-08-09 Thread GitBox
cloud-mxd opened a new issue #6239: URL: https://github.com/apache/incubator-tvm/issues/6239 I'm using file /python/tvm/relay/frontend/pytorch.py to convert pytorch model, but raise error like this:

  1   2   3   4   5   6   7   8   9   10   >