[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

[GitBox]

comaniac commented on issue #5647:
URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632907849


   Thanks @mbrookhart for the quick fix :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

[GitBox]

comaniac commented on issue #5647:
URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632406321


   Ah I see. Yeah then I totally agree that using pre-order traversal would be 
cleaner.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

[GitBox]

comaniac commented on issue #5647:
URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632403232


   I encountered the similar issue before when we were implementing 
`PartitionGraph` pass in BYOC. We then had a group merging mechanism as you 
mentioned.
   
   I think I didn't quite get the point of using preorder to solve this 
problem. Is this because the first/input nodes of a pattern are impossible to 
be optional?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org