[GitHub] [incubator-tvm] giuseros commented on pull request #6860: [TIR] Add spans to all ExprNodes

2020-11-06 Thread GitBox
giuseros commented on pull request #6860: URL: https://github.com/apache/incubator-tvm/pull/6860#issuecomment-723235173 Hi @jroesch , Thanks for the brilliant explanation! I still think that it would have been very nice to have this explanation on the forum (also for future reference

[GitHub] [incubator-tvm] giuseros commented on pull request #6860: [TIR] Add spans to all ExprNodes

2020-11-06 Thread GitBox
giuseros commented on pull request #6860: URL: https://github.com/apache/incubator-tvm/pull/6860#issuecomment-723204745 Well, I meant an RFC discussing this interface change. In general, I think those interface changes should be first discussed in the discuss forum, and their

[GitHub] [incubator-tvm] giuseros commented on pull request #6860: [TIR] Add spans to all ExprNodes

2020-11-06 Thread GitBox
giuseros commented on pull request #6860: URL: https://github.com/apache/incubator-tvm/pull/6860#issuecomment-723194362 @tkonolige is there an RFC (or anything similar) discussing these changes with an evaluation of the alternative designs?