[GitHub] [incubator-tvm] tqchen commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox 


tqchen commented on pull request #5924:
URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650204858


   Thanks @jcf94 @merrymercy . this PR is now merged



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-25 Thread GitBox 


tqchen commented on pull request #5924:
URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-649619450


   @jcf94 we should add a testcase to test_arith_rewrite_simplify, by 
constructing the case and verify the rules you have worked. Use `isinstance(x, 
tvm.ir.Ramp)` to assert the ramp node



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org