[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-30 Thread GitBox
MarisaKirisame commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-621884928 @zhiics the ANF pass is pretty fast, and it seems like if you sum the size of the graph of all call to ANF, the size will be smaller then the original graph. so i d

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-28 Thread GitBox
MarisaKirisame commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-620976285 I tooked a look at the discuss, and it seems like the way to fix it is to just call ANF from Fold-Constant before going into the interpreter pass. can you do that?

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-28 Thread GitBox
MarisaKirisame commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-620973978 @zhiics I am not asking about the specific case here. I am asking that can they be big. IIRC, they can be arbitarily big, and it seems wrong to copy them. Changin

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5457: [Fix] Add ConstantNode to IsAtomic

2020-04-28 Thread GitBox
MarisaKirisame commented on pull request #5457: URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-620885344 @zhiics how big is a constant? is it ok to copy them around, or is any tensor literal possible in there? --