[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-29 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-651331355 I saw that @siju-samuel added the conv3d_transpose op but with the wrong definition for output_padding. I would rather make a follow-up PR to fix that since I want

[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-29 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-651238029 Sorry about the delay, I was distracted by another project. This is an automated message from the Apache

[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-10 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-642101273 I've confirmed manually that with the tophub changes the vta tests pass. This is an automated message fr

[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-09 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-641526216 The only thing probably missing is an update of tophub for the missing output_padding arguments. This i